Skip to contentSkip to conversation

ARM: S3C6410: Add some lower frequencies for 800MHz base clock operation

PATCH New Mark Brown 2 participants 3 messages Apr 28, 2011 – May 6, 2011

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ARM: S3C6410: Add some lower frequencies for 800MHz base clock operation

By extension from the 667MHz based clocks currently supported add 100MHz and 200MHz operating points. Due to a lack of documentation these have not been confirmed as supported but by extension from the existing frequencies they should be OK and there is less risk than with the previuus patch for 800MHz operation.

---

In spite of the commit log this is based on top of the previous patch.

 arch/arm/mach-s3c64xx/cpufreq.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/mach-s3c64xx/cpufreq.c +2 -0
index db722a5..1e7df30 100644
@@ -37,7 +37,9 @@ static struct s3c64xx_dvfs s3c64xx_dvfs_table[] = {
 
 static struct cpufreq_frequency_table s3c64xx_freq_table[] = {
 	{ 0,  66000 },
+	{ 0, 100000 },
 	{ 0, 133000 },
+	{ 1, 200000 },
 	{ 1, 222000 },
 	{ 1, 266000 },
 	{ 2, 333000 },
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 ARM: S3C6410: Add some lower frequencies for 800MHz base clock operation

Quoted 21 lines · Mark Brown

By extension from the 667MHz based clocks currently supported add 100MHz and 200MHz operating points. Due to a lack of documentation these have not been confirmed as supported but by extension from the existing frequencies they should be OK and there is less risk than with the previuus patch for 800MHz operation.

---

In spite of the commit log this is based on top of the previous patch.

 arch/arm/mach-s3c64xx/cpufreq.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-s3c64xx/cpufreq.c +0 -0

s3c64xx/cpufreq.c
index db722a5..1e7df30 100644

arch/arm/mach-s3c64xx/cpufreq.c static struct s3c64xx_dvfs s3c64xx_dvfs_table[] = {

Quoted 10 lines
arch/arm/mach-s3c64xx/cpufreq.c +2 -1
@@ -37,7 +37,9 @@ static struct s3c64xx_dvfs s3c64xx_dvfs_table[] = {
 
 static struct cpufreq_frequency_table s3c64xx_freq_table[] = {
 	{ 0,  66000 },
+	{ 0, 100000 },
 	{ 0, 133000 },
+	{ 1, 200000 },
 	{ 1, 222000 },
 	{ 1, 266000 },
 	{ 2, 333000 },
--

Hmm, I'm not sure this should be OK...because guided(or tested?) dvfs level is following for 800Mhz.
L3: 133, L2: 266, L1: 400 and L0: 800.

And I couldn't find about supporting of 100Mhz or 200Mhz in its hw design guide. Of course, it doesn't mean this is wrong but at least need to check again.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

author
#2 lore raw

PATCH 1/1 ARM: S3C6410: Add some lower frequencies for 800MHz base clock operation

Quoted 7 lines · Kukjin Kim

Hmm, I'm not sure this should be OK...because guided(or tested?) dvfs level is following for 800Mhz.
L3: 133, L2: 266, L1: 400 and L0: 800.

And I couldn't find about supporting of 100Mhz or 200Mhz in its hw design guide. Of course, it doesn't mean this is wrong but at least need to check again.

It appears to work for me in my tests; I've been running my systems like this since I introduced the change. Since it's the same divisions down from 800MHz as the existing ones from 667MHz and the part supports operation down to 66MHz so all the frequencies are well within the absolute limits I'd be a little surprised if there were any problems. As I've not yet been able to obtain the design guide I've no idea about any information it may provide.