KVM-test: Simple stop/continue test
PATCH 1/1 KVM-test: Simple stop/continue test
Change guest state by monitor cmd, verify guest status, and try to login guest by network.
--- client/tests/kvm/tests/stop_continue.py | 52 +++++++++++++++++++++++++++++++ client/tests/kvm/tests_base.cfg.sample | 4 ++ 2 files changed, 56 insertions(+), 0 deletions(-) create mode 100644 client/tests/kvm/tests/stop_continue.py
client/tests/kvm/tests/stop_continue.py new file +52 -0
@@ -0,0 +1,52 @@ +import logging +from autotest_lib.client.common_lib import error + + +def run_stop_continue(test, params, env): + """ + Suspend a running Virtual Machine and verify its state. + + 1) Boot the vm + 2) Suspend the vm through stop command + 3) Verify the state through info status command + 4) Check is the ssh session to guest is still responsive, + if succeed, fail the test. + + @param test: Kvm test object + @param params: Dictionary with the test parameters + @param env: Dictionary with test environment. + """ + vm = env.get_vm(params["main_vm"]) + vm.verify_alive() + timeout = float(params.get("login_timeout", 240)) + session = vm.wait_for_login(timeout=timeout) + + try: + logging.info("Suspend the virtual machine") + vm.monitor.cmd("stop") + + logging.info("Verifying the status of virtual machine through monitor") + o = vm.monitor.info("status") + if 'paused' not in o and ( "u'running': False" not in str(o)): + logging.error(o) + raise error.TestFail("Fail to suspend through monitor command line") + + logging.info("Check the session responsiveness") + if session.is_responsive(): + raise error.TestFail("Session is still responsive after stop") + + logging.info("Try to resume the guest") + vm.monitor.cmd("cont") + + o = vm.monitor.info("status") + m_type = params.get("monitor_type", "human") + if ('human' in m_type and 'running' not in o) or\ + ('qmp' in m_type and "u'running': True" not in str(o)): + logging.error(o) + raise error.TestFail("Could not continue the execution") + + logging.info("Try to re-log into guest") + session = vm.wait_for_login(timeout=timeout) + + finally: + session.close()
client/tests/kvm/tests_base.cfg.sample +4 -0
@@ -260,6 +260,10 @@ variants: - systemtap: test_control_file = systemtap.control + - stop_continue: + type = stop_continue + kill_vm_on_error = yes + - linux_s3: install setup unattended_install.cdrom only Linux type = linux_s3
Quoted 2 lines · Amos Kong
Change guest state by monitor cmd, verify guest status, and try to login guest by network.
I don't like the way you're handling human monitor and QMP monitors in this tests... comments below:
Quoted 34 lines
Signed-off-by Jason Wang <[email protected]>Signed-off-by Amos Kong <[email protected]>---
client/tests/kvm/tests/stop_continue.py | 52 +++++++++++++++++++++++++++++++ client/tests/kvm/tests_base.cfg.sample | 4 ++2 files changed, 56 insertions(+), 0 deletions(-)create mode 100644
client/tests/kvm/tests/stop_continue.pyclient/tests/kvm/tests/stop_continue.py new file +20
-0@@ -0,0 +1,52 @@ +import logging +from autotest_lib.client.common_lib import error + + +def run_stop_continue(test, params, env): + """ + Suspend a running Virtual Machine and verify its state. + + 1) Boot the vm + 2) Suspend the vm through stop command + 3) Verify the state through info status command + 4) Check is the ssh session to guest is still responsive, + if succeed, fail the test. + + @param test: Kvm test object + @param params: Dictionary with the test parameters + @param env: Dictionary with test environment. + """ + vm = env.get_vm(params["main_vm"]) + vm.verify_alive()
client/tests/kvm/tests/stop_continue.py line 30
Quoted 10 lines
client/tests/kvm/tests/stop_continue.py new file +10
-0+ timeout = float(params.get("login_timeout", 240)) + session = vm.wait_for_login(timeout=timeout) + + try: + logging.info("Suspend the virtual machine") + vm.monitor.cmd("stop") + + logging.info("Verifying the status of virtual machine through monitor") + o = vm.monitor.info("status") + if 'paused' not in o and ( "u'running': False" not in str(o)):
^ Here, it's not clear what means a paused qmp monitor or a hmp monitor. this statement is unnecessarily confusing. Here
'paused' not in o -> Is what would define a 'not paused hmp monitor'
"u'running': False" not in str(o) -> This defines a 'not paused qmp monitor'
why we are checking one _and_ the other, as one monitor can't be hmp and qmp at the same time? It would be at least _or_. And like I said, it's non trivial to flow this assertion made.
It seems to me that a better (although involving more code changes) approach is:
1) Introduce VM methods is_paused and verify_paused, which would internally for the kvm vm class, call monitor methods also called is_paused and verify_paused, with implementations for both hmp and qmp. verify_paused would throw an exception in case of a failure, while is_paused would return a boolean.
Quoted 4 lines
client/tests/kvm/tests/stop_continue.py new file +4
-0+ logging.error(o) + raise error.TestFail("Fail to suspend through monitor command line") + + logging.info("Check the session responsiveness")
client/tests/kvm/tests/stop_continue.py line 44
Quoted 10 lines
client/tests/kvm/tests/stop_continue.py new file +10
-0+ if session.is_responsive(): + raise error.TestFail("Session is still responsive after stop") + + logging.info("Try to resume the guest") + vm.monitor.cmd("cont") + + o = vm.monitor.info("status") + m_type = params.get("monitor_type", "human") + if ('human' in m_type and 'running' not in o) or\ + ('qmp' in m_type and "u'running': True" not in str(o)):
^ same here, we should have is_running and verify_running methods on VM that would call monitor methods with the same names.
Now, of course I might be really mistaken here, would like to hear your opinion on that subject.
Signature · 1 line
Lucas
PATCH 1/3 KVM-test: introduce a verify_status method
This method is used to check if VM status is same as we expected.
---
0 files changed, 0 insertions(+), 0 deletions(-)
client/virt/kvm_monitor.py +26 -0
@@ -282,6 +282,18 @@ class HumanMonitor(Monitor): self.cmd("info status", debug=False) + def verify_status(self, status): + """ + Verify VM status + + @param status: Optional VM status, 'running' or 'paused' + @return: return True if VM status is same as we expected + """ + o = self.cmd("info status", debug=False) + if status=='paused' or status=='running': + return (status in o) + + # Command wrappers # Notes: # - All of the following commands raise exceptions in a similar manner to
@@ -650,6 +662,20 @@ class QMPMonitor(Monitor): self.cmd(cmd="query-status", debug=False) + def verify_status(self, status): + """ + Verify VM status + + @param status: Optional VM status, 'running' or 'paused' + @return: return True if VM status is same as we expected + """ + o = str(self.cmd(cmd="query-status", debug=False)) + if (status=='paused' and "u'running': False" in o): + return True + if (status=='running' and "u'running': True" in o): + return True + + def get_events(self): """ Return a list of the asynchronous events received since the last
client/virt/kvm_vm.py +9 -0
@@ -82,6 +82,15 @@ class VM(virt_vm.BaseVM): return not self.process or not self.process.is_alive() + def verify_status(self, status): + """ + Check VM status + + @param status: Optional VM status, 'running' or 'paused' + @raise VMStatusError: If the VM status is not same as parameter + """ + if not self.monitor.verify_status(status): + raise virt_vm.VMStatusError("VM status is unexpected.") def clone(self, name=None, params=None, root_dir=None, address_cache=None,
client/virt/virt_vm.py +2 -0
@@ -185,6 +185,8 @@ class VMMigrateStateMismatchError(VMMigrateError): class VMRebootError(VMError): pass +class VMStatusError(VMError): + pass def get_image_filename(params, root_dir): """
PATCH 2/3 KVM-test: Simple stop/continue test
In reply to Lucas Meneghel RodriguesChange guest state by monitor cmd, verify guest status, and try to login guest by network.
Changes from v1:
- use new method verify_status() to check vm status
--- client/tests/kvm/tests/stop_continue.py | 43 +++++++++++++++++++++++++++++++ client/tests/kvm/tests_base.cfg.sample | 4 +++ 2 files changed, 47 insertions(+), 0 deletions(-) create mode 100644 client/tests/kvm/tests/stop_continue.py
client/tests/kvm/tests/stop_continue.py new file +43 -0
@@ -0,0 +1,43 @@ +import logging +from autotest_lib.client.common_lib import error + + +def run_stop_continue(test, params, env): + """ + Suspend a running Virtual Machine and verify its state. + + 1) Boot the vm + 2) Suspend the vm through stop command + 3) Verify the state through info status command + 4) Check is the ssh session to guest is still responsive, + if succeed, fail the test. + + @param test: Kvm test object + @param params: Dictionary with the test parameters + @param env: Dictionary with test environment. + """ + vm = env.get_vm(params["main_vm"]) + vm.verify_alive() + timeout = float(params.get("login_timeout", 240)) + session = vm.wait_for_login(timeout=timeout) + + try: + logging.info("Stop the VM") + vm.monitor.cmd("stop") + logging.info("Verifying the status of VM is 'paused'") + vm.verify_status("paused") + + logging.info("Check the session is responsive") + if session.is_responsive(): + raise error.TestFail("Session is still responsive after stop") + + logging.info("Try to resume the guest") + vm.monitor.cmd("cont") + logging.info("Verifying the status of VM is 'running'") + vm.verify_status("running") + + logging.info("Try to re-log into guest") + session = vm.wait_for_login(timeout=timeout) + + finally: + session.close()
client/tests/kvm/tests_base.cfg.sample +4 -0
@@ -261,6 +261,10 @@ variants: - systemtap: test_control_file = systemtap.control + - stop_continue: + type = stop_continue + kill_vm_on_error = yes + - linux_s3: install setup unattended_install.cdrom only Linux type = linux_s3
PATCH 3/3 KVM-test: Check if guest bootable after reseting several times
In reply to Lucas Meneghel RodriguesThis test comes from a regression bug:
Guest can not found bootable device after reseting several times by monitor command.
https://bugzilla.redhat.com/show_bug.cgi?id=531026
Changes from v1:
- add bug id to commitlog
- remove unnecessary imports
- add some log message
--- client/tests/kvm/tests/system_reset_bootable.py | 31 +++++++++++++++++++++++ client/tests/kvm/tests_base.cfg.sample | 7 +++++ 2 files changed, 38 insertions(+), 0 deletions(-) create mode 100755 client/tests/kvm/tests/system_reset_bootable.py
client/tests/kvm/tests/system_reset_bootable.py new file +31 -0
@@ -0,0 +1,31 @@ +import logging, time +from autotest_lib.client.common_lib import error + +def run_system_reset_bootable(test, params, env): + """ + KVM reset test: + 1) Boot guest. + 2) Reset system by monitor command for several times. + 3) Log into the guest to verify it could normally boot. + + @param test: kvm test object + @param params: Dictionary with the test parameters + @param env: Dictionary with test environment. + """ + vm = env.get_vm(params["main_vm"]) + vm.verify_alive() + timeout = float(params.get("login_timeout", 240)) + reset_times = int(params.get("reset_times",20)) + interval = int(params.get("reset_interval",10)) + wait_time = int(params.get("wait_time_for_reset",60)) + + logging.info("Wait for %d seconds before reset" % wait_time) + time.sleep(wait_time) + + for i in range(reset_times): + logging.info("Reset the system by monitor cmd") + vm.monitor.cmd("system_reset") + time.sleep(interval) + + logging.info("Try to login guest after reset") + session = vm.wait_for_login(timeout=timeout)
client/tests/kvm/tests_base.cfg.sample +7 -0
@@ -962,6 +962,13 @@ variants: sleep_before_reset = 20 kill_vm_on_error = yes + - system_reset_bootable: + type = system_reset_bootable + interval = 1 + reset_times = 20 + wait_time_for_reset = 120 + kill_vm_on_error = yes + - shutdown: install setup unattended_install.cdrom type = shutdown shutdown_method = shell