Skip to contentSkip to conversation

acpid-1.0.10-r5.1 fails compilation

PATCH In review Søren Holm 4 participants 11 messages May 10, 2011 – May 17, 2011

lore
Share & tools
lore
#0 lore raw

Hi

Current master fails during acpid-compilation.

ERROR: Logfile of failure stored in: /home/sgh/oe-new-oe/build-vmc16/tmp/work/i686-angstrom-linux/acpid-1.0.10-r5.1/temp/log.do_compile.14235 Log data follows:

| ERROR: Function 'do_compile' failed (see /home/sgh/oe-new-oe/build-vmc16/tmp/work/i686-angstrom-linux/acpid-1.0.10-r5.1/temp/log.do_compile.14235 for further information)
| + cd /home/sgh/oe-new-oe/build-vmc16/tmp/work/i686-angstrom-linux/acpid-1.0.10-r5.1/acpid-1.0.10
| + do_compile
| + oe_runmake 'CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux' CROSS=i686-angstrom-linux-
| + oenote make -j 8 'CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux' CROSS=i686-angstrom-linux-
| + echo NOTE: 'make -j 8 CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux CROSS=i686-angstrom-linux-'
| NOTE: make -j 8 CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux CROSS=i686-angstrom-linux-
| + make -j 8 'CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux' CROSS=i686-angstrom-linux-
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\""   -c -o 

acpid.o acpid.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
acpi_ids.o acpi_ids.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
connection_list.o connection_list.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
event.o event.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
input_layer.o input_layer.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
libnetlink.o libnetlink.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
netlink.o netlink.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
proc.o proc.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
sock.o sock.c

| cc1: warnings being treated as errors
| libnetlink.c: In function 'addraw_l':
| libnetlink.c:521:56: error: comparison between signed and unsigned integer expressions
| make: *** [libnetlink.o] Error 1
| make: *** Waiting for unfinished jobs....
| + die 'oe_runmake failed'
| + oefatal 'oe_runmake failed'
| + echo FATAL: 'oe_runmake failed'
| FATAL: oe_runmake failed
| + exit 1

NOTE: package acpid-1.0.10-r5.1: task do_compile: Failed

Signature · 1 line
Søren Holm
#1 lore raw

Dear Søren,

Am Dienstag, den 10.05.2011, 15:55 +0200 schrieb Søren Holm:

Quoted 38 lines

ERROR: Logfile of failure stored in: /home/sgh/oe-new-oe/build-vmc16/tmp/work/i686-angstrom-linux/acpid-1.0.10-r5.1/temp/log.do_compile.14235 Log data follows:

| ERROR: Function 'do_compile' failed (see /home/sgh/oe-new-oe/build-vmc16/tmp/work/i686-angstrom-linux/acpid-1.0.10-r5.1/temp/log.do_compile.14235 for further information)
| + cd /home/sgh/oe-new-oe/build-vmc16/tmp/work/i686-angstrom-linux/acpid-1.0.10-r5.1/acpid-1.0.10
| + do_compile
| + oe_runmake 'CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux' CROSS=i686-angstrom-linux-
| + oenote make -j 8 'CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux' CROSS=i686-angstrom-linux-
| + echo NOTE: 'make -j 8 CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux CROSS=i686-angstrom-linux-'
| NOTE: make -j 8 CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux CROSS=i686-angstrom-linux-
| + make -j 8 'CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux' CROSS=i686-angstrom-linux-
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\""   -c -o 

acpid.o acpid.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
acpi_ids.o acpi_ids.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
connection_list.o connection_list.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
event.o event.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
input_layer.o input_layer.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
libnetlink.o libnetlink.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
netlink.o netlink.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
proc.o proc.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
sock.o sock.c

| cc1: warnings being treated as errors
| libnetlink.c: In function 'addraw_l':
| libnetlink.c:521:56: error: comparison between signed and unsigned integer expressions
| make: *** [libnetlink.o] Error 1
| make: *** Waiting for unfinished jobs....
| + die 'oe_runmake failed'
| + oefatal 'oe_runmake failed'
| + echo FATAL: 'oe_runmake failed'
| FATAL: oe_runmake failed
| + exit 1
Quoted 1 line

NOTE: package acpid-1.0.10-r5.1: task do_compile: Failed

I could build it fine using minimal as distribution for MACHINE = "beagleboard". You seem to compile for i686. I do not know what differs there.

Thanks,

Paul

#2 lore raw
Quoted 14 lines · Paul Menzel

Dear Søren,

Quoted 11 lines
| cc1: warnings being treated as errors
| libnetlink.c: In function 'addraw_l':
| libnetlink.c:521:56: error: comparison between signed and unsigned integer expressions
| make: *** [libnetlink.o] Error 1
| make: *** Waiting for unfinished jobs....
| + die 'oe_runmake failed'
| + oefatal 'oe_runmake failed'
| + echo FATAL: 'oe_runmake failed'
| FATAL: oe_runmake failed
| + exit 1

NOTE: package acpid-1.0.10-r5.1: task do_compile: Failed

Quoted 3 lines

I could build it fine using minimal as distribution for MACHINE = "beagleboard". You seem to compile for i686. I do not know what differs there.

code paths are different between arm and x86. Apply this patch

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=616194#15

and if it helps then post a patch for OE

-Khem

#3 lore raw

Mandag 16 maj 2011 00:16:47 skrev Khem Raj:

Quoted 7 lines

code paths are different between arm and x86. Apply this patch

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=616194#15

and if it helps then post a patch for OE

I changed the code like that too before the weekend. I was afraid to post it because a successfull compilation is not a guarantee that it behaves correctly. Thanks, I'll post the change.

Signature · 1 line
Søren Holm
#4 lore raw

PATCH 1/1 acpid: Make 1.0.10 compile.

Patch is tested on i686.
Compilation failed with the following error :

ERROR: Logfile of failure stored in: /home/sgh/oe-new-oe/build-vmc16/tmp/work/i686-angstrom-linux/acpid-1.0.10-r5.1/temp/log.do_compile.14235 Log data follows:

| ERROR: Function 'do_compile' failed (see /home/sgh/oe-new-oe/build-vmc16/tmp/work/i686-angstrom-linux/acpid-1.0.10-r5.1/temp/log.do_compile.14235 for further information)
| + cd /home/sgh/oe-new-oe/build-vmc16/tmp/work/i686-angstrom-linux/acpid-1.0.10-r5.1/acpid-1.0.10
| + do_compile
| + oe_runmake 'CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux' CROSS=i686-angstrom-linux-
| + oenote make -j 8 'CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux' CROSS=i686-angstrom-linux-
| + echo NOTE: 'make -j 8 CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux CROSS=i686-angstrom-linux-'
| NOTE: make -j 8 CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux CROSS=i686-angstrom-linux-
| + make -j 8 'CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux' CROSS=i686-angstrom-linux-
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\""   -c -o

acpid.o acpid.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
acpi_ids.o acpi_ids.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
connection_list.o connection_list.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
event.o event.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
input_layer.o input_layer.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
libnetlink.o libnetlink.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
netlink.o netlink.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
proc.o proc.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
sock.o sock.c

| cc1: warnings being treated as errors
| libnetlink.c: In function 'addraw_l':
| libnetlink.c:521:56: error: comparison between signed and unsigned integer expressions
| make: *** [libnetlink.o] Error 1
| make: *** Waiting for unfinished jobs....
| + die 'oe_runmake failed'
| + oefatal 'oe_runmake failed'
| + echo FATAL: 'oe_runmake failed'
| FATAL: oe_runmake failed
| + exit 1
NOTE: package acpid-1.0.10-r5.1: task do_compile: Failed
---
 recipes/acpid/acpid-1.0.10/libnetlink.diff |   15 +++++++++++++++
 recipes/acpid/acpid_1.0.10.bb              |    1 +
 2 files changed, 16 insertions(+), 0 deletions(-)
 create mode 100644 recipes/acpid/acpid-1.0.10/libnetlink.diff
recipes/acpid/acpid-1.0.10/libnetlink.diff new file +15 -0
new file mode 100644
index 0000000..59ab951
@@ -0,0 +1,15 @@
+diff --git a/libnetlink.c b/libnetlink.c
+index 6f1ceea..d34dfe4 100644
+--- a/libnetlink.c
++++ b/libnetlink.c
+@@ -518,8 +518,8 @@ int addattr_l(struct nlmsghdr *n, int maxlen, int type, const void *data,
+ 
+ int addraw_l(struct nlmsghdr *n, int maxlen, const void *data, int len)
+ {
+-	if ((int)NLMSG_ALIGN(n->nlmsg_len) + NLMSG_ALIGN(len) > maxlen) {
+-		fprintf(stderr, "addraw_l ERROR: message exceeded bound of %d\n",maxlen);
++	if ((int)NLMSG_ALIGN(n->nlmsg_len) + (int)NLMSG_ALIGN(len) > maxlen) {
++	fprintf(stderr, "addraw_l ERROR: message exceeded bound of %d\n",maxlen);
+ 		return -1;
+ 	}
+ 
recipes/acpid/acpid_1.0.10.bb +1 -0
index 9d3170d..f0a6049 100644
@@ -2,6 +2,7 @@ require acpid.inc
 
 SRC_URI_append = " file://event.c.diff \
                    file://netlink.diff \
+                   file://libnetlink.diff \
                    file://gcc44.diff \
                    file://acpid-sys-stat.patch \
                  "
Signature · 1 line
1.7.4.1
#5 lore raw

Re: [PATCH] acpid: Make 1.0.10 compile.

Quoted 41 lines · Søren Holm

Patch is tested on i686.
Compilation failed with the following error :

ERROR: Logfile of failure stored in: /home/sgh/oe-new-oe/build-vmc16/tmp/work/i686-angstrom-linux/acpid-1.0.10-r5.1/temp/log.do_compile.14235 Log data follows:

| ERROR: Function 'do_compile' failed (see /home/sgh/oe-new-oe/build-vmc16/tmp/work/i686-angstrom-linux/acpid-1.0.10-r5.1/temp/log.do_compile.14235 for further information)
| + cd /home/sgh/oe-new-oe/build-vmc16/tmp/work/i686-angstrom-linux/acpid-1.0.10-r5.1/acpid-1.0.10
| + do_compile
| + oe_runmake 'CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux' CROSS=i686-angstrom-linux-
| + oenote make -j 8 'CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux' CROSS=i686-angstrom-linux-
| + echo NOTE: 'make -j 8 CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux CROSS=i686-angstrom-linux-'
| NOTE: make -j 8 CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux CROSS=i686-angstrom-linux-
| + make -j 8 'CC=i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux' CROSS=i686-angstrom-linux-
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\""   -c -o

acpid.o acpid.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\""   -c -o acpi_ids.o acpi_ids.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\""   -c -o connection_list.o connection_list.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\""   -c -o event.o event.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\""   -c -o input_layer.o input_layer.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\""   -c -o libnetlink.o libnetlink.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\""   -c -o netlink.o netlink.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\""   -c -o proc.o proc.c
| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\""   -c -o sock.o sock.c

| cc1: warnings being treated as errors
| libnetlink.c: In function 'addraw_l':
| libnetlink.c:521:56: error: comparison between signed and unsigned integer expressions
| make: *** [libnetlink.o] Error 1
| make: *** Waiting for unfinished jobs....
| + die 'oe_runmake failed'
| + oefatal 'oe_runmake failed'
| + echo FATAL: 'oe_runmake failed'
| FATAL: oe_runmake failed
| + exit 1
Quoted 1 line

NOTE: package acpid-1.0.10-r5.1: task do_compile: Failed

this log message is ugly and has lot of useless information. Just including one commandline that fails is sufficient. No need to put whatever bitbake puked

Quoted 48 lines

---
 recipes/acpid/acpid-1.0.10/libnetlink.diff |   15 +++++++++++++++ recipes/acpid/acpid_1.0.10.bb              |    1 +

 2 files changed, 16 insertions(+), 0 deletions(-)

 create mode 100644 recipes/acpid/acpid-1.0.10/libnetlink.diff

recipes/acpid/acpid-1.0.10/libnetlink.diff new file +15 -0
new file mode 100644
index 0000000..59ab951
@@ -0,0 +1,15 @@
+diff --git a/libnetlink.c b/libnetlink.c
+index 6f1ceea..d34dfe4 100644
+--- a/libnetlink.c
++++ b/libnetlink.c
+@@ -518,8 +518,8 @@ int addattr_l(struct nlmsghdr *n, int maxlen, int type, const void *data,
+
+ int addraw_l(struct nlmsghdr *n, int maxlen, const void *data, int len)
+ {
+-      if ((int)NLMSG_ALIGN(n->nlmsg_len) + NLMSG_ALIGN(len) > maxlen) {
+-              fprintf(stderr, "addraw_l ERROR: message exceeded bound of %d\n",maxlen);
++      if ((int)NLMSG_ALIGN(n->nlmsg_len) + (int)NLMSG_ALIGN(len) > maxlen) {
++      fprintf(stderr, "addraw_l ERROR: message exceeded bound of %d\n",maxlen);
+               return -1;
+       }
+
recipes/acpid/acpid_1.0.10.bb +1 -0
index 9d3170d..f0a6049 100644
@@ -2,6 +2,7 @@ require acpid.inc
 
  SRC_URI_append = " file://event.c.diff \
                    file://netlink.diff \
+                   file://libnetlink.diff \
                    file://gcc44.diff \
                    file://acpid-sys-stat.patch \

                 "
--
1.7.4.1

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#6 lore raw

PATCH 2/3 acpid: Make 1.0.10 compile.

Patch is tested on i686.
Compilation failed with the following error :

| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
sock.o sock.c

| cc1: warnings being treated as errors
| libnetlink.c: In function 'addraw_l':
| libnetlink.c:521:56: error: comparison between signed and unsigned integer expressions
---
 recipes/acpid/acpid-1.0.10/libnetlink.diff |   15 +++++++++++++++
 recipes/acpid/acpid_1.0.10.bb              |    1 +
 2 files changed, 16 insertions(+), 0 deletions(-)
 create mode 100644 recipes/acpid/acpid-1.0.10/libnetlink.diff
recipes/acpid/acpid-1.0.10/libnetlink.diff new file +15 -0
new file mode 100644
index 0000000..59ab951
@@ -0,0 +1,15 @@
+diff --git a/libnetlink.c b/libnetlink.c
+index 6f1ceea..d34dfe4 100644
+--- a/libnetlink.c
++++ b/libnetlink.c
+@@ -518,8 +518,8 @@ int addattr_l(struct nlmsghdr *n, int maxlen, int type, const void *data,
+ 
+ int addraw_l(struct nlmsghdr *n, int maxlen, const void *data, int len)
+ {
+-	if ((int)NLMSG_ALIGN(n->nlmsg_len) + NLMSG_ALIGN(len) > maxlen) {
+-		fprintf(stderr, "addraw_l ERROR: message exceeded bound of %d\n",maxlen);
++	if ((int)NLMSG_ALIGN(n->nlmsg_len) + (int)NLMSG_ALIGN(len) > maxlen) {
++	fprintf(stderr, "addraw_l ERROR: message exceeded bound of %d\n",maxlen);
+ 		return -1;
+ 	}
+ 
recipes/acpid/acpid_1.0.10.bb +1 -0
index 9d3170d..f0a6049 100644
@@ -2,6 +2,7 @@ require acpid.inc
 
 SRC_URI_append = " file://event.c.diff \
                    file://netlink.diff \
+                   file://libnetlink.diff \
                    file://gcc44.diff \
                    file://acpid-sys-stat.patch \
                  "
Signature · 1 line
1.7.4.1
#7 lore raw

Re: [PATCH 2/3] acpid: Make 1.0.10 compile.

Dear Søren,

Am Montag, den 16.05.2011, 12:21 +0200 schrieb Søren Holm:

Quoted 8 lines

Patch is tested on i686.
Compilation failed with the following error :

| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\"" -c -o
sock.o sock.c

| cc1: warnings being treated as errors
| libnetlink.c: In function 'addraw_l':
| libnetlink.c:521:56: error: comparison between signed and unsigned integer expressions

Christian already submitted a patch for this issue [1][2], but did not provide a Signed-off-by line, which you also forgot in this patch by the way.

Quoted 14 lines
---
 recipes/acpid/acpid-1.0.10/libnetlink.diff |   15 +++++++++++++++
 recipes/acpid/acpid_1.0.10.bb              |    1 +
 2 files changed, 16 insertions(+), 0 deletions(-)
 create mode 100644 recipes/acpid/acpid-1.0.10/libnetlink.diff
recipes/acpid/acpid-1.0.10/libnetlink.diff new file +2 -0
new file mode 100644
index 0000000..59ab951
@@ -0,0 +1,15 @@
+diff --git a/libnetlink.c b/libnetlink.c
+index 6f1ceea..d34dfe4 100644

recipes/acpid/acpid-1.0.10/libnetlink.diff line 12

Quoted 10 lines
recipes/acpid/acpid-1.0.10/libnetlink.diff new file +10 -0
+--- a/libnetlink.c
++++ b/libnetlink.c
+@@ -518,8 +518,8 @@ int addattr_l(struct nlmsghdr *n, int maxlen, int type, const void *data,
+ 
+ int addraw_l(struct nlmsghdr *n, int maxlen, const void *data, int len)
+ {
+-	if ((int)NLMSG_ALIGN(n->nlmsg_len) + NLMSG_ALIGN(len) > maxlen) {
+-		fprintf(stderr, "addraw_l ERROR: message exceeded bound of %d\n",maxlen);
++	if ((int)NLMSG_ALIGN(n->nlmsg_len) + (int)NLMSG_ALIGN(len) > maxlen) {
++	fprintf(stderr, "addraw_l ERROR: message exceeded bound of %d\n",maxlen);

This indentation change is not needed.

Quoted 8 lines
recipes/acpid/acpid-1.0.10/libnetlink.diff new file +3 -0
+ 		return -1;
+ 	}
+ 
recipes/acpid/acpid_1.0.10.bb +0 -0
index 9d3170d..f0a6049 100644

recipes/acpid/acpid_1.0.10.bb require acpid.inc · line 8

Quoted 7 lines
recipes/acpid/acpid_1.0.10.bb +1 -0
@@ -2,6 +2,7 @@ require acpid.inc
 
 SRC_URI_append = " file://event.c.diff \
                    file://netlink.diff \
+                   file://libnetlink.diff \
                    file://gcc44.diff \
                    file://acpid-sys-stat.patch \
                  "

I would say to wait for Christian’s reply to his thread and hopefully will get this in as soon as possible.

Thanks,

Paul

[1] http://patches.openembedded.org/patch/4023/
[2] http://patches.openembedded.org/patch/4061/

#8 lore raw

Re: [PATCH 2/3] acpid: Make 1.0.10 compile.

Søren and Paul:

I've officially signed off on my patch in the other thread, and have also sent an email upstream to ted felix (maintainer of acpid-netlink from which the patch in oe is derived). I'll let you know what I hear back.

Of course my next question is why debian and oe are not using acpid-netlink, but instead cherry pick certain files and then patch vanilla acpid. I'll see if I can figure that out.

Christian

Quoted 72 lines · Paul Menzel

Dear Søren,

Am Montag, den 16.05.2011, 12:21 +0200 schrieb Søren Holm:

Quoted 8 lines

Patch is tested on i686.
Compilation failed with the following error :

| i686-angstrom-linux-gcc -march=pentiumpro --sysroot=/home/sgh/oe-new-oe/build-vmc16/tmp/sysroots/i686-angstrom-linux -W -Wall -Werror -Wundef -Wshadow -D_GNU_SOURCE -O2 -g -DVERSION="\"1.0.10\""   -c -o sock.o sock.c

| cc1: warnings being treated as errors
| libnetlink.c: In function 'addraw_l':
| libnetlink.c:521:56: error: comparison between signed and unsigned integer expressions

Christian already submitted a patch for this issue [1][2], but did not provide a Signed-off-by line, which you also forgot in this patch by the way.

Quoted 14 lines

---
 recipes/acpid/acpid-1.0.10/libnetlink.diff |   15 +++++++++++++++ recipes/acpid/acpid_1.0.10.bb              |    1 +

 2 files changed, 16 insertions(+), 0 deletions(-)

 create mode 100644 recipes/acpid/acpid-1.0.10/libnetlink.diff

recipes/acpid/acpid-1.0.10/libnetlink.diff new file +2 -0
new file mode 100644
index 0000000..59ab951
@@ -0,0 +1,15 @@
+diff --git a/libnetlink.c b/libnetlink.c
+index 6f1ceea..d34dfe4 100644

recipes/acpid/acpid-1.0.10/libnetlink.diff line 12

Quoted 10 lines
recipes/acpid/acpid-1.0.10/libnetlink.diff new file +10 -0
+--- a/libnetlink.c
++++ b/libnetlink.c
+@@ -518,8 +518,8 @@ int addattr_l(struct nlmsghdr *n, int maxlen, int type, const void *data,
+
+ int addraw_l(struct nlmsghdr *n, int maxlen, const void *data, int len)
+ {
+-    if ((int)NLMSG_ALIGN(n->nlmsg_len) + NLMSG_ALIGN(len) > maxlen) {
+-            fprintf(stderr, "addraw_l ERROR: message exceeded bound of %d\n",maxlen);
++    if ((int)NLMSG_ALIGN(n->nlmsg_len) + (int)NLMSG_ALIGN(len) > maxlen) {
++    fprintf(stderr, "addraw_l ERROR: message exceeded bound of %d\n",maxlen);

This indentation change is not needed.

Quoted 14 lines
recipes/acpid/acpid-1.0.10/libnetlink.diff new file +3 -0
+             return -1;
+     }
+
recipes/acpid/acpid_1.0.10.bb +1 -0
index 9d3170d..f0a6049 100644
@@ -2,6 +2,7 @@ require acpid.inc
 
  SRC_URI_append = " file://event.c.diff \
                     file://netlink.diff \
+                   file://libnetlink.diff \
                     file://gcc44.diff \
                     file://acpid-sys-stat.patch \
Quoted 1 line

                  "

I would say to wait for Christian’s reply to his thread and hopefully will get this in as soon as possible.

Thanks,

Paul

[1] http://patches.openembedded.org/patch/4023/
[2] http://patches.openembedded.org/patch/4061/

Signature · 6 lines
For there are moments when one can neither think nor feel.  And if one
can neither think nor feel, she thought, where is one?
 -- Virginia Woolf, "To the Lighthouse"

[Quoted in "VMS Internals and Data Structures", V4.4, when referring
to powerfail recovery.]
#9 lore raw

Re: [PATCH 2/3] acpid: Make 1.0.10 compile.

Dear Christian,

please adhere to the netiquette and do not top post
[1] and use interleaved style. If no quote is needed just delete it.

Am Montag, den 16.05.2011, 21:52 -0400 schrieb Christian Betz:

Quoted 3 lines

Søren and Paul:

I've officially signed off on my patch in the other thread,

I committed your patch in [2].

Søren, please update the state of your patch in the patch queue [3].

Quoted 3 lines

and have also sent an email upstream to ted felix (maintainer of acpid-netlink from which the patch in oe is derived). I'll let you know what I hear back.

Great!

Quoted 3 lines

Of course my next question is why debian and oe are not using acpid-netlink, but instead cherry pick certain files and then patch vanilla acpid. I'll see if I can figure that out.

Maybe Ted can also answer that.

[…]

Thanks,

Paul

[1] http://en.opensuse.org/openSUSE:Mailing_list_netiquette
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=e0d2de398e156fbdc913cc4decf75c357fcf2b33
[3] http://openembedded.org/index.php/Patchwork

#10 lore raw

Re: [PATCH 2/3] acpid: Make 1.0.10 compile.

Tirsdag den 17. maj 2011 12:41:26 skrev Paul Menzel:

Quoted 3 lines

Søren, please update the state of your patch in the patch queue [3].

I marked my patches as superseeded. Christians patch here :
http://patches.openembedded.org/patch/4023 it more clean in regards to indentation.

--
Søren Holm