Skip to contentSkip to conversation

staging: usbip: userspace code

PATCH In review matt mooney 3 participants 23 messages May 14, 2011 – May 17, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover staging: usbip: userspace code

From: matt mooney <[email protected]>

Hi Greg,

Well, here is the userspace code! Let me know what you think. For the source tarball, I chose to add one target with the kernel version, but I am thinking that maybe having `git rev-parse --short HEAD' or something as part of the name would be more useful. I guess that may not matter though depending on how the userspace utilities are versioned.

Thanks,
matt

matt mooney (14):
staging: usbip: add userspace code
staging: usbip: userspace: move manpages to separate directory
staging: usbip: userspace: rename source directories
staging: usbip: userspace: remove unused files
staging: usbip: userspace: whitespace cleanup
staging: usbip: userspace: update module name references
staging: usbip: userspace: configure.ac: major overhaul
staging: usbip: userspace: cleanup makefiles
staging: usbip: userspace: set libusbip version in configure.ac
staging: usbip: userspace: remove revision $Id$
staging: usbip: userspace: remove gcc warnings
staging: usbip: userspace: move common cflags to configure.ac
staging: usbip: userspace: modify project gcc flags
package: Makefile: add USB/IP userspace utilities

 drivers/staging/usbip/userspace/AUTHORS            |    2 +
 drivers/staging/usbip/userspace/COPYING            |  340 +
 drivers/staging/usbip/userspace/INSTALL            |  237 +
 drivers/staging/usbip/userspace/Makefile.am        |   11 +
 drivers/staging/usbip/userspace/README             |  215 +
 drivers/staging/usbip/userspace/autogen.sh         |    9 +
 drivers/staging/usbip/userspace/cleanup.sh         |   10 +
 drivers/staging/usbip/userspace/configure.ac       |  114 +
 drivers/staging/usbip/userspace/doc/usbip.8        |   71 +
 .../usbip/userspace/doc/usbip_bind_driver.8        |   42 +
 drivers/staging/usbip/userspace/doc/usbipd.8       |   62 +
 drivers/staging/usbip/userspace/libsrc/Makefile.am |    7 +
 drivers/staging/usbip/userspace/libsrc/names.c     |  793 ++
 drivers/staging/usbip/userspace/libsrc/names.h     |   57 +
 .../staging/usbip/userspace/libsrc/stub_driver.c   |  390 +
 .../staging/usbip/userspace/libsrc/stub_driver.h   |   36 +
 drivers/staging/usbip/userspace/libsrc/usbip.h     |   19 +
 .../staging/usbip/userspace/libsrc/usbip_common.c  |  282 +
 .../staging/usbip/userspace/libsrc/usbip_common.h  |  149 +
 .../staging/usbip/userspace/libsrc/vhci_driver.c   |  506 +
 .../staging/usbip/userspace/libsrc/vhci_driver.h   |   61 +
 drivers/staging/usbip/userspace/src/Makefile.am    |   10 +
 drivers/staging/usbip/userspace/src/bind-driver.c  |  643 +
 drivers/staging/usbip/userspace/src/usbip.c        |  723 ++
 .../staging/usbip/userspace/src/usbip_network.c    |  251 +
 .../staging/usbip/userspace/src/usbip_network.h    |  198 +
 drivers/staging/usbip/userspace/src/usbipd.c       |  570 +
 drivers/staging/usbip/userspace/src/utils.c        |  255 +
 drivers/staging/usbip/userspace/src/utils.h        |   38 +
 drivers/staging/usbip/userspace/usb.ids            |13209 ++++++++++++++++++++
 scripts/package/Makefile                           |   15 +-
 31 files changed, 19324 insertions(+), 1 deletions(-)
 create mode 100644 drivers/staging/usbip/userspace/AUTHORS
 create mode 100644 drivers/staging/usbip/userspace/COPYING
 create mode 100644 drivers/staging/usbip/userspace/INSTALL
 create mode 100644 drivers/staging/usbip/userspace/Makefile.am
 create mode 100644 drivers/staging/usbip/userspace/README
 create mode 100755 drivers/staging/usbip/userspace/autogen.sh
 create mode 100755 drivers/staging/usbip/userspace/cleanup.sh
 create mode 100644 drivers/staging/usbip/userspace/configure.ac
 create mode 100644 drivers/staging/usbip/userspace/doc/usbip.8
 create mode 100644 drivers/staging/usbip/userspace/doc/usbip_bind_driver.8
 create mode 100644 drivers/staging/usbip/userspace/doc/usbipd.8
 create mode 100644 drivers/staging/usbip/userspace/libsrc/Makefile.am
 create mode 100644 drivers/staging/usbip/userspace/libsrc/names.c
 create mode 100644 drivers/staging/usbip/userspace/libsrc/names.h
 create mode 100644 drivers/staging/usbip/userspace/libsrc/stub_driver.c
 create mode 100644 drivers/staging/usbip/userspace/libsrc/stub_driver.h
 create mode 100644 drivers/staging/usbip/userspace/libsrc/usbip.h
 create mode 100644 drivers/staging/usbip/userspace/libsrc/usbip_common.c
 create mode 100644 drivers/staging/usbip/userspace/libsrc/usbip_common.h
 create mode 100644 drivers/staging/usbip/userspace/libsrc/vhci_driver.c
 create mode 100644 drivers/staging/usbip/userspace/libsrc/vhci_driver.h
 create mode 100644 drivers/staging/usbip/userspace/src/Makefile.am
 create mode 100644 drivers/staging/usbip/userspace/src/bind-driver.c
 create mode 100644 drivers/staging/usbip/userspace/src/usbip.c
 create mode 100644 drivers/staging/usbip/userspace/src/usbip_network.c
 create mode 100644 drivers/staging/usbip/userspace/src/usbip_network.h
 create mode 100644 drivers/staging/usbip/userspace/src/usbipd.c
 create mode 100644 drivers/staging/usbip/userspace/src/utils.c
 create mode 100644 drivers/staging/usbip/userspace/src/utils.h
 create mode 100644 drivers/staging/usbip/userspace/usb.ids
Signature · 1 line
1.7.5.1
#1 lore raw

PATCH 1/14 staging: usbip: add userspace code

From: matt mooney <[email protected]>

From: Takahiro Hirofuchi <[email protected]>

Add userspace code from svn trunk revision 175. Located at
https://usbip.svn.sourceforge.net/svnroot/usbip/linux/trunk/src.

---
 drivers/staging/usbip/userspace/AUTHORS            |    2 +
 drivers/staging/usbip/userspace/COPYING            |  340 +
 drivers/staging/usbip/userspace/INSTALL            |  237 +
 drivers/staging/usbip/userspace/Makefile.am        |    8 +
 drivers/staging/usbip/userspace/NEWS               |    1 +
 drivers/staging/usbip/userspace/README             |  215 +
 drivers/staging/usbip/userspace/autogen.sh         |    9 +
 drivers/staging/usbip/userspace/cleanup.sh         |   10 +
 drivers/staging/usbip/userspace/cmd/Makefile.am    |   21 +
 drivers/staging/usbip/userspace/cmd/bind-driver.c  |  644 +
 drivers/staging/usbip/userspace/cmd/usbip.8        |   71 +
 drivers/staging/usbip/userspace/cmd/usbip.c        |  725 ++
 .../usbip/userspace/cmd/usbip_bind_driver.8        |   42 +
 .../staging/usbip/userspace/cmd/usbip_network.c    |  251 +
 .../staging/usbip/userspace/cmd/usbip_network.h    |  198 +
 drivers/staging/usbip/userspace/cmd/usbipd.8       |   62 +
 drivers/staging/usbip/userspace/cmd/usbipd.c       |  571 +
 drivers/staging/usbip/userspace/cmd/utils.c        |  256 +
 drivers/staging/usbip/userspace/cmd/utils.h        |   38 +
 drivers/staging/usbip/userspace/configure.ac       |  105 +
 drivers/staging/usbip/userspace/lib/Makefile.am    |   10 +
 drivers/staging/usbip/userspace/lib/names.c        |  793 ++
 drivers/staging/usbip/userspace/lib/names.h        |   57 +
 drivers/staging/usbip/userspace/lib/stub_driver.c  |  390 +
 drivers/staging/usbip/userspace/lib/stub_driver.h  |   36 +
 drivers/staging/usbip/userspace/lib/usbip.h        |   19 +
 drivers/staging/usbip/userspace/lib/usbip_common.c |  282 +
 drivers/staging/usbip/userspace/lib/usbip_common.h |  149 +
 drivers/staging/usbip/userspace/lib/vhci_driver.c  |  506 +
 drivers/staging/usbip/userspace/lib/vhci_driver.h  |   61 +
 drivers/staging/usbip/userspace/usb.ids            |13209 ++++++++++++++++++++
 31 files changed, 19318 insertions(+), 0 deletions(-)
 create mode 100644 drivers/staging/usbip/userspace/AUTHORS
 create mode 100644 drivers/staging/usbip/userspace/COPYING
 create mode 100644 drivers/staging/usbip/userspace/ChangeLog
 create mode 100644 drivers/staging/usbip/userspace/INSTALL
 create mode 100644 drivers/staging/usbip/userspace/Makefile.am
 create mode 100644 drivers/staging/usbip/userspace/NEWS
 create mode 100644 drivers/staging/usbip/userspace/README
 create mode 100755 drivers/staging/usbip/userspace/autogen.sh
 create mode 100755 drivers/staging/usbip/userspace/cleanup.sh
 create mode 100644 drivers/staging/usbip/userspace/cmd/Makefile.am
 create mode 100644 drivers/staging/usbip/userspace/cmd/bind-driver.c
 create mode 100644 drivers/staging/usbip/userspace/cmd/usbip.8
 create mode 100644 drivers/staging/usbip/userspace/cmd/usbip.c
 create mode 100644 drivers/staging/usbip/userspace/cmd/usbip_bind_driver.8
 create mode 100644 drivers/staging/usbip/userspace/cmd/usbip_network.c
 create mode 100644 drivers/staging/usbip/userspace/cmd/usbip_network.h
 create mode 100644 drivers/staging/usbip/userspace/cmd/usbipd.8
 create mode 100644 drivers/staging/usbip/userspace/cmd/usbipd.c
 create mode 100644 drivers/staging/usbip/userspace/cmd/utils.c
 create mode 100644 drivers/staging/usbip/userspace/cmd/utils.h
 create mode 100644 drivers/staging/usbip/userspace/configure.ac
 create mode 100644 drivers/staging/usbip/userspace/lib/Makefile.am
 create mode 100644 drivers/staging/usbip/userspace/lib/names.c
 create mode 100644 drivers/staging/usbip/userspace/lib/names.h
 create mode 100644 drivers/staging/usbip/userspace/lib/stub_driver.c
 create mode 100644 drivers/staging/usbip/userspace/lib/stub_driver.h
 create mode 100644 drivers/staging/usbip/userspace/lib/usbip.h
 create mode 100644 drivers/staging/usbip/userspace/lib/usbip_common.c
 create mode 100644 drivers/staging/usbip/userspace/lib/usbip_common.h
 create mode 100644 drivers/staging/usbip/userspace/lib/vhci_driver.c
 create mode 100644 drivers/staging/usbip/userspace/lib/vhci_driver.h
 create mode 100644 drivers/staging/usbip/userspace/usb.ids
drivers/staging/usbip/userspace/AUTHORS new file +2 -0
new file mode 100644
index 0000000..2f73e65
@@ -0,0 +1,2 @@
+Takahiro Hirofuchi
+Robert Leibl
drivers/staging/usbip/userspace/COPYING new file +340 -0

340 lines not on this page · raw message

drivers/staging/usbip/userspace/ChangeLog new file +0 -0
new file mode 100644
index 0000000..e69de29
drivers/staging/usbip/userspace/INSTALL new file +237 -0

237 lines not on this page · raw message

drivers/staging/usbip/userspace/Makefile.am new file +8 -0
new file mode 100644
index 0000000..964f005
@@ -0,0 +1,8 @@
+SUBDIRS = lib cmd
+includedir=@includedir@/usbip
+include_HEADERS = lib/usbip.h lib/usbip_common.h lib/vhci_driver.h lib/stub_driver.h
+
+if INSTALL_USBIDS
+pkgdata_DATA = usb.ids
+EXTRA_DIST = $(pkgdata_DATA)
+endif
drivers/staging/usbip/userspace/NEWS new file +1 -0
new file mode 100644
index 0000000..428b406
@@ -0,0 +1 @@
+link ../NEWS
\ No newline at end of file
drivers/staging/usbip/userspace/README new file +215 -0

215 lines not on this page · raw message

drivers/staging/usbip/userspace/autogen.sh new file +9 -0
new file mode 100755
index 0000000..e1112d3
@@ -0,0 +1,9 @@
+#!/bin/sh -x
+
+#aclocal
+#autoheader
+#libtoolize --copy --force
+#automake-1.9 -acf
+#autoconf
+
+autoreconf -i -f -v
drivers/staging/usbip/userspace/cleanup.sh new file +10 -0
new file mode 100755
index 0000000..da2f89b
@@ -0,0 +1,10 @@
+#!/bin/sh -x
+
+
+if [ -r Makefile ]; then
+	make distclean
+fi
+
+FILES="configure cscope.out Makefile.in depcomp compile config.guess config.sub config.h.in~ config.log config.status ltmain.sh libtool config.h.in autom4te.cache missing aclocal.m4 install-sh cmd/Makefile.in lib/Makefile.in Makefile lib/Makefile cmd/Makefile"
+
+rm -Rf $FILES
drivers/staging/usbip/userspace/cmd/Makefile.am new file +21 -0
new file mode 100644
index 0000000..c923e49
@@ -0,0 +1,21 @@
+# $Id$
+
+sbin_PROGRAMS = usbip usbipd usbip_bind_driver
+
+usbip_SOURCES = usbip.c usbip_network.c usbip_network.h
+usbipd_SOURCES = usbipd.c usbip_network.c usbip_network.h
+usbip_bind_driver_SOURCES = bind-driver.c \
+		utils.c utils.h \
+		usbip_network.h usbip_network.c
+
+dist_man_MANS = usbip.8 usbipd.8 usbip_bind_driver.8
+
+#usbip_bind_driver_CFLAGS = -Wall -W -Wstrict-prototypes @PACKAGE_CFLAGS@
+#usbip_bind_driver_LDADD = @PACKAGE_LIBS@
+
+#AM_CPPFLAGS = -I../include -Wall -std=gnu99
+INCLUDES = -I$(top_srcdir)/lib
+LDADD = ../lib/libusbip.la @PACKAGE_LIBS@
+EXTRA_CFLAGS = @EXTRA_CFLAGS@
+AM_CFLAGS = -Wall -W -Wstrict-prototypes -std=gnu99 $(EXTRA_CFLAGS) @PACKAGE_CFLAGS@ -DUSBIDS_FILE='"@USBIDS_DIR@/usb.ids"'
+
drivers/staging/usbip/userspace/cmd/bind-driver.c new file +644 -0

644 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/usbip.8 new file +71 -0

71 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/usbip.c new file +725 -0

725 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/usbip_bind_driver.8 new file +42 -0

42 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/usbip_network.c new file +251 -0

251 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/usbip_network.h new file +198 -0

198 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/usbipd.8 new file +62 -0

62 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/usbipd.c new file +571 -0

163 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/utils.c new file +256 -0

256 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/utils.h new file +38 -0
new file mode 100644
index 0000000..6c29ae9

Lines of this file are not shown. View the raw message.

drivers/staging/usbip/userspace/configure.ac new file +105 -0

105 lines not on this page · raw message

drivers/staging/usbip/userspace/lib/Makefile.am new file +10 -0
new file mode 100644
index 0000000..10b919d

Lines of this file are not shown. View the raw message.

drivers/staging/usbip/userspace/lib/names.c new file +793 -0

793 lines not on this page · raw message

drivers/staging/usbip/userspace/lib/names.h new file +57 -0

57 lines not on this page · raw message

drivers/staging/usbip/userspace/lib/stub_driver.c new file +390 -0

390 lines not on this page · raw message

drivers/staging/usbip/userspace/lib/stub_driver.h new file +36 -0
new file mode 100644
index 0000000..3107d18

Lines of this file are not shown. View the raw message.

drivers/staging/usbip/userspace/lib/usbip.h new file +19 -0
new file mode 100644
index 0000000..7cb8e6f

Lines of this file are not shown. View the raw message.

drivers/staging/usbip/userspace/lib/usbip_common.c new file +282 -0

282 lines not on this page · raw message

drivers/staging/usbip/userspace/lib/usbip_common.h new file +149 -0

149 lines not on this page · raw message

drivers/staging/usbip/userspace/lib/vhci_driver.c new file +506 -0

506 lines not on this page · raw message

drivers/staging/usbip/userspace/lib/vhci_driver.h new file +61 -0

61 lines not on this page · raw message

drivers/staging/usbip/userspace/usb.ids new file +13209 -0

13,209 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
1.7.5.1

Part of the diff is not shown here. View the raw message.

#2 lore raw

Re: [PATCH 01/14] staging: usbip: add userspace code

drivers/staging/usbip/userspace/usb.ids line 9601

Quoted 2 lines · matt mooney

+0fca Research In Motion, Ltd.

drivers/staging/usbip/userspace/usb.ids new file +1 -0
+	0001  Blackberry Handheld

For Barry, we recognize the following product ID's under the RIM Vendor ID:

0001 The original ID, sometimes we call it Classic
0004 The old Pearl dual-endpoint mode. Had both Mass Storage
and Database endpoints
0006 Pearl in database-only endpoint mode
8001 The 8200 series Pearl Flip
8004 The 8120 Pearl (and some other new models I think)
8007 The Storm

- Chris

#3 lore raw

Re: [PATCH 01/14] staging: usbip: add userspace code

Quoted 6 lines · Chris Frey

drivers/staging/usbip/userspace/usb.ids line 9601

Quoted 2 lines · matt mooney

+0fca Research In Motion, Ltd.

drivers/staging/usbip/userspace/usb.ids new file +1 -0
+	0001  Blackberry Handheld

For Barry, we recognize the following product ID's under the RIM Vendor ID:

Quoted 7 lines

0001 The original ID, sometimes we call it Classic
0004 The old Pearl dual-endpoint mode. Had both Mass Storage
and Database endpoints
0006 Pearl in database-only endpoint mode
8001 The 8200 series Pearl Flip
8004 The 8120 Pearl (and some other new models I think)
8007 The Storm

Are these in the "real" usb.ids file? If not, care to enter them in on the linux-usb.org site so we can sync up there?

This file will be removed from the in-kernel tree as soon as possible, it's just there as part of the original import of the usbip userspace tools. No one should ever have to have 2 copies of this file on their system, that's madness.

thanks,

greg k-h

#4 lore raw

Re: [PATCH 01/14] staging: usbip: add userspace code

Quoted 7 lines · Greg KH

Are these in the "real" usb.ids file? If not, care to enter them in on the linux-usb.org site so we can sync up there?

This file will be removed from the in-kernel tree as soon as possible, it's just there as part of the original import of the usbip userspace tools. No one should ever have to have 2 copies of this file on their system, that's madness.

Thanks. I didn't realize there was a master copy.

I checked linux-usb.org and the extra IDs are already there.

- Chris

#5 lore raw

PATCH 2/14 staging: usbip: userspace: move manpages to separate directory

In reply to matt mooney

From: matt mooney <[email protected]>

---
 drivers/staging/usbip/userspace/Makefile.am        |    2 +
 drivers/staging/usbip/userspace/cmd/Makefile.am    |    2 -
 drivers/staging/usbip/userspace/cmd/usbip.8        |   71 --------------------
 .../usbip/userspace/cmd/usbip_bind_driver.8        |   42 ------------
 drivers/staging/usbip/userspace/cmd/usbipd.8       |   62 -----------------
 drivers/staging/usbip/userspace/doc/usbip.8        |   71 ++++++++++++++++++++
 .../usbip/userspace/doc/usbip_bind_driver.8        |   42 ++++++++++++
 drivers/staging/usbip/userspace/doc/usbipd.8       |   62 +++++++++++++++++
 8 files changed, 177 insertions(+), 177 deletions(-)
 delete mode 100644 drivers/staging/usbip/userspace/cmd/usbip.8
 delete mode 100644 drivers/staging/usbip/userspace/cmd/usbip_bind_driver.8
 delete mode 100644 drivers/staging/usbip/userspace/cmd/usbipd.8
 create mode 100644 drivers/staging/usbip/userspace/doc/usbip.8
 create mode 100644 drivers/staging/usbip/userspace/doc/usbip_bind_driver.8
 create mode 100644 drivers/staging/usbip/userspace/doc/usbipd.8
drivers/staging/usbip/userspace/Makefile.am +2 -0
index 964f005..c076952 100644
@@ -2,6 +2,8 @@ SUBDIRS = lib cmd
 includedir=@includedir@/usbip
 include_HEADERS = lib/usbip.h lib/usbip_common.h lib/vhci_driver.h lib/stub_driver.h
 
+dist_man_MANS := $(addprefix doc/, usbip.8 usbipd.8 usbip_bind_driver.8)
+
 if INSTALL_USBIDS
 pkgdata_DATA = usb.ids
 EXTRA_DIST = $(pkgdata_DATA)
drivers/staging/usbip/userspace/cmd/Makefile.am +0 -2
index c923e49..5cc50fc 100644
@@ -8,8 +8,6 @@ usbip_bind_driver_SOURCES = bind-driver.c \
 		utils.c utils.h \
 		usbip_network.h usbip_network.c
 
-dist_man_MANS = usbip.8 usbipd.8 usbip_bind_driver.8
-
 #usbip_bind_driver_CFLAGS = -Wall -W -Wstrict-prototypes @PACKAGE_CFLAGS@
 #usbip_bind_driver_LDADD = @PACKAGE_LIBS@
 
drivers/staging/usbip/userspace/cmd/usbip.8 deleted +0 -71

71 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/usbip_bind_driver.8 deleted +0 -42

42 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/usbipd.8 deleted +0 -62

62 lines not on this page · raw message

drivers/staging/usbip/userspace/doc/usbip.8 new file +71 -0

71 lines not on this page · raw message

drivers/staging/usbip/userspace/doc/usbip_bind_driver.8 new file +42 -0

42 lines not on this page · raw message

drivers/staging/usbip/userspace/doc/usbipd.8 new file +62 -0

62 lines not on this page · raw message

Signature · 1 line
1.7.5.1
#6 lore raw

PATCH 3/14 staging: usbip: userspace: rename source directories

In reply to matt mooney

From: matt mooney <[email protected]>

Rename cmd/ to src/ and lib/ to libsrc/.

---
 drivers/staging/usbip/userspace/Makefile.am        |    5 +-
 drivers/staging/usbip/userspace/cmd/Makefile.am    |   19 -
 drivers/staging/usbip/userspace/cmd/bind-driver.c  |  644 ----------------
 drivers/staging/usbip/userspace/cmd/usbip.c        |  725 ------------------
 .../staging/usbip/userspace/cmd/usbip_network.c    |  251 ------
 .../staging/usbip/userspace/cmd/usbip_network.h    |  198 -----
 drivers/staging/usbip/userspace/cmd/usbipd.c       |  571 --------------
 drivers/staging/usbip/userspace/cmd/utils.c        |  256 -------
 drivers/staging/usbip/userspace/cmd/utils.h        |   38 -
 drivers/staging/usbip/userspace/configure.ac       |    2 +-
 drivers/staging/usbip/userspace/lib/Makefile.am    |   10 -
 drivers/staging/usbip/userspace/lib/names.c        |  793 --------------------
 drivers/staging/usbip/userspace/lib/names.h        |   57 --
 drivers/staging/usbip/userspace/lib/stub_driver.c  |  390 ----------
 drivers/staging/usbip/userspace/lib/stub_driver.h  |   36 -
 drivers/staging/usbip/userspace/lib/usbip.h        |   19 -
 drivers/staging/usbip/userspace/lib/usbip_common.c |  282 -------
 drivers/staging/usbip/userspace/lib/usbip_common.h |  149 ----
 drivers/staging/usbip/userspace/lib/vhci_driver.c  |  506 -------------
 drivers/staging/usbip/userspace/lib/vhci_driver.h  |   61 --
 drivers/staging/usbip/userspace/libsrc/Makefile.am |   10 +
 drivers/staging/usbip/userspace/libsrc/names.c     |  793 ++++++++++++++++++++
 drivers/staging/usbip/userspace/libsrc/names.h     |   57 ++
 .../staging/usbip/userspace/libsrc/stub_driver.c   |  390 ++++++++++
 .../staging/usbip/userspace/libsrc/stub_driver.h   |   36 +
 drivers/staging/usbip/userspace/libsrc/usbip.h     |   19 +
 .../staging/usbip/userspace/libsrc/usbip_common.c  |  282 +++++++
 .../staging/usbip/userspace/libsrc/usbip_common.h  |  149 ++++
 .../staging/usbip/userspace/libsrc/vhci_driver.c   |  506 +++++++++++++
 .../staging/usbip/userspace/libsrc/vhci_driver.h   |   61 ++
 drivers/staging/usbip/userspace/src/Makefile.am    |   19 +
 drivers/staging/usbip/userspace/src/bind-driver.c  |  644 ++++++++++++++++
 drivers/staging/usbip/userspace/src/usbip.c        |  725 ++++++++++++++++++
 .../staging/usbip/userspace/src/usbip_network.c    |  251 ++++++
 .../staging/usbip/userspace/src/usbip_network.h    |  198 +++++
 drivers/staging/usbip/userspace/src/usbipd.c       |  571 ++++++++++++++
 drivers/staging/usbip/userspace/src/utils.c        |  256 +++++++
 drivers/staging/usbip/userspace/src/utils.h        |   38 +
 38 files changed, 5009 insertions(+), 5008 deletions(-)
 delete mode 100644 drivers/staging/usbip/userspace/cmd/Makefile.am
 delete mode 100644 drivers/staging/usbip/userspace/cmd/bind-driver.c
 delete mode 100644 drivers/staging/usbip/userspace/cmd/usbip.c
 delete mode 100644 drivers/staging/usbip/userspace/cmd/usbip_network.c
 delete mode 100644 drivers/staging/usbip/userspace/cmd/usbip_network.h
 delete mode 100644 drivers/staging/usbip/userspace/cmd/usbipd.c
 delete mode 100644 drivers/staging/usbip/userspace/cmd/utils.c
 delete mode 100644 drivers/staging/usbip/userspace/cmd/utils.h
 delete mode 100644 drivers/staging/usbip/userspace/lib/Makefile.am
 delete mode 100644 drivers/staging/usbip/userspace/lib/names.c
 delete mode 100644 drivers/staging/usbip/userspace/lib/names.h
 delete mode 100644 drivers/staging/usbip/userspace/lib/stub_driver.c
 delete mode 100644 drivers/staging/usbip/userspace/lib/stub_driver.h
 delete mode 100644 drivers/staging/usbip/userspace/lib/usbip.h
 delete mode 100644 drivers/staging/usbip/userspace/lib/usbip_common.c
 delete mode 100644 drivers/staging/usbip/userspace/lib/usbip_common.h
 delete mode 100644 drivers/staging/usbip/userspace/lib/vhci_driver.c
 delete mode 100644 drivers/staging/usbip/userspace/lib/vhci_driver.h
 create mode 100644 drivers/staging/usbip/userspace/libsrc/Makefile.am
 create mode 100644 drivers/staging/usbip/userspace/libsrc/names.c
 create mode 100644 drivers/staging/usbip/userspace/libsrc/names.h
 create mode 100644 drivers/staging/usbip/userspace/libsrc/stub_driver.c
 create mode 100644 drivers/staging/usbip/userspace/libsrc/stub_driver.h
 create mode 100644 drivers/staging/usbip/userspace/libsrc/usbip.h
 create mode 100644 drivers/staging/usbip/userspace/libsrc/usbip_common.c
 create mode 100644 drivers/staging/usbip/userspace/libsrc/usbip_common.h
 create mode 100644 drivers/staging/usbip/userspace/libsrc/vhci_driver.c
 create mode 100644 drivers/staging/usbip/userspace/libsrc/vhci_driver.h
 create mode 100644 drivers/staging/usbip/userspace/src/Makefile.am
 create mode 100644 drivers/staging/usbip/userspace/src/bind-driver.c
 create mode 100644 drivers/staging/usbip/userspace/src/usbip.c
 create mode 100644 drivers/staging/usbip/userspace/src/usbip_network.c
 create mode 100644 drivers/staging/usbip/userspace/src/usbip_network.h
 create mode 100644 drivers/staging/usbip/userspace/src/usbipd.c
 create mode 100644 drivers/staging/usbip/userspace/src/utils.c
 create mode 100644 drivers/staging/usbip/userspace/src/utils.h
drivers/staging/usbip/userspace/Makefile.am +3 -2
index c076952..3be3060 100644
@@ -1,6 +1,7 @@
-SUBDIRS = lib cmd
+SUBDIRS = libsrc src
 includedir=@includedir@/usbip
-include_HEADERS = lib/usbip.h lib/usbip_common.h lib/vhci_driver.h lib/stub_driver.h
+include_HEADERS := $(addprefix libsrc/, \
+		     usbip.h usbip_common.h vhci_driver.h stub_driver.h)
 
 dist_man_MANS := $(addprefix doc/, usbip.8 usbipd.8 usbip_bind_driver.8)
 
drivers/staging/usbip/userspace/cmd/Makefile.am deleted +0 -19
deleted file mode 100644
index 5cc50fc..0000000
@@ -1,19 +0,0 @@
-# $Id$
-
-sbin_PROGRAMS = usbip usbipd usbip_bind_driver
-
-usbip_SOURCES = usbip.c usbip_network.c usbip_network.h
-usbipd_SOURCES = usbipd.c usbip_network.c usbip_network.h
-usbip_bind_driver_SOURCES = bind-driver.c \
-		utils.c utils.h \
-		usbip_network.h usbip_network.c
-
-#usbip_bind_driver_CFLAGS = -Wall -W -Wstrict-prototypes @PACKAGE_CFLAGS@
-#usbip_bind_driver_LDADD = @PACKAGE_LIBS@
-
-#AM_CPPFLAGS = -I../include -Wall -std=gnu99
-INCLUDES = -I$(top_srcdir)/lib
-LDADD = ../lib/libusbip.la @PACKAGE_LIBS@
-EXTRA_CFLAGS = @EXTRA_CFLAGS@
-AM_CFLAGS = -Wall -W -Wstrict-prototypes -std=gnu99 $(EXTRA_CFLAGS) @PACKAGE_CFLAGS@ -DUSBIDS_FILE='"@USBIDS_DIR@/usb.ids"'
-
drivers/staging/usbip/userspace/cmd/bind-driver.c deleted +0 -644

644 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/usbip.c deleted +0 -725

725 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/usbip_network.c deleted +0 -251

251 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/usbip_network.h deleted +0 -198

198 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/usbipd.c deleted +0 -571

571 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/utils.c deleted +0 -256

256 lines not on this page · raw message

drivers/staging/usbip/userspace/cmd/utils.h deleted +0 -38
deleted file mode 100644
index 6c29ae9..0000000
@@ -1,38 +0,0 @@
-
-#ifdef HAVE_CONFIG_H
-#include "../config.h"
-#endif
-
-#define _GNU_SOURCE
-#include <string.h>
-#include <sys/un.h>
-#include <sys/types.h>
-#include <sys/socket.h>
-
-#include <sysfs/libsysfs.h>
-#include <glib.h>
-#include <unistd.h>
-#include <stdio.h>
-#include <sys/types.h>
-#include <sys/stat.h>
-#include <fcntl.h>
-#include <stdlib.h>
-#include <time.h>
-#include <errno.h>
-
-
-
-/* Be sync to kernel header */
-#define BUS_ID_SIZE 20
-
-int read_string(char *path, char *, size_t len);
-int read_integer(char *path);
-int getdevicename(char *busid, char *name, size_t len);
-int getdriver(char *busid, int conf, int infnum, char *driver, size_t len);
-int read_bNumInterfaces(char *busid);
-int read_bConfigurationValue(char *busid);
-int write_integer(char *path, int value);
-int write_bConfigurationValue(char *busid, int config);
-int read_bDeviceClass(char *busid);
-int readline(int sockfd, char *str, int strlen);
-int writeline(int sockfd, char *buff, int bufflen);
drivers/staging/usbip/userspace/configure.ac +1 -1
index 6de5bc7..24fd8ae 100644
@@ -101,5 +101,5 @@ PKG_CHECK_MODULES(PACKAGE, glib-2.0 >= $GLIB2_REQUIRED)
 AC_SUBST(PACKAGE_CFLAGS)
 AC_SUBST(PACKAGE_LIBS)
 
-AC_CONFIG_FILES([Makefile lib/Makefile cmd/Makefile])
+AC_CONFIG_FILES([Makefile libsrc/Makefile src/Makefile])
 AC_OUTPUT
drivers/staging/usbip/userspace/lib/Makefile.am deleted +0 -10
deleted file mode 100644
index 10b919d..0000000
@@ -1,10 +0,0 @@
-# AM_CFLAGS = -Wall -std=gnu99
-lib_LTLIBRARIES = libusbip.la
-libusbip_la_SOURCES = names.c names.h stub_driver.c stub_driver.h usbip.h usbip_common.c usbip_common.h vhci_driver.c vhci_driver.h
-#libusbip_la_SOURCES = names.c names.h stub_driver.c usbip_common.c vhci_driver.c
-#INCLUDES = -I../include
-#AM_CPPFLAGS = -I../include -Wall -std=gnu99
-libusbip_la_LDFLAGS = -version-info 0:1:0
-EXTRA_CFLAGS = @EXTRA_CFLAGS@
-libusbip_la_CFLAGS = -Wall -W -Wstrict-prototypes -std=gnu99 $(EXTRA_CFLAGS) -DUSBIDS_FILE='"@USBIDS_DIR@/usb.ids"'
-
drivers/staging/usbip/userspace/lib/names.c deleted +0 -793

273 lines not on this page · raw message

drivers/staging/usbip/userspace/lib/names.h deleted +0 -57

57 lines not on this page · raw message

drivers/staging/usbip/userspace/lib/stub_driver.c deleted +0 -390

390 lines not on this page · raw message

drivers/staging/usbip/userspace/lib/stub_driver.h deleted +0 -36
deleted file mode 100644
index 3107d18..0000000

Lines of this file are not shown. View the raw message.

drivers/staging/usbip/userspace/lib/usbip.h deleted +0 -19
deleted file mode 100644
index 7cb8e6f..0000000

Lines of this file are not shown. View the raw message.

drivers/staging/usbip/userspace/lib/usbip_common.c deleted +0 -282

282 lines not on this page · raw message

drivers/staging/usbip/userspace/lib/usbip_common.h deleted +0 -149

149 lines not on this page · raw message

drivers/staging/usbip/userspace/lib/vhci_driver.c deleted +0 -506

506 lines not on this page · raw message

drivers/staging/usbip/userspace/lib/vhci_driver.h deleted +0 -61

61 lines not on this page · raw message

drivers/staging/usbip/userspace/libsrc/Makefile.am new file +10 -0
new file mode 100644
index 0000000..10b919d

Lines of this file are not shown. View the raw message.

drivers/staging/usbip/userspace/libsrc/names.c new file +793 -0

793 lines not on this page · raw message

drivers/staging/usbip/userspace/libsrc/names.h new file +57 -0

57 lines not on this page · raw message

drivers/staging/usbip/userspace/libsrc/stub_driver.c new file +390 -0

390 lines not on this page · raw message

drivers/staging/usbip/userspace/libsrc/stub_driver.h new file +36 -0
new file mode 100644
index 0000000..3107d18

Lines of this file are not shown. View the raw message.

drivers/staging/usbip/userspace/libsrc/usbip.h new file +19 -0
new file mode 100644
index 0000000..7cb8e6f

Lines of this file are not shown. View the raw message.

drivers/staging/usbip/userspace/libsrc/usbip_common.c new file +282 -0

282 lines not on this page · raw message

drivers/staging/usbip/userspace/libsrc/usbip_common.h new file +149 -0

149 lines not on this page · raw message

drivers/staging/usbip/userspace/libsrc/vhci_driver.c new file +506 -0

506 lines not on this page · raw message

drivers/staging/usbip/userspace/libsrc/vhci_driver.h new file +61 -0

61 lines not on this page · raw message

drivers/staging/usbip/userspace/src/Makefile.am new file +19 -0
new file mode 100644
index 0000000..3717fc5

Lines of this file are not shown. View the raw message.

drivers/staging/usbip/userspace/src/bind-driver.c new file +644 -0

644 lines not on this page · raw message

drivers/staging/usbip/userspace/src/usbip.c new file +725 -0

725 lines not on this page · raw message

drivers/staging/usbip/userspace/src/usbip_network.c new file +251 -0

251 lines not on this page · raw message

drivers/staging/usbip/userspace/src/usbip_network.h new file +198 -0

198 lines not on this page · raw message

drivers/staging/usbip/userspace/src/usbipd.c new file +571 -0

571 lines not on this page · raw message

drivers/staging/usbip/userspace/src/utils.c new file +256 -0

256 lines not on this page · raw message

drivers/staging/usbip/userspace/src/utils.h new file +38 -0
new file mode 100644
index 0000000..6c29ae9

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
1.7.5.1

Part of the diff is not shown here. View the raw message.

#7 lore raw

PATCH 4/14 staging: usbip: userspace: remove unused files

In reply to matt mooney

From: matt mooney <[email protected]>

Remove ChangeLog and NEWS.

---
 drivers/staging/usbip/userspace/NEWS      |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
 delete mode 100644 drivers/staging/usbip/userspace/ChangeLog
 delete mode 100644 drivers/staging/usbip/userspace/NEWS
drivers/staging/usbip/userspace/ChangeLog deleted +0 -0
deleted file mode 100644
index e69de29..0000000
drivers/staging/usbip/userspace/NEWS deleted +0 -1
deleted file mode 100644
index 428b406..0000000
@@ -1 +0,0 @@
-link ../NEWS
\ No newline at end of file
Signature · 1 line
1.7.5.1
#8 lore raw

PATCH 5/14 staging: usbip: userspace: whitespace cleanup

In reply to matt mooney

From: matt mooney <[email protected]>

---
 drivers/staging/usbip/userspace/COPYING            |   10 ++--
 drivers/staging/usbip/userspace/README             |   40 ++++++++++----------
 drivers/staging/usbip/userspace/configure.ac       |    2 +-
 .../usbip/userspace/doc/usbip_bind_driver.8        |    6 +-
 .../staging/usbip/userspace/libsrc/stub_driver.c   |    2 +-
 drivers/staging/usbip/userspace/src/bind-driver.c  |   10 ++--
 drivers/staging/usbip/userspace/src/usbip.c        |    6 +-
 .../staging/usbip/userspace/src/usbip_network.h    |    4 +-
 8 files changed, 40 insertions(+), 40 deletions(-)
drivers/staging/usbip/userspace/COPYING +5 -5
index 623b625..c5611e4 100644
@@ -55,7 +55,7 @@ patent must be licensed for everyone's free use or not licensed at all.
 
   The precise terms and conditions for copying, distribution and
 modification follow.
-
+
 		    GNU GENERAL PUBLIC LICENSE
    TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
 
@@ -110,7 +110,7 @@ above, provided that you also meet all of these conditions:
     License.  (Exception: if the Program itself is interactive but
     does not normally print such an announcement, your work based on
     the Program is not required to print an announcement.)
-
+
 These requirements apply to the modified work as a whole.  If
 identifiable sections of that work are not derived from the Program,
 and can be reasonably considered independent and separate works in
@@ -168,7 +168,7 @@ access to copy from a designated place, then offering equivalent
 access to copy the source code from the same place counts as
 distribution of the source code, even though third parties are not
 compelled to copy the source along with the object code.
-
+
   4. You may not copy, modify, sublicense, or distribute the Program
 except as expressly provided under this License.  Any attempt
 otherwise to copy, modify, sublicense or distribute the Program is
@@ -225,7 +225,7 @@ impose that choice.
 
 This section is intended to make thoroughly clear what is believed to
 be a consequence of the rest of this License.
-
+
   8. If the distribution and/or use of the Program is restricted in
 certain countries either by patents or by copyrighted interfaces, the
 original copyright holder who places the Program under this License
@@ -278,7 +278,7 @@ PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE
 POSSIBILITY OF SUCH DAMAGES.
 
 		     END OF TERMS AND CONDITIONS
-
+
 	    How to Apply These Terms to Your New Programs
 
   If you develop a new program, and you want it to be of the greatest
drivers/staging/usbip/userspace/README +20 -20
index b274b50..b0df5cb 100644
@@ -48,7 +48,7 @@
         - Bind usbip.ko to the device of busid 1-2.
         - A usb device 1-2 is now exportable to other hosts!
         - Use 'usbip_bind_driver --other 1-2' when you want to shutdown exporting
-          and use the device locally. 
+          and use the device locally.
 
 
     client:# insmod usbip_common_mod.ko
@@ -87,36 +87,36 @@ export a usb hub.
    List USB devices
    - busid 3-3.2 (04bb:0206)
        3-3.2:1.0 -> usb-storage
-   
+
    - busid 3-3.1 (08bb:2702)
        3-3.1:1.0 -> snd-usb-audio
        3-3.1:1.1 -> snd-usb-audio
-   
+
    - busid 3-3 (0409:0058)
        3-3:1.0 -> hub
-   
+
    - busid 3-2 (0711:0902)
        3-2:1.0 -> none
-   
+
    - busid 1-1 (05a9:a511)
        1-1:1.0 -> ov511
-   
+
    - busid 4-1 (046d:08b2)
        4-1:1.0 -> none
        4-1:1.1 -> none
        4-1:1.2 -> none
-   
+
    - busid 5-2 (058f:9254)
        5-2:1.0 -> hub
-   
+
 --------------------------------------------------------------------------------------------------------
 Mark the device of busid 3-3.2 as exportable.
 
    trois:# usbip_bind_driver --usbip 3-3.2
-   ** (process:24621): DEBUG:  3-3.2:1.0   -> none 
+   ** (process:24621): DEBUG:  3-3.2:1.0   -> none
    ** (process:24621): DEBUG: write "add 3-3.2" to /sys/bus/usb/drivers/usbip/match_busid
    ** Message: bind 3-3.2 to usbip, complete!
-   
+
    trois:# usbip_bind_driver --list
    List USB devices
    - busid 3-3.2 (04bb:0206)
@@ -141,41 +141,41 @@ the server host.
              : /sys/devices/pci0000:00/0000:00:1f.2/usb1/1-1
              : (Defined at Interface level) / unknown subclass / unknown protocol (00/00/00)
              :  0 - Mass Storage / SCSI / Bulk (Zip) (08/06/50)
-    
+
       1-2.2.1: Apple Computer, Inc. : unknown product (05ac:0203)
              : /sys/devices/pci0000:00/0000:00:1f.2/usb1/1-2/1-2.2/1-2.2.1
              : (Defined at Interface level) / unknown subclass / unknown protocol (00/00/00)
              :  0 - Human Interface Devices / Boot Interface Subclass / Keyboard (03/01/01)
-    
+
       1-2.2.3: OmniVision Technologies, Inc. : OV511+ WebCam (05a9:a511)
              : /sys/devices/pci0000:00/0000:00:1f.2/usb1/1-2/1-2.2/1-2.2.3
              : (Defined at Interface level) / unknown subclass / unknown protocol (00/00/00)
              :  0 - Vendor Specific Class / unknown subclass / unknown protocol (ff/00/00)
-    
+
           3-1: Logitech, Inc. : QuickCam Pro 4000 (046d:08b2)
              : /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0a.0/usb3/3-1
              : (Defined at Interface level) / unknown subclass / unknown protocol (00/00/00)
              :  0 - Data / unknown subclass / unknown protocol (0a/ff/00)
              :  1 - Audio / Control Device / unknown protocol (01/01/00)
              :  2 - Audio / Streaming / unknown protocol (01/02/00)
-    
+
           4-1: Logitech, Inc. : QuickCam Express (046d:0870)
              : /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0a.1/usb4/4-1
              : Vendor Specific Class / Vendor Specific Subclass / Vendor Specific Protocol (ff/ff/ff)
              :  0 - Vendor Specific Class / Vendor Specific Subclass / Vendor Specific Protocol (ff/ff/ff)
-    
+
           4-2: Texas Instruments Japan : unknown product (08bb:2702)
              : /sys/devices/pci0000:00/0000:00:1e.0/0000:02:0a.1/usb4/4-2
              : (Defined at Interface level) / unknown subclass / unknown protocol (00/00/00)
              :  0 - Audio / Control Device / unknown protocol (01/01/00)
              :  1 - Audio / Streaming / unknown protocol (01/02/00)
-    
+
 --------------------------------------------------------------------------------------------------------
 Attach a remote usb device!
 
    deux:# usbip --attach 10.0.0.3 1-1
    port 0 attached
-   
+
 --------------------------------------------------------------------------------------------------------
 Show what devices are attached to this client.
 
@@ -183,17 +183,17 @@ Show what devices are attached to this client.
    Port 00: <Port in Use> at Full Speed(12Mbps)
           Prolific Technology, Inc. : unknown product (067b:3507)
           6-1 -> usbip://10.0.0.3:3240/1-1  (remote bus/dev 001/004)
-          6-1:1.0 used by usb-storage      
+          6-1:1.0 used by usb-storage
                          /sys/class/scsi_device/0:0:0:0/device
                          /sys/class/scsi_host/host0/device
                          /sys/block/sda/device
-   
+
 --------------------------------------------------------------------------------------------------------
 Detach the imported device.
 
    deux:# usbip --detach 0
    port 0 detached
-   
+
 --------------------------------------------------------------------------------------------------------
 
 
drivers/staging/usbip/userspace/configure.ac +1 -1
index 24fd8ae..144655e 100644
@@ -93,7 +93,7 @@ AC_ARG_ENABLE(usbids-install,
  *)   AC_MSG_ERROR(bad value ${enableval} for --enable-usbids-install) ;;
  esac])
 AM_CONDITIONAL(INSTALL_USBIDS, test x$usbids = xinstall)
-    	
+
 
 
 GLIB2_REQUIRED=2.6.0
drivers/staging/usbip/userspace/doc/usbip_bind_driver.8 +3 -3
index 8a8972d..b91df9b 100644
@@ -7,8 +7,8 @@ usbip_bind_driver \- change driver binding for USB/IP
 [\fIoptions\fR]
 
 .SH DESCRIPTION
-Driver bindings for USB devices can be changed using 
-this program. It is used to export and unexport USB 
+Driver bindings for USB devices can be changed using
+this program. It is used to export and unexport USB
 devices over USB/IP.
 
 .SH OPTIONS
@@ -34,7 +34,7 @@ Print usb devices and their drivers in parseable mode
         - Bind usbip.ko to the device of busid 1-2.
         - A usb device 1-2 is now exportable to other hosts!
 
-    server:# usbip_bind_driver --other 1-2 
+    server:# usbip_bind_driver --other 1-2
         - Shutdown exporting and use the device locally.
 
 .SH "SEE ALSO"
drivers/staging/usbip/userspace/libsrc/stub_driver.c +1 -1
index bfe67480..d4d6936 100644
@@ -87,7 +87,7 @@ static int32_t read_attr_usbip_status(struct usb_device *udev)
 	}
 
 	if (retries == 0)
-		err("usbip_status not ready after %d retries", 
+		err("usbip_status not ready after %d retries",
 			SYSFS_OPEN_RETRIES);
 	else if (retries < SYSFS_OPEN_RETRIES)
 		info("warning: usbip_status ready after %d retries",
drivers/staging/usbip/userspace/src/bind-driver.c +5 -5
index 5226751..12918c1 100644
@@ -177,13 +177,13 @@ static int unbind(char *busid)
 		return -1;
 	}
 
- 	for (i = 0; i < ninterface; i++) {
- 		char driver[PATH_MAX];
+	for (i = 0; i < ninterface; i++) {
+		char driver[PATH_MAX];
 		int ret;
 
 		bzero(&driver, sizeof(driver));
 
- 		getdriver(busid, configvalue, i, driver, PATH_MAX-1);
+		getdriver(busid, configvalue, i, driver, PATH_MAX-1);
 
 		g_debug(" %s:%d.%d	-> %s ", busid, configvalue, i, driver);
 
@@ -226,7 +226,7 @@ static int bind_to_usbip(char *busid)
 		return -1;
 	}
 
- 	for (i = 0; i < ninterface; i++) {
+	for (i = 0; i < ninterface; i++) {
 		int ret;
 
 		ret = bind_interface(busid, configvalue, i, "usbip");
@@ -527,7 +527,7 @@ static int allusbip(void)
 				}
 #endif
 			}
-			
+
 			if (be_local == 0)
 				use_device_by_usbip(busid);
 		}
drivers/staging/usbip/userspace/src/usbip.c +3 -3
index 8775394..3943d15 100644
@@ -619,9 +619,9 @@ int main(int argc, char *argv[])
 	if (geteuid() != 0)
 		g_warning("running non-root?");
 
- 	ret = usbip_names_init(USBIDS_FILE);
- 	if (ret)
- 		notice("failed to open %s", USBIDS_FILE);
+	ret = usbip_names_init(USBIDS_FILE);
+	if (ret)
+		notice("failed to open %s", USBIDS_FILE);
 
 	for (;;) {
 		int c;
drivers/staging/usbip/userspace/src/usbip_network.h +2 -2
index 804f83d..1225466 100644
@@ -96,7 +96,7 @@ struct op_export_request {
 } __attribute__((packed));
 
 struct op_export_reply {
-	int returncode; 
+	int returncode;
 } __attribute__((packed));
 
 
@@ -118,7 +118,7 @@ struct op_unexport_request {
 } __attribute__((packed));
 
 struct op_unexport_reply {
-	int returncode; 
+	int returncode;
 } __attribute__((packed));
 
 #define PACK_OP_UNEXPORT_REQUEST(pack, request)  do {\
Signature · 1 line
1.7.5.1
#9 lore raw

PATCH 6/14 staging: usbip: userspace: update module name references

In reply to matt mooney

From: matt mooney <[email protected]>

Change all references to the kernel modules to correspond with the new names.

---
 drivers/staging/usbip/userspace/README             |   16 ++++++++--------
 .../usbip/userspace/doc/usbip_bind_driver.8        |    2 +-
 drivers/staging/usbip/userspace/doc/usbipd.8       |    2 +-
 .../staging/usbip/userspace/libsrc/stub_driver.c   |    4 ++--
 .../staging/usbip/userspace/libsrc/vhci_driver.c   |    2 +-
 5 files changed, 13 insertions(+), 13 deletions(-)
drivers/staging/usbip/userspace/README +8 -8
index b0df5cb..2ee84b9 100644
@@ -34,8 +34,8 @@
 [Usage]
     server:# (Attach your USB device physically.)
 
-    server:# insmod usbip_common_mod.ko
-    server:# insmod usbip.ko
+    server:# insmod usbip-core.ko
+    server:# insmod usbip-host.ko
         - It was formerly named as stub.ko.
 
     server:# usbipd -D
@@ -45,13 +45,13 @@
         - List driver assignments for usb devices.
 
     server:# usbip_bind_driver --usbip 1-2
-        - Bind usbip.ko to the device of busid 1-2.
+        - Bind usbip-host.ko to the device of busid 1-2.
         - A usb device 1-2 is now exportable to other hosts!
         - Use 'usbip_bind_driver --other 1-2' when you want to shutdown exporting
           and use the device locally.
 
 
-    client:# insmod usbip_common_mod.ko
+    client:# insmod usbip-core.ko
     client:# insmod vhci-hcd.ko
         - It was formerly named as vhci.ko.
 
@@ -72,8 +72,8 @@
 --------------------------------------------------------------------------------------------------------
 - SERVER SIDE (physically attach your USB devices to this host) ----------------------------------------
 --------------------------------------------------------------------------------------------------------
-trois:# insmod (somewhere)/usbip_common_mod.ko
-trois:# insmod (somewhere)/usbip.ko
+trois:# insmod (somewhere)/usbip-core.ko
+trois:# insmod (somewhere)/usbip-host.ko
 trois:# usbipd -D
 
 --------------------------------------------------------------------------------------------------------
@@ -132,7 +132,7 @@ Iterate the above operation for other devices if you like.
 First, let's list available remote devices which are marked as exportable in
 the server host.
 
-   deux:# insmod (somewhere)/usbip_common_mod.ko
+   deux:# insmod (somewhere)/usbip-core.ko
    deux:# insmod (somewhere)/vhci_hcd.ko
 
    deux:# usbip --list 10.0.0.3
@@ -200,7 +200,7 @@ Detach the imported device.
 [Check List]
     - See Debug Tips in the project wiki.
         - http://usbip.wiki.sourceforge.net/how-to-debug-usbip
-    - usbip.ko must be bound to the target device.
+    - usbip-host.ko must be bound to the target device.
         - See /proc/bus/usb/devices and find "Driver=..." lines of the device.
     - Shutdown firewall.
         - usbip now uses TCP port 3240.
drivers/staging/usbip/userspace/doc/usbip_bind_driver.8 +1 -1
index b91df9b..d43bbd6 100644
@@ -31,7 +31,7 @@ Print usb devices and their drivers in parseable mode
         - List driver assignments for usb devices.
 
     server:# usbip_bind_driver --usbip 1-2
-        - Bind usbip.ko to the device of busid 1-2.
+        - Bind usbip-host.ko to the device of busid 1-2.
         - A usb device 1-2 is now exportable to other hosts!
 
     server:# usbip_bind_driver --other 1-2
drivers/staging/usbip/userspace/doc/usbipd.8 +1 -1
index 3c39520..006559f 100644
@@ -52,7 +52,7 @@ USB/IP client can connect and use exported devices.
         - List driver assignments for usb devices.
 
     server:# usbip_bind_driver --usbip 1-2
-        - Bind usbip.ko to the device of busid 1-2.
+        - Bind usbip-host.ko to the device of busid 1-2.
         - A usb device 1-2 is now exportable to other hosts!
         - Use 'usbip_bind_driver --other 1-2' when you want to shutdown exporting and use the device locally.
 
drivers/staging/usbip/userspace/libsrc/stub_driver.c +2 -2
index d4d6936..a1ac067 100644
@@ -34,7 +34,7 @@ static struct sysfs_driver *open_sysfs_stub_driver(void)
 
 	stub_driver = sysfs_open_driver_path(stub_driver_path);
 	if (!stub_driver) {
-		err("usbip_common_mod.ko and usbip.ko must be loaded");
+		err("usbip-core.ko and usbip-host.ko must be loaded");
 		return NULL;
 	}
 
@@ -199,7 +199,7 @@ static int refresh_exported_devices(void)
 
 	suinf_list = sysfs_get_driver_devices(stub_driver->sysfs_driver);
 	if (!suinf_list) {
-		printf("Bind usbip.ko to a usb device to be exportable!\n");
+		printf("Bind usbip-host.ko to a usb device to be exportable!\n");
 		goto bye;
 	}
 
drivers/staging/usbip/userspace/libsrc/vhci_driver.c +1 -1
index 5e54810..db43f8d 100644
@@ -282,7 +282,7 @@ static int get_hc_busid(char *sysfs_mntpath, char *hc_busid)
         sdriver = sysfs_open_driver_path(sdriver_path);
         if (!sdriver) {
 		info("%s is not found", sdriver_path);
-                info("load usbip_common_mod.ko and vhci-hcd.ko !");
+                info("load usbip-core.ko and vhci-hcd.ko !");
                 return -1;
         }
 
Signature · 1 line
1.7.5.1
#10 lore raw

PATCH 7/14 staging: usbip: userspace: configure.ac: major overhaul

In reply to matt mooney

From: matt mooney <[email protected]>

All parameters have been quoted; and autoscan was rerun so new headers, types, and functions were added. The deprecated macros AM_CONFIG_HEADER and AM_PROG_LIBTOOL were changed to AC_CONFIG_HEADERS and LT_INIT, respectively. The AS_HELP_STRING macro is used to avoid arbitrary spacing for proper help menu alignment, and AS_CASE to avoid quoting issues. And finally, the macros were realigned to allow mere mortals the ability to read them.

---
 drivers/staging/usbip/userspace/configure.ac |  144 +++++++++++++-------------
 1 files changed, 74 insertions(+), 70 deletions(-)
drivers/staging/usbip/userspace/configure.ac +74 -70
index 144655e..0b71329 100644
@@ -1,105 +1,109 @@
-#                                               -*- Autoconf -*-
-# Process this file with autoconf to produce a configure script.
+dnl Process this file with autoconf to produce a configure script.
 
 AC_PREREQ(2.59)
-AC_REVISION($Id$)
-AC_INIT(usbip, 0.1.8, [email protected])
-AC_DEFINE(USBIP_VERSION, 0x000106, Numeric version number)
+AC_INIT([usbip], [0.1.8], [[email protected]])
+AC_DEFINE([USBIP_VERSION], [0x000106], [numeric version number])
+
+AC_CONFIG_SRCDIR([src/usbipd.c])
+AC_CONFIG_HEADERS([config.h])
 
-AC_CONFIG_SRCDIR([config.h.in])
 AM_INIT_AUTOMAKE([foreign])
+LT_INIT
 
 # Silent build for automake >= 1.11
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 
-AM_CONFIG_HEADER(config.h)
-
-
 AC_SUBST([EXTRA_CFLAGS])
 
-AC_PROG_LIBTOOL
-
 # Checks for programs.
 AC_PROG_CC
 AC_PROG_INSTALL
-
-# Checks for libraries.
+AC_PROG_MAKE_SET
 
 # Checks for header files.
 AC_HEADER_DIRENT
 AC_HEADER_STDC
-AC_CHECK_HEADERS([fcntl.h netdb.h stdint.h stdlib.h string.h strings.h sys/socket.h syslog.h unistd.h])
+AC_CHECK_HEADERS([arpa/inet.h fcntl.h netdb.h netinet/in.h stdint.h stdlib.h dnl
+		  string.h strings.h sys/socket.h syslog.h unistd.h])
 
 # Checks for typedefs, structures, and compiler characteristics.
-AC_C_CONST
+AC_TYPE_INT32_T
 AC_TYPE_SIZE_T
+AC_TYPE_SSIZE_T
+AC_TYPE_UINT16_T
+AC_TYPE_UINT32_T
+AC_TYPE_UINT8_T
 
 # Checks for library functions.
-AC_FUNC_MALLOC
 AC_FUNC_REALLOC
-AC_CHECK_FUNCS([bzero memset strchr strerror strstr strtoul])
-
-AC_CHECK_HEADER(sysfs/libsysfs.h,
-	[AC_CHECK_LIB(sysfs, sysfs_open_directory_list,
-		[LIBS="$LIBS -lsysfs"],
-		[AC_MSG_ERROR([Missing sysfs2 library!])])],
-	[AC_MSG_ERROR([Missing /usr/include/sysfs/libsysfs.h])])
+AC_CHECK_FUNCS([bzero memset mkdir regcomp socket strchr strerror strstr dnl
+		strtoul])
 
+AC_CHECK_HEADER([sysfs/libsysfs.h],
+		[AC_CHECK_LIB([sysfs], [sysfs_open_directory_list],
+			      [LIBS="$LIBS -lsysfs"],
+			      [AC_MSG_ERROR([Missing sysfs2 library!])])],
+		[AC_MSG_ERROR([Missing /usr/include/sysfs/libsysfs.h])])
 
-# get from stunnel
-dnl Check for libwrap library.
+# Checks for libwrap library.
 AC_MSG_CHECKING([whether to use the libwrap (TCP wrappers) library])
-
-AC_ARG_WITH(tcp-wrappers,
-[  --with-tcp-wrappers     Use the libwrap (TCP wrappers) library ],
-[saved_LIBS="$LIBS"
- if test "$withval" = "yes"; then
-      AC_MSG_RESULT([yes])
-      AC_MSG_CHECKING([for hosts_access in -lwrap])
-      LIBS="-lwrap $LIBS"
-      AC_TRY_LINK(
-	[int hosts_access(); int allow_severity, deny_severity;],
-	[hosts_access()],
-	[AC_MSG_RESULT([yes]); AC_DEFINE(HAVE_LIBWRAP, 1, use tcp wrapper) wrap_LIB="-lwrap"],
-	[AC_MSG_RESULT([not found]); exit 1])
- else
- 	     AC_MSG_RESULT([no])
- fi
- LIBS="$saved_LIBS"],
-[AC_MSG_RESULT([(default)])
- AC_MSG_CHECKING([for hosts_access in -lwrap])
- saved_LIBS="$LIBS"
- LIBS="-lwrap $saved_LIBS"
- AC_TRY_LINK(
-	[int hosts_access(); int allow_severity, deny_severity;],
- 	[hosts_access()],
- 	[AC_MSG_RESULT([yes]); AC_DEFINE(HAVE_LIBWRAP, 1, use tcp wrapper)],
- 	[AC_MSG_RESULT([no]); LIBS="$saved_LIBS"])
-])
-
-
-
+AC_ARG_WITH([tcp-wrappers],
+	    [AS_HELP_STRING([--with-tcp-wrappers],
+			    [use the libwrap (TCP wrappers) library])],
+	    dnl [ACTION-IF-GIVEN]
+	    [saved_LIBS="$LIBS"
+	     if test "$withval" = "yes"; then
+		     AC_MSG_RESULT([yes])
+		     AC_MSG_CHECKING([for hosts_access in -lwrap])
+		     LIBS="-lwrap $LIBS"
+		     AC_TRY_LINK(
+		       [int hosts_access(); int allow_severity, deny_severity;],
+		       [hosts_access()],
+		       [AC_MSG_RESULT([yes]);
+			AC_DEFINE([HAVE_LIBWRAP], [1],
+				  [use tcp wrapper]) wrap_LIB="-lwrap"],
+		       [AC_MSG_RESULT([not found]); exit 1])
+	     else
+		     AC_MSG_RESULT([no])
+	     fi
+	     LIBS="$saved_LIBS"],
+	    dnl [ACTION-IF-NOT-GIVEN]
+	    [AC_MSG_RESULT([(default)])
+	     AC_MSG_CHECKING([for hosts_access in -lwrap])
+	     saved_LIBS="$LIBS"
+	     LIBS="-lwrap $saved_LIBS"
+	     AC_TRY_LINK(
+	       [int hosts_access(); int allow_severity, deny_severity;],
+	       [hosts_access()],
+	       [AC_MSG_RESULT([yes]);
+		AC_DEFINE([HAVE_LIBWRAP], [1], [use tcp wrapper])],
+	       [AC_MSG_RESULT([no]); LIBS="$saved_LIBS"])])
+
+# Sets directory containing usb.ids.
 USBIDS_DIR='${datadir}/usbip'
-AC_ARG_WITH(usbids-dir, [  --with-usbids-dir=DIR   where usb.ids is found (default ${datadir}/usbip)], [USBIDS_DIR=$withval])
-AC_SUBST(USBIDS_DIR)
+AC_ARG_WITH([usbids-dir],
+	    [AS_HELP_STRING([--with-usbids-dir=DIR],
+	       [where usb.ids is found (default ${datadir}/usbip)])],
+	    [USBIDS_DIR=$withval])
+AC_SUBST([USBIDS_DIR])
 
 dnl FIXME: when disabled, empty directry is created
 usbids=install
-AC_ARG_ENABLE(usbids-install,
-[  --enable-usbids-install     install usb.ids (default)],
-[case "${enableval}" in
- yes) usbids=install ;;
- no)  usbids=notinstall ;;
- *)   AC_MSG_ERROR(bad value ${enableval} for --enable-usbids-install) ;;
- esac])
-AM_CONDITIONAL(INSTALL_USBIDS, test x$usbids = xinstall)
-
-
+AC_ARG_ENABLE([usbids-install],
+	      [AS_HELP_STRING([--enable-usbids-install],
+			      [install usb.ids (default)])],
+	      [AS_CASE([$enableval],
+		       [yes], [usbids=install],
+		       [no], [usbids=notinstall],
+		       [AC_MSG_ERROR(
+			  [bad value ${enableval} for --enable-usbids-install])]
+		      )])
+AM_CONDITIONAL([INSTALL_USBIDS], [test x$usbids = xinstall])
 
 GLIB2_REQUIRED=2.6.0
-PKG_CHECK_MODULES(PACKAGE, glib-2.0 >= $GLIB2_REQUIRED)
-AC_SUBST(PACKAGE_CFLAGS)
-AC_SUBST(PACKAGE_LIBS)
+PKG_CHECK_MODULES([PACKAGE], [glib-2.0 >= $GLIB2_REQUIRED])
+AC_SUBST([PACKAGE_CFLAGS])
+AC_SUBST([PACKAGE_LIBS])
 
 AC_CONFIG_FILES([Makefile libsrc/Makefile src/Makefile])
 AC_OUTPUT
Signature · 1 line
1.7.5.1
#11 lore raw

PATCH 8/14 staging: usbip: userspace: cleanup makefiles

In reply to matt mooney

From: matt mooney <[email protected]>

Remove unneeded comments; change deprecated flag INCLUDE to AM_CPPFLAGS and put -D option in *_CPPFLAGS; and use "simply expanded variables" in assignments.

---
 drivers/staging/usbip/userspace/Makefile.am        |    8 +++---
 drivers/staging/usbip/userspace/libsrc/Makefile.am |   15 ++++-------
 drivers/staging/usbip/userspace/src/Makefile.am    |   25 ++++++-------------
 3 files changed, 18 insertions(+), 30 deletions(-)
drivers/staging/usbip/userspace/Makefile.am +4 -4
index 3be3060..83f51b8 100644
@@ -1,11 +1,11 @@
-SUBDIRS = libsrc src
-includedir=@includedir@/usbip
+SUBDIRS := libsrc src
+includedir := @includedir@/usbip
 include_HEADERS := $(addprefix libsrc/, \
 		     usbip.h usbip_common.h vhci_driver.h stub_driver.h)
 
 dist_man_MANS := $(addprefix doc/, usbip.8 usbipd.8 usbip_bind_driver.8)
 
 if INSTALL_USBIDS
-pkgdata_DATA = usb.ids
-EXTRA_DIST = $(pkgdata_DATA)
+pkgdata_DATA := usb.ids
+EXTRA_DIST := $(pkgdata_DATA)
 endif
drivers/staging/usbip/userspace/libsrc/Makefile.am +6 -9
index 10b919d..ed83666 100644
@@ -1,10 +1,7 @@
-# AM_CFLAGS = -Wall -std=gnu99
-lib_LTLIBRARIES = libusbip.la
-libusbip_la_SOURCES = names.c names.h stub_driver.c stub_driver.h usbip.h usbip_common.c usbip_common.h vhci_driver.c vhci_driver.h
-#libusbip_la_SOURCES = names.c names.h stub_driver.c usbip_common.c vhci_driver.c
-#INCLUDES = -I../include
-#AM_CPPFLAGS = -I../include -Wall -std=gnu99
-libusbip_la_LDFLAGS = -version-info 0:1:0
-EXTRA_CFLAGS = @EXTRA_CFLAGS@
-libusbip_la_CFLAGS = -Wall -W -Wstrict-prototypes -std=gnu99 $(EXTRA_CFLAGS) -DUSBIDS_FILE='"@USBIDS_DIR@/usb.ids"'
+libusbip_la_CPPFLAGS := -DUSBIDS_FILE='"@USBIDS_DIR@/usb.ids"'
+libusbip_la_CFLAGS   := @EXTRA_CFLAGS@ -Wall -W -Wstrict-prototypes -std=gnu99
+libusbip_la_LDFLAGS  := -version-info 0:1:0
 
+lib_LTLIBRARIES := libusbip.la
+libusbip_la_SOURCES := names.c names.h stub_driver.c stub_driver.h usbip.h \
+		       usbip_common.c usbip_common.h vhci_driver.c vhci_driver.h
drivers/staging/usbip/userspace/src/Makefile.am +8 -17
index 3717fc5..a2f0ab2 100644
@@ -1,19 +1,10 @@
-# $Id$
+AM_CPPFLAGS := -I$(top_srcdir)/libsrc -DUSBIDS_FILE='"@USBIDS_DIR@/usb.ids"'
+AM_CFLAGS   := @EXTRA_CFLAGS@ -Wall -W -Wstrict-prototypes -std=gnu99 @PACKAGE_CFLAGS@
+LDADD       := $(top_srcdir)/libsrc/libusbip.la @PACKAGE_LIBS@
 
-sbin_PROGRAMS = usbip usbipd usbip_bind_driver
-
-usbip_SOURCES = usbip.c usbip_network.c usbip_network.h
-usbipd_SOURCES = usbipd.c usbip_network.c usbip_network.h
-usbip_bind_driver_SOURCES = bind-driver.c \
-		utils.c utils.h \
-		usbip_network.h usbip_network.c
-
-#usbip_bind_driver_CFLAGS = -Wall -W -Wstrict-prototypes @PACKAGE_CFLAGS@
-#usbip_bind_driver_LDADD = @PACKAGE_LIBS@
-
-#AM_CPPFLAGS = -I../include -Wall -std=gnu99
-INCLUDES = -I$(top_srcdir)/libsrc
-LDADD = ../libsrc/libusbip.la @PACKAGE_LIBS@
-EXTRA_CFLAGS = @EXTRA_CFLAGS@
-AM_CFLAGS = -Wall -W -Wstrict-prototypes -std=gnu99 $(EXTRA_CFLAGS) @PACKAGE_CFLAGS@ -DUSBIDS_FILE='"@USBIDS_DIR@/usb.ids"'
+sbin_PROGRAMS := usbip usbipd usbip_bind_driver
 
+usbip_SOURCES := usbip.c usbip_network.c usbip_network.h
+usbipd_SOURCES := usbipd.c usbip_network.c usbip_network.h
+usbip_bind_driver_SOURCES := bind-driver.c utils.c utils.h \
+			     usbip_network.h usbip_network.c
Signature · 1 line
1.7.5.1
#12 lore raw

PATCH 9/14 staging: usbip: userspace: set libusbip version in configure.ac

In reply to matt mooney

From: matt mooney <[email protected]>

Move libusbip version setting to configure.ac so that version numbers can be found in a single location.

---
 drivers/staging/usbip/userspace/configure.ac       |    5 +++++
 drivers/staging/usbip/userspace/libsrc/Makefile.am |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)
drivers/staging/usbip/userspace/configure.ac +5 -0
index 0b71329..7b93d29 100644
@@ -4,6 +4,11 @@ AC_PREREQ(2.59)
 AC_INIT([usbip], [0.1.8], [[email protected]])
 AC_DEFINE([USBIP_VERSION], [0x000106], [numeric version number])
 
+CURRENT=0
+REVISION=1
+AGE=0
+AC_SUBST([LIBUSBIP_VERSION], [$CURRENT:$REVISION:$AGE], [library version])
+
 AC_CONFIG_SRCDIR([src/usbipd.c])
 AC_CONFIG_HEADERS([config.h])
 
drivers/staging/usbip/userspace/libsrc/Makefile.am +1 -1
index ed83666..6abe7fc 100644
@@ -1,6 +1,6 @@
 libusbip_la_CPPFLAGS := -DUSBIDS_FILE='"@USBIDS_DIR@/usb.ids"'
 libusbip_la_CFLAGS   := @EXTRA_CFLAGS@ -Wall -W -Wstrict-prototypes -std=gnu99
-libusbip_la_LDFLAGS  := -version-info 0:1:0
+libusbip_la_LDFLAGS  := -version-info @LIBUSBIP_VERSION@
 
 lib_LTLIBRARIES := libusbip.la
 libusbip_la_SOURCES := names.c names.h stub_driver.c stub_driver.h usbip.h \
Signature · 1 line
1.7.5.1
#13 lore raw

PATCH 10/14 staging: usbip: userspace: remove revision $Id$

In reply to matt mooney

From: matt mooney <[email protected]>

This is git not CVS!

---
 drivers/staging/usbip/userspace/src/bind-driver.c  |    1 -
 drivers/staging/usbip/userspace/src/usbip.c        |    4 +---
 .../staging/usbip/userspace/src/usbip_network.c    |    1 -
 drivers/staging/usbip/userspace/src/usbipd.c       |    4 +---
 drivers/staging/usbip/userspace/src/utils.c        |    1 -
 5 files changed, 2 insertions(+), 9 deletions(-)
drivers/staging/usbip/userspace/src/bind-driver.c +0 -1
index 12918c1..955c86b 100644
@@ -1,5 +1,4 @@
 /*
- * $Id$
  *
  * Copyright (C) 2005-2007 Takahiro Hirofuchi
  */
drivers/staging/usbip/userspace/src/usbip.c +1 -3
index 3943d15..01a5628 100644
@@ -1,5 +1,4 @@
 /*
- * $Id$
  *
  * Copyright (C) 2005-2007 Takahiro Hirofuchi
  */
@@ -17,8 +16,7 @@
 #include <fcntl.h>
 #include <glib.h>
 
-static const char version[] = PACKAGE_STRING
-	" ($Id$)";
+static const char version[] = PACKAGE_STRING;
 
 
 /* /sys/devices/platform/vhci_hcd/usb6/6-1/6-1:1.1  -> 1 */
drivers/staging/usbip/userspace/src/usbip_network.c +0 -1
index a3a955b..726173e 100644
@@ -1,5 +1,4 @@
 /*
- * $Id$
  *
  * Copyright (C) 2005-2007 Takahiro Hirofuchi
  */
drivers/staging/usbip/userspace/src/usbipd.c +1 -3
index 441dcde..409d064 100644
@@ -1,5 +1,4 @@
 /*
- * $Id$
  *
  * Copyright (C) 2005-2007 Takahiro Hirofuchi
  */
@@ -31,8 +30,7 @@
 
 #include <glib.h>
 
-static const char version[] = PACKAGE_STRING
-	" ($Id$)";
+static const char version[] = PACKAGE_STRING;
 
 
 static int send_reply_devlist(int sockfd)
drivers/staging/usbip/userspace/src/utils.c +0 -1
index 403c30f..8f44108 100644
@@ -1,5 +1,4 @@
 /*
- * $Id$
  *
  * Copyright (C) 2005-2007 Takahiro Hirofuchi
  */
Signature · 1 line
1.7.5.1
#14 lore raw

PATCH 11/14 staging: usbip: userspace: remove gcc warnings

In reply to matt mooney

From: matt mooney <[email protected]>

The warnings were for unused parameters, so __attribute__((unused)) has been added until it can be determined they are truly unneeded.

---
 .../staging/usbip/userspace/libsrc/stub_driver.c   |    2 +-
 .../staging/usbip/userspace/src/usbip_network.c    |    3 ++-
 drivers/staging/usbip/userspace/src/usbipd.c       |    3 ++-
 3 files changed, 5 insertions(+), 3 deletions(-)
drivers/staging/usbip/userspace/libsrc/stub_driver.c +1 -1
index a1ac067..4c76e03 100644
@@ -181,7 +181,7 @@ static int check_new(struct dlist *dlist, struct sysfs_device *target)
 	return 1;
 }
 
-static void delete_nothing(void *dev)
+static void delete_nothing(void *dev __attribute__((unused)))
 {
 	/* do not delete anything. but, its container will be deleted. */
 }
drivers/staging/usbip/userspace/src/usbip_network.c +2 -1
index 726173e..01be3c7 100644
@@ -40,7 +40,8 @@ void pack_usb_device(int pack, struct usb_device *udev)
 	pack_uint16_t(pack, &udev->bcdDevice);
 }
 
-void pack_usb_interface(int pack, struct usb_interface *udev)
+void pack_usb_interface(int pack __attribute__((unused)),
+			struct usb_interface *udev __attribute__((unused)))
 {
 	/* uint8_t members need nothing */
 }
drivers/staging/usbip/userspace/src/usbipd.c +2 -1
index 409d064..ec9faac 100644
@@ -388,7 +388,8 @@ static void set_signal(void)
 }
 
 
-gboolean process_comming_request(GIOChannel *gio, GIOCondition condition, gpointer data)
+gboolean process_comming_request(GIOChannel *gio, GIOCondition condition,
+				 gpointer data __attribute__((unused)))
 {
 	int ret;
 
Signature · 1 line
1.7.5.1
#15 lore raw

PATCH 12/14 staging: usbip: userspace: move common cflags to configure.ac

In reply to matt mooney

From: matt mooney <[email protected]>

There are a standard set of cflags that are used in each makefile so let's set those in EXTRA_CFLAGS and enforce them for the entire project.

---
 drivers/staging/usbip/userspace/configure.ac       |    2 +-
 drivers/staging/usbip/userspace/libsrc/Makefile.am |    2 +-
 drivers/staging/usbip/userspace/src/Makefile.am    |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/usbip/userspace/configure.ac +1 -1
index 7b93d29..d5f6d8e 100644
@@ -18,7 +18,7 @@ LT_INIT
 # Silent build for automake >= 1.11
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 
-AC_SUBST([EXTRA_CFLAGS])
+AC_SUBST([EXTRA_CFLAGS], ["-Wall -W -Wstrict-prototypes -std=gnu99"])
 
 # Checks for programs.
 AC_PROG_CC
drivers/staging/usbip/userspace/libsrc/Makefile.am +1 -1
index 6abe7fc..77ecf6b 100644
@@ -1,5 +1,5 @@
 libusbip_la_CPPFLAGS := -DUSBIDS_FILE='"@USBIDS_DIR@/usb.ids"'
-libusbip_la_CFLAGS   := @EXTRA_CFLAGS@ -Wall -W -Wstrict-prototypes -std=gnu99
+libusbip_la_CFLAGS   := @EXTRA_CFLAGS@
 libusbip_la_LDFLAGS  := -version-info @LIBUSBIP_VERSION@
 
 lib_LTLIBRARIES := libusbip.la
drivers/staging/usbip/userspace/src/Makefile.am +1 -1
index a2f0ab2..05a7aa5 100644
@@ -1,5 +1,5 @@
 AM_CPPFLAGS := -I$(top_srcdir)/libsrc -DUSBIDS_FILE='"@USBIDS_DIR@/usb.ids"'
-AM_CFLAGS   := @EXTRA_CFLAGS@ -Wall -W -Wstrict-prototypes -std=gnu99 @PACKAGE_CFLAGS@
+AM_CFLAGS   := @EXTRA_CFLAGS@ @PACKAGE_CFLAGS@
 LDADD       := $(top_srcdir)/libsrc/libusbip.la @PACKAGE_LIBS@
 
 sbin_PROGRAMS := usbip usbipd usbip_bind_driver
Signature · 1 line
1.7.5.1
#16 lore raw

PATCH 13/14 staging: usbip: userspace: modify project gcc flags

In reply to matt mooney

From: matt mooney <[email protected]>

Add -Werror, remove -Wstrict-prototypes, and change -W to -Wextra.

---
 drivers/staging/usbip/userspace/configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/usbip/userspace/configure.ac +1 -1
index d5f6d8e..e3afa15 100644
@@ -18,7 +18,7 @@ LT_INIT
 # Silent build for automake >= 1.11
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 
-AC_SUBST([EXTRA_CFLAGS], ["-Wall -W -Wstrict-prototypes -std=gnu99"])
+AC_SUBST([EXTRA_CFLAGS], ["-Wall -Werror -Wextra -std=gnu99"])
 
 # Checks for programs.
 AC_PROG_CC
Signature · 1 line
1.7.5.1
#17 lore raw

PATCH 14/14 package: Makefile: add USB/IP userspace utilities

In reply to matt mooney

From: matt mooney <[email protected]>

Add usbip-src-pkg target to generate a tarball of the userspace source.

---
 scripts/package/Makefile |   15 ++++++++++++++-
 1 files changed, 14 insertions(+), 1 deletions(-)
scripts/package/Makefile +14 -1
index a834b93..c736a12 100644
@@ -134,6 +134,19 @@ $(error unknown target $@))))                                       \
 perf-%pkg: FORCE
 	$(call cmd,perf_tar)
 
+# usbip-src-pkg - generate a source tarball of USB/IP userspace utilities
+# ---------------------------------------------------------------------------
+usbip-pkg := usbip-$(KERNELVERSION)
+usbip-userspace := $(srctree)/drivers/staging/usbip/userspace
+
+quiet_cmd_usbip_pkg = TAR  $(usbip-pkg)
+      cmd_usbip_pkg = \
+		tar czfP $(usbip-pkg).tar.gz $(usbip-userspace)	\
+			--transform="s:$(usbip-userspace):$(usbip-pkg):"
+
+usbip-src-pkg: FORCE
+	$(call cmd,usbip_pkg)
+
 # Help text displayed when executing 'make help'
 # ---------------------------------------------------------------------------
 help: FORCE
@@ -148,4 +161,4 @@ help: FORCE
 	@echo '  perf-targz-src-pkg  - Build $(perf-tar).tar.gz source tarball'
 	@echo '  perf-tarbz2-src-pkg - Build $(perf-tar).tar.bz2 source tarball'
 	@echo '  perf-tarxz-src-pkg  - Build $(perf-tar).tar.xz source tarball'
-
+	@echo '  usbip-src-pkg       - Build source tarball of USB/IP userspace utilities'
Signature · 1 line
1.7.5.1
#18 lore raw

Re: [PATCH 14/14] package: Makefile: add USB/IP userspace utilities

Quoted 7 lines · matt mooney

From: matt mooney <[email protected]>

Add usbip-src-pkg target to generate a tarball of the userspace source.

---
 scripts/package/Makefile |   15 ++++++++++++++-

Is this really needed at this point in time? I'd prefer to wait on it before we get this code cleaned up a bit better if you don't mind.

thanks,

greg k-h

#19 lore raw

Re: [PATCH 14/14] package: Makefile: add USB/IP userspace utilities

Quoted 11 lines · Greg KH
Quoted 7 lines · matt mooney

From: matt mooney <[email protected]>

Add usbip-src-pkg target to generate a tarball of the userspace source.

---
 scripts/package/Makefile |   15 ++++++++++++++-

Is this really needed at this point in time?  I'd prefer to wait on it before we get this code cleaned up a bit better if you don't mind.

Oh yeah, of course. I only added it because I thought you wanted me to add it now.

Signature · 1 line
GPG-Key: 9AFE00EA
#20 lore raw

Re: [PATCH 14/14] package: Makefile: add USB/IP userspace utilities

Quoted 10 lines · matt mooney
Quoted 9 lines · Greg KH
Quoted 7 lines · matt mooney

From: matt mooney <[email protected]>

Add usbip-src-pkg target to generate a tarball of the userspace source.

---
 scripts/package/Makefile |   15 ++++++++++++++-

Quoted 5 lines
Quoted 2 lines

Is this really needed at this point in time?  I'd prefer to wait on it before we get this code cleaned up a bit better if you don't mind.

Oh yeah, of course. I only added it because I thought you wanted me to add it now.

For some reason I thought it would be more, but there really isn't a way to build the userspace code from the main root of the kernel tree is there?

thanks,

greg k-h

#21 lore raw

Re: [PATCH 14/14] package: Makefile: add USB/IP userspace utilities

Quoted 14 lines · Greg KH
Quoted 13 lines · matt mooney
Quoted 11 lines · Greg KH
Quoted 7 lines · matt mooney

From: matt mooney <[email protected]>

Add usbip-src-pkg target to generate a tarball of the userspace source.

---
 scripts/package/Makefile |   15 ++++++++++++++-

Is this really needed at this point in time?  I'd prefer to wait on it before we get this code cleaned up a bit better if you don't mind.

Quoted 6 lines
Quoted 2 lines

Oh yeah, of course. I only added it because I thought you wanted me to add it now.

For some reason I thought it would be more, but there really isn't a way to build the userspace code from the main root of the kernel tree is there?

I do not believe there is. Since `make ...' starts the Kbuild system, Kbuild would have to support this otherwise we would have to circumvent the build system. And the closest thing to some kind of support I could find was in scripts/Makefile.host, but it says it is for binaries used during the kernel compilation process. I think this set of userspace utilities is further complicated by its use of autotools.

My use of "circumvent the build system" may be a bit harsh. I don't think there is anything wrong with running a parameterized instance of make within a target, but the short answer would be that this problem does not seem to have been generalized in Kbuild yet.

-matt

Signature · 1 line
GPG-Key: 9AFE00EA
#22 lore raw

Re: [PATCH 14/14] package: Makefile: add USB/IP userspace utilities

Quoted 30 lines · matt mooney
Quoted 14 lines · Greg KH
Quoted 13 lines · matt mooney
Quoted 11 lines · Greg KH
Quoted 7 lines · matt mooney

From: matt mooney <[email protected]>

Add usbip-src-pkg target to generate a tarball of the userspace source.

---
 scripts/package/Makefile |   15 ++++++++++++++-

Is this really needed at this point in time?  I'd prefer to wait on it before we get this code cleaned up a bit better if you don't mind.

Quoted 6 lines
Quoted 2 lines

Oh yeah, of course. I only added it because I thought you wanted me to add it now.

For some reason I thought it would be more, but there really isn't a way to build the userspace code from the main root of the kernel tree is there?

I do not believe there is. Since `make ...' starts the Kbuild system, Kbuild would have to support this otherwise we would have to circumvent the build system. And the closest thing to some kind of support I could find was in scripts/Makefile.host, but it says it is for binaries used during the kernel compilation process. I think this set of userspace utilities is further complicated by its use of autotools.

Quoted 4 lines

My use of "circumvent the build system" may be a bit harsh. I don't think there is anything wrong with running a parameterized instance of make within a target, but the short answer would be that this problem does not seem to have been generalized in Kbuild yet.

Ok, that's fine, I originally thought that tools like perf were somehow hooked up to the main Makefile, when it seems they really aren't. So your other patches are fine, and are now applied.

We can wait on the tarball extract when the code moves into the "real" part of the kernel.

thanks,

greg k-h