Skip to contentSkip to conversation

vhost: fix enable notify: write out last avail value we saw

RFC PATCH New Michael S. Tsirkin 1 participant 1 message May 18, 2011

Subsystems (4)
lore
Share & tools
lore

Michael S. Tsirkin

author maintainer
#0 lore raw

RFC PATCH 1/1 vhost: fix enable notify: write out last avail value we saw

With RX ring and mergeable buffers, vhost-net sometimes enables notifications when ring is not empty - just doesn't have enough entries for the incoming packet.

To get event when entries are added in this case,
we should always write out the last index value
we saw into event index field, which is ahead
of the index we have consumed.

Otherwise we get a kick, see that there are not enough entries in the ring, reenable notifications but since last used index was not updated
we don't get any more events.

---

This bugfix is on top of my patchset, I'm working on addressing Rusty's comments for that now.

Will push to my git tree event idx branch for everyone's testing pleasure shortly.

 drivers/vhost/vhost.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/vhost/vhost.c +1 -1
index 2aea4cb..1267a3d 100644
@@ -1438,7 +1438,7 @@ bool vhost_enable_notify(struct vhost_dev *dev, struct vhost_virtqueue *vq)
 			return false;
 		}
 	} else {
-		r = put_user(vq->last_avail_idx, vhost_avail_event(vq));
+		r = put_user(vq->avail_idx, vhost_avail_event(vq));
 		if (r) {
 			vq_err(vq, "Failed to update avail event index at %p: %d\n",
 			       vhost_avail_event(vq), r);
Signature · 1 line
1.7.5.53.gc233e