Skip to contentSkip to conversation

ARM: Enable GIC support when TWD is selected

PATCH New Magnus Damm 1 participant 1 message May 19, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: Enable GIC support when TWD is selected

From: Magnus Damm <[email protected]>

The TWD code in smp_twd.c has been calling gic_enable_ppi() since ac61d143ffe2a6db4d4bcf47c21a5159d6a1b644.

Without this fix kernel configs with CONFIG_HAVE_ARM_TWD=y and CONFIG_ARM_GIC=n results in the following build error:

arch/arm/kernel/built-in.o: In function `twd_timer_setup':
io.c:(.cpuinit.text+0x580): undefined reference to `gic_enable_ppi'
make: *** [.tmp_vmlinux1] Error 1

---

Or perhaps mach-shmobile should always select ARM_GIC even though some SoC parts do not include GIC hardware?

 arch/arm/Kconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/Kconfig +1 -0
@@ -1368,6 +1368,7 @@ config HAVE_ARM_TWD
 	bool
 	depends on SMP
 	select TICK_ONESHOT
+	select ARM_GIC
 	help
 	  This options enables support for the ARM timer and watchdog unit