Skip to contentSkip to conversation

gconfig: enable rules hint for main treeviews

PATCH Applied Eduardo Silva 3 participants 3 messages May 19, 2011 – May 24, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 gconfig: enable rules hint for main treeviews

Due to the large amount of rows in the treeviews, is difficult to match columns with rows, setting the rules hint to 'true' allows the treeview to alternate background colors in the rows making the data more readable.

---
 scripts/kconfig/gconf.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
scripts/kconfig/gconf.c +2 -2
index 4558961..0c8db7d 100644
@@ -253,7 +253,7 @@ void init_left_tree(void)
 
 	gtk_tree_view_set_model(view, model1);
 	gtk_tree_view_set_headers_visible(view, TRUE);
-	gtk_tree_view_set_rules_hint(view, FALSE);
+	gtk_tree_view_set_rules_hint(view, TRUE);
 
 	column = gtk_tree_view_column_new();
 	gtk_tree_view_append_column(view, column);
@@ -298,7 +298,7 @@ void init_right_tree(void)
 
 	gtk_tree_view_set_model(view, model2);
 	gtk_tree_view_set_headers_visible(view, TRUE);
-	gtk_tree_view_set_rules_hint(view, FALSE);
+	gtk_tree_view_set_rules_hint(view, TRUE);
 
 	column = gtk_tree_view_column_new();
 	gtk_tree_view_append_column(view, column);
Signature · 1 line
1.7.4.1
Tested-by on v1 1/2
#1 lore raw
Quoted 6 lines · On Thu, 19 May 2011 08:37:01 -0400 Eduardo Silva wrote:

Due to the large amount of rows in the treeviews, is difficult to match columns with rows, setting the rules hint to 'true' allows the treeview to alternate background colors in the rows making the data more readable.

Nice. Thanks.

Quoted 19 lines
---
 scripts/kconfig/gconf.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
scripts/kconfig/gconf.c +1 -1
index 4558961..0c8db7d 100644
@@ -253,7 +253,7 @@ void init_left_tree(void)
 
 	gtk_tree_view_set_model(view, model1);
 	gtk_tree_view_set_headers_visible(view, TRUE);
-	gtk_tree_view_set_rules_hint(view, FALSE);
+	gtk_tree_view_set_rules_hint(view, TRUE);
 
 	column = gtk_tree_view_column_new();
 	gtk_tree_view_append_column(view, column);

scripts/kconfig/gconf.c void init_right_tree(void) · line 304

Quoted 8 lines
scripts/kconfig/gconf.c +1 -1
@@ -298,7 +298,7 @@ void init_right_tree(void)
 
 	gtk_tree_view_set_model(view, model2);
 	gtk_tree_view_set_headers_visible(view, TRUE);
-	gtk_tree_view_set_rules_hint(view, FALSE);
+	gtk_tree_view_set_rules_hint(view, TRUE);
 
 	column = gtk_tree_view_column_new();
 	gtk_tree_view_append_column(view, column);

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Applied
#2 lore raw
Quoted 7 lines · Randy Dunlap
Quoted 5 lines · On Thu, 19 May 2011 08:37:01 -0400 Eduardo Silva wrote:

Due to the large amount of rows in the treeviews, is difficult to match columns with rows, setting the rules hint to 'true' allows the treeview to alternate background colors in the rows making the data more readable.

Quoted 5 lines
Quoted 1 line

Nice. Thanks.

Applied, thanks.

Michal