netdev: stop Features changed message
Subsystems (2)
PATCH 1/1 netdev: stop Features changed message
The new in 2.6.39 message "Features changed:" occurs a lot on many configurations. It provides information to driver developers but is not user friendly. Printing out hex values is just confusing. Reduce priority so that it doesn't show up unless debugging.
net/core/dev.c +1 -1
@@ -5258,7 +5258,7 @@ void netdev_update_features(struct net_dif (dev->features == features)return ; -netdev_info (dev,"Features changed: 0x%08x -> 0x%08x\n" , +netdev_dbg (dev,"Features changed: 0x%08x -> 0x%08x\n" , dev->features, features);if (dev->netdev_ops->ndo_set_features)
2011/5/20 Stephen Hemminger <[email protected]>:
Quoted 4 lines
The new in 2.6.39 message "Features changed:" occurs a lot on many configurations. It provides information to driver developers but is not user friendly. Printing out hex values is just confusing. Reduce priority so that it doesn't show up unless debugging.
The same patch is already in net-next:604ae14ffb6d75d6eef4757859226b758d6bf9e3. Wasn't it meat for net/stable back then?
Best Regards,
Michał Mirosław
David Miller
maintainerFrom: Stephen Hemminger <[email protected]>
Date: Fri, 20 May 2011 09:02:08 -0700
Quoted 6 lines
The new in 2.6.39 message "Features changed:" occurs a lot on many configurations. It provides information to driver developers but is not user friendly. Printing out hex values is just confusing. Reduce priority so that it doesn't show up unless debugging.
Signed-off-by Stephen Hemminger <[email protected]>
THis was already in net-2.6 and is queued up for 2.6.39-stable
Quoted 11 lines · On Fri, 20 May 2011 14:26:50 -0400 (EDT) David Miller <[email protected]>…
From: Stephen Hemminger <[email protected]>
Date: Fri, 20 May 2011 09:02:08 -0700Quoted 6 lines
The new in 2.6.39 message "Features changed:" occurs a lot on many configurations. It provides information to driver developers but is not user friendly. Printing out hex values is just confusing. Reduce priority so that it doesn't show up unless debugging.
Signed-off-by Stephen Hemminger <[email protected]>THis was already in net-2.6 and is queued up for 2.6.39-stable
ok.