AT91: CFI support broken
Hello,
since "AT91: fix timer.c - remove reset_timer()"
<http://git.denx.de/?p=u-boot/u-boot-atmel.git;a=commit;h=cfff263f41e32c7ba2ee9162a8cc6423eb5a8390>
was commited the arm926ejs/at91 boards can't compile with cfi_flash support:
u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'
I think this patch should be revert, as long as other modules need the reset_timer function.
Can anybody confirm this
Thanks
Jens Scharsig
Dear esw at bus-elektronik.de,
Quoted 6 lines
Hello,
since "AT91: fix
timer.c- removereset_timer()"<http://git.denx.de/?p=u-boot/u-boot-atmel.git;a=commit;h=cfff263f41e32c7ba2ee9162a8cc6423eb5a8390>
Quoted 8 lines
was commited the arm926ejs/at91 boards can't compile with
cfi_flashsupport:
u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'I think this patch should be revert, as long as other modules need the
reset_timerfunction.Can anybody confirm this
I think we should fix the place where reset_timer() is still used, to use get_timer() only. All other drivers that are used in atmel context do not use reset_timer(), but rely on the fact that get_timer() is monotonic. reset_timer() resets the value back to zero.
Best Regards,
Reinhard
Hello Stefan Roese,
Quoted 13 lines
Quoted 13 lines
Hello,
since "AT91: fix
timer.c- removereset_timer()"<http://git.denx.de/?p=u-boot/u-boot-atmel.git;a=commit;h=cfff263f41e32c7ba2ee9162a8cc6423eb5a8390>
was commited the arm926ejs/at91 boards can't compile with
cfi_flashsupport:
u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'I think this patch should be revert, as long as other modules need the
reset_timerfunction.
Quoted 8 lines
Quoted 1 line
Can anybody confirm this
I think we should fix the place where
reset_timer()is still used, to useget_timer()only. All other drivers that are used in atmel context do not usereset_timer(), but rely on the fact thatget_timer()is monotonic.reset_timer()resets the value back to zero.Best Regards,
Reinhard
what do you think about?
Best regards
Jens
Hi Jens,
Quoted 12 lines · On Friday 20 May 2011 15:01:21 Jens Scharsig wrote:
Quoted 12 lines
Quoted 6 lines
u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'I think this patch should be revert, as long as other modules need the
reset_timerfunction.Can anybody confirm this
I think we should fix the place where
reset_timer()is still used, to useget_timer()only. All other drivers that are used in atmel context do not usereset_timer(), but rely on the fact thatget_timer()is monotonic.reset_timer()resets the value back to zero.
Quoted 4 lines
Quoted 2 lines
Best Regards,
Reinhardwhat do you think about?
I would welcome it, if somebody would provide a patch to remove the reset_timer() call from the common CFI driver.
Best regards,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
Quoted 15 lines · Stefan Roese
Hi Jens,
Quoted 12 lines · On Friday 20 May 2011 15:01:21 Jens Scharsig wrote:
Quoted 12 lines
Quoted 6 lines
u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'I think this patch should be revert, as long as other modules need the
reset_timerfunction.Can anybody confirm this
I think we should fix the place where
reset_timer()is still used, to useget_timer()only. All other drivers that are used in atmel context do not usereset_timer(), but rely on the fact thatget_timer()is monotonic.reset_timer()resets the value back to zero.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Best Regards,
Reinhardwhat do you think about?
I would welcome it, if somebody would provide a patch to remove the
reset_timer()call from the common CFI driver.
Working on it now
Regards,
Graeme