Skip to contentSkip to conversation

ALSA: ASoC: Fix comment in cs4270 codec driver

PATCH Applied Daniel Mack 4 participants 5 messages May 25, 2011 – May 26, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: ASoC: Fix comment in cs4270 codec driver

The comment does not reflect reality anymore since the multi-component monster patch landed. Things are matched by names now, and not by exporting and referencing a struct. Fix it to avoid confusion.

Cc Mark Brown <[email protected]>
Cc Liam Girdwood <[email protected]>
---
 sound/soc/codecs/cs4270.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
sound/soc/codecs/cs4270.c +1 -4
index 0206a17..6cc8678 100644
@@ -636,10 +636,7 @@ static int cs4270_soc_resume(struct snd_soc_codec *codec)
 #endif /* CONFIG_PM */
 
 /*
- * ASoC codec device structure
- *
- * Assign this variable to the codec_dev field of the machine driver's
- * snd_soc_device structure.
+ * ASoC codec driver structure
  */
 static const struct snd_soc_codec_driver soc_codec_device_cs4270 = {
 	.probe =		cs4270_probe,
Signature · 1 line
1.7.5.1
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Daniel Mack

The comment does not reflect reality anymore since the multi-component monster patch landed. Things are matched by names now, and not by exporting and referencing a struct. Fix it to avoid confusion.

Cc Mark Brown <[email protected]>
Cc Liam Girdwood <[email protected]>
---
 sound/soc/codecs/cs4270.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
#2 lore raw
In reply to Daniel Mack
Quoted 7 lines · Daniel Mack

The comment does not reflect reality anymore since the multi-component monster patch landed. Things are matched by names now, and not by exporting and referencing a struct. Fix it to avoid confusion.

Cc Mark Brown <[email protected]>
Cc Liam Girdwood <[email protected]>

CCing in Timur for his review.

Quoted 23 lines
---
 sound/soc/codecs/cs4270.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
sound/soc/codecs/cs4270.c +1 -4
index 0206a17..6cc8678 100644
@@ -636,10 +636,7 @@ static int cs4270_soc_resume(struct snd_soc_codec *codec)
 #endif /* CONFIG_PM */
 
 /*
- * ASoC codec device structure
- *
- * Assign this variable to the codec_dev field of the machine driver's
- * snd_soc_device structure.
+ * ASoC codec driver structure
  */
 static const struct snd_soc_codec_driver soc_codec_device_cs4270 = {
 	.probe =		cs4270_probe,
Signature · 1 line
1.7.5.1
Acked-by Timur Tabi on v1 1/1
#3 lore raw
In reply to Daniel Mack
Quoted 7 lines · Daniel Mack

The comment does not reflect reality anymore since the multi-component monster patch landed. Things are matched by names now, and not by exporting and referencing a struct. Fix it to avoid confusion.

Cc Mark Brown <[email protected]>
Cc Liam Girdwood <[email protected]>
Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
Applied
#4 lore raw
In reply to Daniel Mack
Quoted 3 lines · Daniel Mack

The comment does not reflect reality anymore since the multi-component monster patch landed. Things are matched by names now, and not by exporting and referencing a struct. Fix it to avoid confusion.

Applied, thanks.