jbd2 : Fix journal start by passing a parameter to specify if the caller can deal with ENOMEM]
Subsystems (3)
Ted Ts'o
maintainerPATCH 2/3 jbd2 : Fix journal start by passing a parameter to specify if the caller can deal with ENOMEM]
Manish,
For changes that affect non-ext4 code (in this case, ocfs2), in the future, please cc the maintainers of said code, so they have a heads up about the proposed change. You can look that information up in the MAINTAINERS file in the top level of the Linux source tree. (In this case, it's Mark and Joel.)
Thanks, regards,
- Ted
Pass extra bool parameter in journal routines to specify if its ok to fail in the journal start. Passing true means caller is
ok with journal start failures and can handle ENOMEM. Update ocfs2 and ext4 routines to pass false for the updated journal interface by default to retain the existing behavior.
Signed-off-by Manish Katiyar <[email protected]>
Acked-by Jan Kara <[email protected]>
--- fs/ext4/ext4_jbd2.h | 2 +- fs/ext4/super.c | 2 +- fs/jbd2/transaction.c | 26 +++++++------------------- fs/ocfs2/journal.c | 6 +++--- include/linux/jbd2.h | 6 ++---- 5 files changed, 14 insertions(+), 28 deletions(-)
fs/ext4/ext4_jbd2.h +1 -1
@@ -225,7 +225,7 @@ static inline int ext4_journal_extend(handle_t *handle, int nblocks)static inline int ext4_journal_restart (handle_t *handle,int nblocks) {if (ext4_handle_valid (handle)) -return jbd2_journal_restart (handle, nblocks); +return jbd2_journal_restart (handle, nblocks, false);return 0 ; }
fs/ext4/super.c +1 -1
@@ -279,7 +279,7 @@ handle_t *ext4_journal_start_sb(struct super_block *sb, int nblocks)ext4_abort (sb,"Detected aborted journal" );return ERR_PTR (-EROFS ); } -return jbd2_journal_start (journal, nblocks); +return jbd2_journal_start (journal, nblocks, false); }/*
fs/jbd2/transaction.c +7 -19
@@ -308,6 +308,8 @@ static handle_t *new_handle(int nblocks)* handle_t *jbd2_journal_start() - Obtain a new handle. * @journal: Journal to start transaction on. * @nblocks: number of block buffer we might modify +* @errok: True if the callers can handle ENOMEM failures from +* this routine, false otherwise * * We make sure that the transaction can guarantee at least nblocks of * modified buffers in the log. We block until the log can guarantee
@@ -318,7 +320,7 @@ static handle_t *new_handle(int nblocks)* * Return a pointer to a newly allocated handle, or NULL on failure */ -handle_t *jbd2__journal_start (journal_t *journal,int nblocks,int gfp_mask) +handle_t *jbd2_journal_start (journal_t *journal,int nblocks,bool errok) {handle_t *handle =journal_current_handle ();int err;
@@ -338,7 +340,7 @@ handle_t *jbd2__journal_start(journal_t *journal, int nblocks, int gfp_mask) current->journal_info = handle; - err =start_this_handle (journal, handle, gfp_mask); + err =start_this_handle (journal, handle,GFP_NOFS );if (err <0 ) {jbd2_free_handle (handle); current->journal_info =NULL ;
@@ -346,13 +348,6 @@ handle_t *jbd2__journal_start(journal_t *journal, int nblocks, int gfp_mask) }return handle; } -EXPORT_SYMBOL (jbd2__journal_start); - - -handle_t *jbd2_journal_start (journal_t *journal,int nblocks) -{ -return jbd2__journal_start (journal, nblocks,GFP_NOFS ); -}EXPORT_SYMBOL (jbd2_journal_start);
@@ -441,7 +436,7 @@ out:* transaction capabable of guaranteeing the requested number of * credits. */ -int jbd2__journal_restart (handle_t *handle,int nblocks,int gfp_mask) +int jbd2_journal_restart (handle_t *handle,int nblocks,bool errok) {transaction_t *transaction = handle->h_transaction;journal_t *journal = transaction->t_journal;
@@ -477,16 +472,9 @@ int jbd2__journal_restart(handle_t *handle, int nblocks, int gfp_mask)lock_map_release (&handle->h_lockdep_map); handle->h_buffer_credits = nblocks; - ret =start_this_handle (journal, handle, gfp_mask); + ret =start_this_handle (journal, handle,GFP_NOFS );return ret; } -EXPORT_SYMBOL (jbd2__journal_restart); - - -int jbd2_journal_restart (handle_t *handle,int nblocks) -{ -return jbd2__journal_restart (handle, nblocks,GFP_NOFS ); -}EXPORT_SYMBOL (jbd2_journal_restart);/**
@@ -1436,7 +1424,7 @@ int jbd2_journal_force_commit(journal_t *journal)handle_t *handle;int ret; - handle =jbd2_journal_start (journal,1 ); + handle =jbd2_journal_start (journal,1 , false);if (IS_ERR (handle)) { ret =PTR_ERR (handle); }else {
fs/ocfs2/journal.c +3 -3
@@ -353,11 +353,11 @@ handle_t *ocfs2_start_trans(struct ocfs2_super *osb, int max_buffs)/* Nested transaction? Just return the handle... */ if (journal_current_handle ()) -return jbd2_journal_start (journal, max_buffs); +return jbd2_journal_start (journal, max_buffs, false);down_read (&osb->journal->j_trans_barrier); - handle =jbd2_journal_start (journal, max_buffs); + handle =jbd2_journal_start (journal, max_buffs, false);if (IS_ERR (handle)) {up_read (&osb->journal->j_trans_barrier);
@@ -438,7 +438,7 @@ int ocfs2_extend_trans(handle_t *handle, int nblocks)if (status >0 ) {trace_ocfs2_extend_trans_restart (old_nblocks + nblocks); status =jbd2_journal_restart (handle, - old_nblocks + nblocks); + old_nblocks + nblocks, false);if (status <0 ) {mlog_errno (status); goto bail;
include/linux/jbd2.h +2 -4
@@ -1103,10 +1103,8 @@ static inline handle_t *journal_current_handle(void)* Register buffer modifications against the current transaction. */ -extern handle_t *jbd2_journal_start (journal_t *,int nblocks); -extern handle_t *jbd2__journal_start (journal_t *,int nblocks,int gfp_mask); -extern int jbd2_journal_restart (handle_t *,int nblocks); -extern int jbd2__journal_restart (handle_t *,int nblocks,int gfp_mask); +extern handle_t *jbd2_journal_start (journal_t *,int nblocks,bool errok); +extern int jbd2_journal_restart (handle_t *,int nblocks,bool errok);extern int jbd2_journal_extend (handle_t *,int nblocks);extern int jbd2_journal_get_write_access (handle_t *,struct buffer_head *);extern int jbd2_journal_get_create_access (handle_t *,struct buffer_head *);
Signature · 5 lines
1.7.4.1 -- Thanks - Manish