Skip to contentSkip to conversation

drm: i915: correct return status in intel_hdmi_mode_valid()

PATCH In review Nicolas Kaiser 2 participants 2 messages May 30, 2011 – Jun 2, 2011

Subsystems (2)
DRM drivers Intel i915
lore
Share & tools
lore

Nicolas Kaiser

author
#0 lore raw

PATCH 1/1 drm: i915: correct return status in intel_hdmi_mode_valid()

Forwarding to Keith Packard.
Sorry, initially sent to the previous maintainer instead.

Start weitergeleitete Nachricht:
Datum: Fri, 20 May 2011 18:58:53 +0200
Von: Nicolas Kaiser <[email protected]>
An: Chris Wilson <[email protected]>
Cc: David Airlie <[email protected]>, [email protected], [email protected]
Betreff: [PATCH] drm: i915: correct return status in intel_hdmi_mode_valid()

Signed-off-by Nicolas Kaiser <[email protected]>

---
Untested: just looks to me like the intention might be to return MODE_CLOCK_LOW here, is that correct?

 drivers/gpu/drm/i915/intel_hdmi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
index f289b86..655bbd9 100644
@@ -194,7 +194,7 @@ static int intel_hdmi_mode_valid(struct drm_connector *connector,
 	if (mode->clock > 165000)
 		return MODE_CLOCK_HIGH;
 	if (mode->clock < 20000)
-		return MODE_CLOCK_HIGH;
+		return MODE_CLOCK_LOW;
 
 	if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
 		return MODE_NO_DBLESCAN;
Signature · 1 line
1.7.5.rc3
Reviewed-by on v1 1/1
#1 lore raw

drivers/gpu/drm/i915/intel_hdmi.c static int intel_hdmi_mode_valid(struct drm_connector *connector, · line 197

Quoted 3 lines · Nicolas Kaiser
drivers/gpu/drm/i915/intel_hdmi.c +1 -1
 	if (mode->clock < 20000)
-		return MODE_CLOCK_HIGH;
+		return MODE_CLOCK_LOW;

Seems obvious to me.

Reviewed-by Keith Packard <[email protected]>
Signature · 1 line
[email protected]