Skip to contentSkip to conversation

omap: rx51: Set regulator V28_A always on

PATCH Superseded Jarkko Nikula 2 participants 3 messages May 12, 2011 – May 31, 2011

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 omap: rx51: Set regulator V28_A always on

The V28_A domain in Nokia N900 that supplies VDD voltages to TLV320AIC34 and TPA6130A2 should not be shutdown. This is because otherwise there will be leak from VIO to VDD in TLV320AIC34 and this leak consumes more battery current that is saved from keeping V28_A off. With this patch the battery current consumption is approximately 1.5 mA lower.

Thanks to Kalle Jokiniemi <[email protected]> for noticing the issue.

Cc Kalle Jokiniemi <[email protected]>
---
 arch/arm/mach-omap2/board-rx51-peripherals.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/board-rx51-peripherals.c +1 -0
index bbcb677..8242e99 100644
@@ -464,6 +464,7 @@ static struct regulator_init_data rx51_vmmc2 = {
 		.name			= "V28_A",
 		.min_uV			= 2800000,
 		.max_uV			= 3000000,
+		.always_on		= true, /* due VIO leak to AIC34 VDDs */
 		.apply_uV		= true,
 		.valid_modes_mask	= REGULATOR_MODE_NORMAL
 					| REGULATOR_MODE_STANDBY,
Signature · 1 line
1.7.4.4
#1 lore raw

PATCH 2/2 omap: rx51: Don't power up speaker amplifier at bootup

Speaker amplifier is accidentally powered up in early TWL gpio setup. This causes a few mA of needless battery current consumption. Without this patch the amplifier can be shutdown only by having one active audio playback and shutdown cycle to speaker output.

Thanks to Kalle Jokiniemi <[email protected]> for noticing the issue.

Cc Kalle Jokiniemi <[email protected]>
---
 arch/arm/mach-omap2/board-rx51-peripherals.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-rx51-peripherals.c +1 -1
index 8242e99..0374562 100644
@@ -561,7 +561,7 @@ static int rx51_twlgpio_setup(struct device *dev, unsigned gpio, unsigned n)
 	gpio_request(gpio + 6, "backlight_pwm");
 	gpio_direction_output(gpio + 6, 0);
 	gpio_request(gpio + 7, "speaker_en");
-	gpio_direction_output(gpio + 7, 1);
+	gpio_direction_output(gpio + 7, 0);
 
 	return 0;
 }
Signature · 1 line
1.7.4.4
maintainer
#2 lore raw

PATCH 2/2 omap: rx51: Don't power up speaker amplifier at bootup

Quoted 18 lines · Jarkko Nikula

Speaker amplifier is accidentally powered up in early TWL gpio setup. This causes a few mA of needless battery current consumption. Without this patch the amplifier can be shutdown only by having one active audio playback and shutdown cycle to speaker output.

Thanks to Kalle Jokiniemi <[email protected]> for noticing the issue.

Cc Kalle Jokiniemi <[email protected]>
---
 arch/arm/mach-omap2/board-rx51-peripherals.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-rx51-peripherals.c +0 -0
index 8242e99..0374562 100644

arch/arm/mach-omap2/board-rx51-peripherals.c static int rx51_twlgpio_setup(struct device *dev, unsigned gpio, unsigned n) · line 567

Quoted 8 lines
arch/arm/mach-omap2/board-rx51-peripherals.c +1 -1
@@ -561,7 +561,7 @@ static int rx51_twlgpio_setup(struct device *dev, unsigned gpio, unsigned n)
 	gpio_request(gpio + 6, "backlight_pwm");
 	gpio_direction_output(gpio + 6, 0);
 	gpio_request(gpio + 7, "speaker_en");
-	gpio_direction_output(gpio + 7, 1);
+	gpio_direction_output(gpio + 7, 0);
 
 	return 0;
 }

Jarkko care to rebase this on current -rc1?

Tony