Skip to contentSkip to conversation

Fix: ZOOM: QUART: Request reset GPIO

PATCH New Tarun Kanti DebBarma 2 participants 2 messages May 20, 2011 – May 31, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Tarun Kanti DebBarma

author
#0 lore raw

PATCH 1/1 Fix: ZOOM: QUART: Request reset GPIO

From: Charulatha V <[email protected]>

Reset GPIO (OMAP_GPIO_152) for QUART in zoom2/zoom3 debug-board is not requested at all. This would lead to problems if this GPIO is wrongly requested. Hence request OMAP GPIO 152 for QUART RESET but do not apply a reset pulse as it would reset QUART and disturb the QUART settings.

Signed-off-by Charulatha V <[email protected]>
Acked-by Kevin Hilman <[email protected]>
Cc Santosh Shilimkar <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-zoom-debugboard.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/board-zoom-debugboard.c +9 -0
index 007ebdc..a5f62f8 100644
@@ -22,6 +22,7 @@
 #define ZOOM_SMSC911X_GPIO	158
 #define ZOOM_QUADUART_CS	3
 #define ZOOM_QUADUART_GPIO	102
+#define ZOOM_QUADUART_RST_GPIO	152
 #define QUART_CLK		1843200
 #define DEBUG_BASE		0x08000000
 #define ZOOM_ETHR_START	DEBUG_BASE

@@ -110,6 +111,14 @@ static inline void __init zoom_init_quaduart(void)
 	unsigned long cs_mem_base;
 	int quart_gpio = 0;
 
+	if (gpio_request_one(ZOOM_QUADUART_RST_GPIO,
+				GPIOF_OUT_INIT_LOW,
+				"TL16CP754C GPIO") < 0) {
+		pr_err("Failed to request GPIO%d for TL16CP754C\n",
+			ZOOM_QUADUART_RST_GPIO);
+		return;
+	}
+
 	quart_cs = ZOOM_QUADUART_CS;
 
 	if (gpmc_cs_request(quart_cs, SZ_1M, &cs_mem_base) < 0) {
Signature · 1 line
1.6.0.4
maintainer
#1 lore raw

PATCH 1/1 Fix: ZOOM: QUART: Request reset GPIO

Quoted 7 lines · Tarun Kanti DebBarma

From: Charulatha V <[email protected]>

Reset GPIO (OMAP_GPIO_152) for QUART in zoom2/zoom3 debug-board is not requested at all. This would lead to problems if this GPIO is wrongly requested. Hence request OMAP GPIO 152 for QUART RESET but do not apply a reset pulse as it would reset QUART and disturb the QUART settings.

Thanks adding to devel-board.

Tony