ARM: OMAP2: Add missing include of linux/gpio.h
Subsystems (3)
PATCH v2 1/1 ARM: OMAP2: Add missing include of linux/gpio.h
I got some build error like below while executing "make omap2plus_defconfig".
CC arch/arm/mach-omap2/board-2430sdp.oarch/arm/mach-omap2/board-2430sdp.c: In function 'omap_2430sdp_init':arch/arm/mach-omap2/board-2430sdp.c:247: error: 'GPIOF_OUT_INIT_LOW' undeclared (first use in this function) arch/arm/mach-omap2/board-2430sdp.c:247: error: (Each undeclared identifier is reported only once arch/arm/mach-omap2/board-2430sdp.c:247: error: for each function it appears in.)
This patch fixes the build error by include linux/gpio.h instead of mach/gpio.h.
--- arch/arm/mach-omap2/board-2430sdp.c | 2 +- arch/arm/mach-omap2/board-apollon.c | 2 +- arch/arm/mach-omap2/board-omap3pandora.c | 2 +- arch/arm/mach-omap2/board-overo.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/mach-omap2/board-2430sdp.c +1 -1
@@ -26,13 +26,13 @@#include <linux/err.h> #include <linux/clk.h> #include <linux/io.h> +#include <linux/gpio.h> #include <mach/hardware.h> #include <asm/mach-types.h> #include <asm/mach/arch.h> #include <asm/mach/map.h> -#include <mach/gpio.h> #include <plat/board.h> #include <plat/common.h> #include <plat/gpmc.h>
arch/arm/mach-omap2/board-apollon.c +1 -1
@@ -27,13 +27,13 @@#include <linux/err.h> #include <linux/clk.h> #include <linux/smc91x.h> +#include <linux/gpio.h> #include <mach/hardware.h> #include <asm/mach-types.h> #include <asm/mach/arch.h> #include <asm/mach/flash.h> -#include <mach/gpio.h> #include <plat/led.h> #include <plat/usb.h> #include <plat/board.h>
arch/arm/mach-omap2/board-omap3pandora.c +1 -1
@@ -30,6 +30,7 @@#include <linux/leds.h> #include <linux/input.h> #include <linux/input/matrix_keypad.h> +#include <linux/gpio.h> #include <linux/gpio_keys.h> #include <linux/mmc/host.h> #include <linux/mmc/card.h>
@@ -41,7 +42,6 @@#include <plat/board.h> #include <plat/common.h> -#include <mach/gpio.h> #include <mach/hardware.h> #include <plat/mcspi.h> #include <plat/usb.h>
arch/arm/mach-omap2/board-overo.c +1 -1
@@ -24,6 +24,7 @@#include <linux/err.h> #include <linux/init.h> #include <linux/io.h> +#include <linux/gpio.h> #include <linux/kernel.h> #include <linux/platform_device.h> #include <linux/i2c/twl.h>
@@ -45,7 +46,6 @@#include <plat/common.h> #include <video/omapdss.h> #include <video/omap-panel-generic-dpi.h> -#include <mach/gpio.h> #include <plat/gpmc.h> #include <mach/hardware.h> #include <plat/nand.h>
Signature · 1 line
1.7.4.1
Tony Lindgren
maintainerQuoted 9 lines · Axel Lin
I got some build error like below while executing "make
omap2plus_defconfig".CC
arch/arm/mach-omap2/board-2430sdp.oarch/arm/mach-omap2/board-2430sdp.c: In function 'omap_2430sdp_init':arch/arm/mach-omap2/board-2430sdp.c:247: error: 'GPIOF_OUT_INIT_LOW' undeclared (first use in this function)arch/arm/mach-omap2/board-2430sdp.c:247: error: (Each undeclared identifier is reported only oncearch/arm/mach-omap2/board-2430sdp.c:247: error: for each function it appears in.)This patch fixes the build error by include
linux/gpio.hinstead ofmach/gpio.h.
Does this happen with next?
Will queue as a fix anyways.
Tony
2011/5/31 Tony Lindgren <[email protected]>:
Quoted 9 lines · Axel Lin
Quoted 8 lines
I got some build error like below while executing "make
omap2plus_defconfig".? CC ? ? ?arch/arm/mach-omap2/board-2430sdp.o
arch/arm/mach-omap2/board-2430sdp.c: In function 'omap_2430sdp_init':arch/arm/mach-omap2/board-2430sdp.c:247: error: 'GPIOF_OUT_INIT_LOW' undeclared (first use in this function)arch/arm/mach-omap2/board-2430sdp.c:247: error: (Each undeclared identifier is reported only oncearch/arm/mach-omap2/board-2430sdp.c:247: error: for each function it appears in.)
Quoted 3 lines
Quoted 1 line
This patch fixes the build error by include
linux/gpio.hinstead ofmach/gpio.h.Does this happen with next?
Yes, I build the kernel with today's linux-next tree.
Quoted 2 lines
Will queue as a fix anyways.
Thanks,
Axel