perf cgroup per-task attaching
Just FYI:
I'm getting
kernel/events/core.c:7445: warning: initialization from incompatible pointer type
when building -rc1 with CONFIG_CGROUP_PERF enabled. AFAICT, this is due to the fact that f780bdb7c1c73009cb57adcf99ef50027d80bf3c dropped the threadgroup arg from cgroup_subsys->attach in favour of per-thread callbacks.
perf_cgroup_attach() actually does reschedule the task context after the cgroup changes so the perf cgroup code would need some non-trivial adjusting to the new APIs.
Signature · 8 lines
Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
Quoted 6 lines · Borislav Petkov
Just FYI:
I'm getting
kernel/events/core.c:7445: warning: initialization from incompatible pointer type
Quoted 8 lines
when building -rc1 with
CONFIG_CGROUP_PERFenabled. AFAICT, this is due to the fact thatf780bdb7c1c73009cb57adcf99ef50027d80bf3cdropped the threadgroup arg fromcgroup_subsys->attachin favour of per-thread callbacks.
perf_cgroup_attach()actually does reschedule the task context after the cgroup changes so the perf cgroup code would need some non-trivial adjusting to the new APIs.
lkml.kernel.org/r/[email protected]
Quoted 12 lines · Peter Zijlstra
Quoted 11 lines · Borislav Petkov
Just FYI:
I'm getting
kernel/events/core.c:7445: warning: initialization from incompatible pointer typewhen building -rc1 with
CONFIG_CGROUP_PERFenabled. AFAICT, this is due to the fact thatf780bdb7c1c73009cb57adcf99ef50027d80bf3cdropped the threadgroup arg fromcgroup_subsys->attachin favour of per-thread callbacks.
Quoted 5 lines
Quoted 3 lines
perf_cgroup_attach()actually does reschedule the task context after the cgroup changes so the perf cgroup code would need some non-trivial adjusting to the new APIs.lkml.kernel.org/r/[email protected]
Hehe, that happened today already! :)
Thanks.
Signature · 8 lines
Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632