iwl4965: correctly validate temperature value

PATCH New Stanislaw Gruszka 1 participant 1 message Jun 1, 2011 Networking drivers (wireless)

Share & tools

Stanislaw Gruszka

author

2011-06-01 15:18 UTC #0 lore raw

PATCH 1/1 iwl4965: correctly validate temperature value

In some cases we can read wrong temperature value. If after that temperature value will not be updated to good one, we badly configure tx power parameters and device is unable to send a data.

Resolves:
https://bugzilla.kernel.org/show_bug.cgi?id=35932

Cc [email protected] # 2.6.39+

Signed-off-by Stanislaw Gruszka <[email protected]>

drivers/net/wireless/iwlegacy/iwl-4965.c +1 -1

index f5433c7..f9db25b 100644
@@ -1543,7 +1543,7 @@ static void iwl4965_temperature_calib(struct iwl_priv *priv)
 	s32 temp;
 
 	temp = iwl4965_hw_get_temperature(priv);
-	if (temp < 0)
+	if (IWL_TX_POWER_TEMPERATURE_OUT_OF_RANGE(temp))
 		return;
 
 	if (priv->temperature != temp) {