efifb speedup and fixes
cover efifb speedup and fixes
Fbcon over efifb is so slow that I thought I needed a faster modem. It turns out that scrolling boot messages at 1024x768 pixels with uncached accesses can take longer than every other step of kernel bootup *combined*.
Fixing it is a one-liner, but I found some bugs while I was digging around. One is a mismatched resource release (although not on my box), one is a harmless compiler warning, and one fixes all manner of badness that happens if you manually bind or unbind the efifb driver.
The speedup may or may not be 2.6.40 material, but the other fixes should probably go in. (2/4 and 4/4 are possibly -stable candidates.)
Andy Lutomirski (4):
efifb: Enable write-combining
efifb: Fix mismatched request/release_mem_region
efifb: Fix an integer-to-pointer size warning
efifb: Disallow manual bind and unbind
Andy Lutomirski (4):
efifb: Enable write-combining
efifb: Fix mismatched request/release_mem_region
efifb: Fix an integer-to-pointer size warning
efifb: Disallow manual bind and unbind
drivers/video/efifb.c | 39 +++++++++++++++++++++++++-------------- 1 files changed, 25 insertions(+), 14 deletions(-)
Signature · 1 line
1.7.5.1
Quoted 10 lines · Andy Lutomirski
Fbcon over efifb is so slow that I thought I needed a faster modem. It turns out that scrolling boot messages at 1024x768 pixels with uncached accesses can take longer than every other step of kernel bootup *combined*.
Fixing it is a one-liner, but I found some bugs while I was digging around. One is a mismatched resource release (although not on my box), one is a harmless compiler warning, and one fixes all manner of badness that happens if you manually bind or unbind the efifb driver.
Quoted 9 lines
The speedup may or may not be 2.6.40 material, but the other fixes should probably go in. (2/4 and 4/4 are possibly -stable candidates.)
Andy Lutomirski (4):
efifb: Enable write-combining
efifb: Fix mismatched request/release_mem_region
efifb: Fix an integer-to-pointer size warning
efifb: Disallow manual bind and unbind
I've applied patches 1, 2, and 4 along with Peter's sign off. I've not added a stable cc since neither were specifically regressions, so I'll just let Greg naturally decide whether to take them or not.
Quoted 9 lines
Quoted 6 lines
Andy Lutomirski (4):
efifb: Enable write-combining
efifb: Fix mismatched request/release_mem_region
efifb: Fix an integer-to-pointer size warning
efifb: Disallow manual bind and unbindI've applied patches 1, 2, and 4 along with Peter's sign off. I've not added a stable cc since neither were specifically regressions, so I'll just let Greg naturally decide whether to take them or not.
Thanks, Paul.
Signature · 1 line
Peter