Skip to contentSkip to conversation

doc: remove ns_cgroup from feature-removal-schedule.txt

PATCH In review Américo Wang 2 participants 4 messages Jun 7, 2011 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: remove ns_cgroup from feature-removal-schedule.txt

In the following commit Daniel removed ns_cgroup

	commit a77aea92010acf54ad785047234418d5d68772e2
	Author: Daniel Lezcano <[email protected]>
	Date:   Thu May 26 16:25:23 2011 -0700

	    cgroup: remove the ns_cgroup

but Daniel forgot to remove the related doc in feature-removal-schedule.txt. This patch removes that too.

Cc Daniel Lezcano <[email protected]>
Cc Serge E. Hallyn <[email protected]>

---

Documentation/feature-removal-schedule.txt +0 -17
index 1a9446b..72e2384 100644
@@ -481,23 +481,6 @@ Who:	FUJITA Tomonori <[email protected]>
 
 ----------------------------
 
-What:   namespace cgroup (ns_cgroup)
-When:   2.6.38
-Why:    The ns_cgroup leads to some problems:
-	* cgroup creation is out-of-control
-	* cgroup name can conflict when pids are looping
-	* it is not possible to have a single process handling
-	a lot of namespaces without falling in a exponential creation time
-	* we may want to create a namespace without creating a cgroup
-
-	The ns_cgroup is replaced by a compatibility flag 'clone_children',
-	where a newly created cgroup will copy the parent cgroup values.
-	The userspace has to manually create a cgroup and add a task to
-	the 'tasks' file.
-Who:    Daniel Lezcano <[email protected]>
-
-----------------------------
-
 What:	iwlwifi disable_hw_scan module parameters
 When:	2.6.40
 Why:	Hareware scan is the prefer method for iwlwifi devices for
#1 lore raw
Quoted 10 lines · Américo Wang

In the following commit Daniel removed ns_cgroup

	commit a77aea92010acf54ad785047234418d5d68772e2
	Author: Daniel Lezcano<[email protected]>
	Date:   Thu May 26 16:25:23 2011 -0700

	    cgroup: remove the ns_cgroup

but Daniel forgot to remove the related doc in feature-removal-schedule.txt. This patch removes that too.

Well, I am not sure we should remove this entry from the documentation.
I let this in the doc because people may want to follow what was removed and from what kernel version. Looking at the doc, there are a lot of old entries.

#2 lore raw
Quoted 7 lines · Daniel Lezcano
Quoted 6 lines · Américo Wang

In the following commit Daniel removed ns_cgroup

	commit a77aea92010acf54ad785047234418d5d68772e2
	Author: Daniel Lezcano<[email protected]>
	Date:   Thu May 26 16:25:23 2011 -0700
Quoted 6 lines
Quoted 4 lines

cgroup: remove the ns_cgroup

but Daniel forgot to remove the related doc in feature-removal-schedule.txt. This patch removes that too.

Well, I am not sure we should remove this entry from the documentation.

That is a list of features which will be removed,
not for features that was in the kernel.

Quoted 2 lines

I let this in the doc because people may want to follow what was removed and from what kernel version.

We have changelogs or git logs, right? :)

Quoted 1 line

Looking at the doc, there are a lot of old entries.

Such as?

#3 lore raw
Quoted 12 lines · Américo Wang
Quoted 11 lines · Daniel Lezcano
Quoted 10 lines · Américo Wang

In the following commit Daniel removed ns_cgroup

	commit a77aea92010acf54ad785047234418d5d68772e2
	Author: Daniel Lezcano<[email protected]>
	Date:   Thu May 26 16:25:23 2011 -0700

	    cgroup: remove the ns_cgroup

but Daniel forgot to remove the related doc in feature-removal-schedule.txt. This patch removes that too.

Quoted 7 lines
Quoted 1 line

Well, I am not sure we should remove this entry from the documentation.

That is a list of features which will be removed,
not for features that was in the kernel.

Quoted 2 lines

I let this in the doc because people may want to follow what was removed and from what kernel version.

We have changelogs or git logs, right? :)

Never mind.

The introduction in the doc file is clear:

"... When the feature is removed from the kernel, it should also be removed from this file."

Sorry I missed this when removing the ns_cgroup.

Thanks for fixing it.

-- Daniel