ti-dsplink: Fixed location of toolchain
PATCH 1/1 ti-dsplink: Fixed location of toolchain
ti-dsplink: Fixed location of toolchain to build ti-dsplink.
--- recipes/ti/ti-dsplink.inc | 34 +++++++++++++++++----------------- 1 files changed, 17 insertions(+), 17 deletions(-)
recipes/ti/ti-dsplink.inc +17 -17
@@ -94,23 +94,23 @@ do_compile() { # Build the gpp user space library cd ${DSPLINK}/gpp/src/api && make \ CROSS_COMPILE="${TARGET_PREFIX}" \ - CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ - LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ld" \ - COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ + CC="${CC}" \ + AR="${AR}" \ + LD="${LD}" \ + COMPILER="${CC}" \ + ARCHIVER="${AR}" \ KERNEL_DIR="${STAGING_KERNEL_DIR}" \ all # Build the gpp kernel space (debug and release) cd ${DSPLINK}/gpp/src && make \ - OBJDUMP="${TARGET_PREFIX}objdump" \ + OBJDUMP="${OBJDUMP}" \ CROSS_COMPILE="${TARGET_PREFIX}" \ - CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ - LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ld" \ - COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ + CC="${CC}" \ + AR="${AR}" \ + LD="${LD}" \ + COMPILER="${CC}" \ + ARCHIVER="${AR}" \ KERNEL_DIR="${STAGING_KERNEL_DIR}" \ BASE_BUILDOS="${STAGING_KERNEL_DIR}" \ all
@@ -122,12 +122,12 @@ do_compile() { OSINC_PLATFORM="${TOOLCHAIN_PATH}/lib/gcc/${TARGET_SYS}/$(${TARGET_PREFIX}gcc -dumpversion)/include" \ OSINC_TARGET="${BASE_TOOLCHAIN}/target/usr/include" \ CROSS_COMPILE="${TARGET_PREFIX}" \ - CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ - COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - LINKER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ + CC="${CC}" \ + AR="${AR}" \ + LD="${LD}" \ + COMPILER="${CC}" \ + ARCHIVER="${AR}" \ + LINKER="${CC}" \ KERNEL_DIR="${STAGING_KERNEL_DIR}" \ all
Quoted 3 lines · Joel A Fernandes
ti-dsplink: Fixed location of toolchain to build ti-dsplink.
Signed-off-by Joel A Fernandes <[email protected]>
Have you tested this with an external toolchain?
Signature · 1 line
Denys
Quoted 67 lines
--- recipes/ti/ti-dsplink.inc | 34 +++++++++++++++++----------------- 1 files changed, 17 insertions(+), 17 deletions(-)recipes/ti/ti-dsplink.inc +17
-17@@ -94,23 +94,23 @@ do_compile() { # Build the gpp user space library cd ${DSPLINK}/gpp/src/api && make \ CROSS_COMPILE="${TARGET_PREFIX}" \ - CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ - LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ld" \ - COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ + CC="${CC}" \ + AR="${AR}" \ + LD="${LD}" \ + COMPILER="${CC}" \ + ARCHIVER="${AR}" \ KERNEL_DIR="${STAGING_KERNEL_DIR}" \ all # Build the gpp kernel space (debug and release) cd ${DSPLINK}/gpp/src && make \ - OBJDUMP="${TARGET_PREFIX}objdump" \ + OBJDUMP="${OBJDUMP}" \ CROSS_COMPILE="${TARGET_PREFIX}" \ - CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ - LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ld" \ - COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ + CC="${CC}" \ + AR="${AR}" \ + LD="${LD}" \ + COMPILER="${CC}" \ + ARCHIVER="${AR}" \ KERNEL_DIR="${STAGING_KERNEL_DIR}" \ BASE_BUILDOS="${STAGING_KERNEL_DIR}" \ all@@ -122,12 +122,12 @@ do_compile() { OSINC_PLATFORM="${TOOLCHAIN_PATH}/lib/gcc/${TARGET_SYS}/$(${TARGET_PREFIX}gcc -dumpversion)/include" \ OSINC_TARGET="${BASE_TOOLCHAIN}/target/usr/include" \ CROSS_COMPILE="${TARGET_PREFIX}" \ - CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ - COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - LINKER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ + CC="${CC}" \ + AR="${AR}" \ + LD="${LD}" \ + COMPILER="${CC}" \ + ARCHIVER="${AR}" \ + LINKER="${CC}" \ KERNEL_DIR="${STAGING_KERNEL_DIR}" \ all_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 1 line · Joel A Fernandes
ti-dsplink: Fixed location of toolchain to build ti-dsplink.
It sadly really needs an absolute path to the tools :(
Quoted 53 lines
Signed-off-by Joel A Fernandes <[email protected]>--- recipes/ti/ti-dsplink.inc | 34 +++++++++++++++++----------------- 1 files changed, 17 insertions(+), 17 deletions(-)recipes/ti/ti-dsplink.inc +11
-15@@ -94,23 +94,23 @@ do_compile() { # Build the gpp user space library cd ${DSPLINK}/gpp/src/api && make \ CROSS_COMPILE="${TARGET_PREFIX}" \ - CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ - LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ld" \ - COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ + CC="${CC}" \ + AR="${AR}" \ + LD="${LD}" \ + COMPILER="${CC}" \ + ARCHIVER="${AR}" \ KERNEL_DIR="${STAGING_KERNEL_DIR}" \ all # Build the gpp kernel space (debug and release) cd ${DSPLINK}/gpp/src && make \ - OBJDUMP="${TARGET_PREFIX}objdump" \ + OBJDUMP="${OBJDUMP}" \ CROSS_COMPILE="${TARGET_PREFIX}" \ - CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ - LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ld" \ - COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ + CC="${CC}" \ + AR="${AR}" \ + LD="${LD}" \ + COMPILER="${CC}" \ + ARCHIVER="${AR}" \ KERNEL_DIR="${STAGING_KERNEL_DIR}" \ BASE_BUILDOS="${STAGING_KERNEL_DIR}" \ all@@ -122,12 +122,12 @@ do_compile() { OSINC_PLATFORM="${TOOLCHAIN_PATH}/lib/gcc/${TARGET_SYS}/$(${TARGET_PREFIX}gcc -dumpversion)/include" \ OSINC_TARGET="${BASE_TOOLCHAIN}/target/usr/include" \ CROSS_COMPILE="${TARGET_PREFIX}" \ - CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ - COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
recipes/ti/ti-dsplink.inc do_compile() { · line 132
Quoted 10 lines
recipes/ti/ti-dsplink.inc +6
-2- LINKER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ + CC="${CC}" \ + AR="${AR}" \ + LD="${LD}" \ + COMPILER="${CC}" \ + ARCHIVER="${AR}" \ + LINKER="${CC}" \ KERNEL_DIR="${STAGING_KERNEL_DIR}" \ all
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFN9w96MkyGM64RGpERAkk+AJ9kAE91Op6450wG1xySGpAa3drFXQCfSNcO F1rBpao1N5wwWAlNk6kwiqU=
=x1pA
-----END PGP SIGNATURE-----
Quoted 7 lines · Koen Kooi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quoted 1 line · Joel A Fernandes
ti-dsplink: Fixed location of toolchain to build ti-dsplink.
It sadly really needs an absolute path to the tools :(
So, what was this patch trying to fix anyway? Is there something broken?
Signature · 1 line
Denys
Quoted 76 lines
Quoted 52 lines
Signed-off-by Joel A Fernandes <[email protected]>--- recipes/ti/ti-dsplink.inc | 34 +++++++++++++++++----------------- 1 files changed, 17 insertions(+), 17 deletions(-)recipes/ti/ti-dsplink.inc +11
-15@@ -94,23 +94,23 @@ do_compile() { # Build the gpp user space library cd ${DSPLINK}/gpp/src/api && make \ CROSS_COMPILE="${TARGET_PREFIX}" \ - CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ - LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ld" \ - COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ + CC="${CC}" \ + AR="${AR}" \ + LD="${LD}" \ + COMPILER="${CC}" \ + ARCHIVER="${AR}" \ KERNEL_DIR="${STAGING_KERNEL_DIR}" \ all # Build the gpp kernel space (debug and release) cd ${DSPLINK}/gpp/src && make \ - OBJDUMP="${TARGET_PREFIX}objdump" \ + OBJDUMP="${OBJDUMP}" \ CROSS_COMPILE="${TARGET_PREFIX}" \ - CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ - LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ld" \ - COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ + CC="${CC}" \ + AR="${AR}" \ + LD="${LD}" \ + COMPILER="${CC}" \ + ARCHIVER="${AR}" \ KERNEL_DIR="${STAGING_KERNEL_DIR}" \ BASE_BUILDOS="${STAGING_KERNEL_DIR}" \ all@@ -122,12 +122,12 @@ do_compile() { OSINC_PLATFORM="${TOOLCHAIN_PATH}/lib/gcc/${TARGET_SYS}/$(${TARGET_PREFIX}gcc -dumpversion)/include" \ OSINC_TARGET="${BASE_TOOLCHAIN}/target/usr/include" \ CROSS_COMPILE="${TARGET_PREFIX}" \ - CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ - COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \recipes/ti/ti-dsplink.inc do_compile() { · line 132
Quoted 10 lines
recipes/ti/ti-dsplink.inc +6
-2- LINKER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \ - ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \ + CC="${CC}" \ + AR="${AR}" \ + LD="${LD}" \ + COMPILER="${CC}" \ + ARCHIVER="${AR}" \ + LINKER="${CC}" \ KERNEL_DIR="${STAGING_KERNEL_DIR}" \ all-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)iD8DBQFN9w96MkyGM64RGpERAkk+AJ9kAE91Op6450wG1xySGpAa3drFXQCfSNcO F1rBpao1N5wwWAlNk6kwiqU=
=x1pA
-----END PGP SIGNATURE-----_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 10 lines · Denys Dmytriyenko
Quoted 7 lines · Koen Kooi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quoted 1 line · Joel A Fernandes
ti-dsplink: Fixed location of toolchain to build ti-dsplink.
It sadly really needs an absolute path to the tools :(
So, what was this patch trying to fix anyway? Is there something broken?
Using an external toolchain without your import magic and then overriding TOOLCHAINPATH in local.conf is broken. You might call it broken by design :)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFN94J7MkyGM64RGpERAufjAJ0byRdnVm9SmVJ0Hlqsyv+BJv75uwCggF42 qeHxFXcjNMNr11nIr+Knmio=
=mZHT
-----END PGP SIGNATURE-----
Quoted 11 lines · Koen Kooi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quoted 7 lines · Denys Dmytriyenko
Quoted 6 lines · Koen Kooi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quoted 1 line · Joel A Fernandes
ti-dsplink: Fixed location of toolchain to build ti-dsplink.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
It sadly really needs an absolute path to the tools :(
So, what was this patch trying to fix anyway? Is there something broken?
Using an external toolchain without your import magic and then overriding TOOLCHAINPATH in local.conf is broken. You might call it broken by design :)
As you know, the design is hindered by requirements, so ease up! :)
As of the "import magic" - there is nothing magical about it, it just sets up TOOLCHAIN_PATH and TOOLCHAIN_SYSPATH automatically. Otherwise you'd have to set at least TOOLCHAIN_PATH manually and it works. So, I still don't see what exactly is broken and needs to be fixed.
BTW, the requirements for absolute toolchain path come from dsplink and not the external toolchain, AFAICR...
Signature · 1 line
Denys
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 20 lines · Denys Dmytriyenko
Quoted 11 lines · Koen Kooi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quoted 7 lines · Denys Dmytriyenko
Quoted 6 lines · Koen Kooi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Quoted 1 line · Joel A Fernandes
ti-dsplink: Fixed location of toolchain to build ti-dsplink.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
It sadly really needs an absolute path to the tools :(
So, what was this patch trying to fix anyway? Is there something broken?
Using an external toolchain without your import magic and then overriding TOOLCHAINPATH in local.conf is broken. You might call it broken by design :)
Quoted 6 lines
As you know, the design is hindered by requirements, so ease up! :)
As of the "import magic" - there is nothing magical about it, it just sets up
TOOLCHAIN_PATHandTOOLCHAIN_SYSPATHautomatically. Otherwise you'd have to set at leastTOOLCHAIN_PATHmanually and it works. So, I still don't see what exactly is broken and needs to be fixed.
Joel setup his tree the wrong way
Quoted 2 lines
BTW, the requirements for absolute toolchain path come from dsplink and not the external toolchain, AFAICR...
dsplink and others, yes.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFN97jDMkyGM64RGpERAimXAKC70bo3sUyDf+/jzJux/n8mXRurYgCgqsEt RT2PAYT1EIeptDARW/MoEcE=
=Yfp9
-----END PGP SIGNATURE-----