WATCHDOG: mtx1-wdt: use dev_{err,info} instead of printk()
Subsystems (2)
PATCH v3 1/5 WATCHDOG: mtx1-wdt: use dev_{err,info} instead of printk()
---
No changes in v1, v2 and v3
drivers/watchdog/mtx-1_wdt.c +2 -2
@@ -224,11 +224,11 @@ static int __devinit mtx1_wdt_probe(struct platform_device *pdev) ret =misc_register (&mtx1_wdt_misc);if (ret <0 ) { -printk (KERN_ERR " mtx-1_wdt : failed to register\n" ); +dev_err (&pdev->dev,"failed to register\n" );return ret; }mtx1_wdt_start (); -printk (KERN_INFO "MTX-1 Watchdog driver\n" ); +dev_info (&pdev->dev,"MTX-1 Watchdog driver\n" );return 0 ; }
Signature · 1 line
1.7.4.1
Quoted 3 lines · On Wednesday 15 June 2011 19:15:09 Florian Fainelli wrote:
Signed-off-by Florian Fainelli <[email protected]>---
No changes in v1, v2 and v3
Wim, these are mostly fixes for the driver, do you prefer they get merged with the MIPS tree?
Quoted 19 lines
drivers/watchdog/mtx-1_wdt.c +2
-2@@ -224,11 +224,11 @@ static int __devinit mtx1_wdt_probe(struct platform_device *pdev) ret =misc_register (&mtx1_wdt_misc);if (ret <0 ) { -printk (KERN_ERR " mtx-1_wdt : failed to register\n" ); +dev_err (&pdev->dev,"failed to register\n" );return ret; }mtx1_wdt_start (); -printk (KERN_INFO "MTX-1 Watchdog driver\n" ); +dev_info (&pdev->dev,"MTX-1 Watchdog driver\n" );return 0 ; }
Hi Florian,
Quoted 6 lines · On Wednesday 15 June 2011 19:15:09 Florian Fainelli wrote:
Quoted 3 lines
Signed-off-by Florian Fainelli <[email protected]>---
No changes in v1, v2 and v3Wim, these are mostly fixes for the driver, do you prefer they get merged with the MIPS tree?
No, I had them in linux-2.6-watchdog-next since this weekend allready and was planning to sent the fixes upstream. But I think I fotgot to e-mail about it. :-(
Kind regards,
Wim.
Hello Wim,
Quoted 7 lines · On Wednesday 22 June 2011 10:58:09 Wim Van Sebroeck wrote:
Hi Florian,
Quoted 5 lines · On Wednesday 15 June 2011 19:15:09 Florian Fainelli wrote:
Quoted 3 lines
Signed-off-by Florian Fainelli <[email protected]>---
No changes in v1, v2 and v3
Quoted 6 lines
Quoted 2 lines
Wim, these are mostly fixes for the driver, do you prefer they get merged with the MIPS tree?
No, I had them in linux-2.6-watchdog-next since this weekend allready and was planning to sent the fixes upstream. But I think I fotgot to e-mail about it. :-(
No problem, thanks for the heads up.
--
Florian