ARM: amba: Link fb device to its parent
PATCH 1/1 ARM: amba: Link fb device to its parent
Some pieces of userspace like debian-installer expect to find the fb0 driver name by readlink-ing /sys/class/graphics/fb0/device/driver but this was broken with amba-clcd as it sets up fb_info manually and missed the .device parent pointer.
--- drivers/video/amba-clcd.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/video/amba-clcd.c +2 -0
@@ -447,6 +447,8 @@ static int clcdfb_register(struct clcd_fb *fb) goto out; } + fb->fb.device = &fb->dev->dev; + fb->fb.fix.mmio_start = fb->dev->res.start; fb->fb.fix.mmio_len =resource_size (&fb->dev->res);
Signature · 1 line
1.7.5.4
PATCH 1/1 ARM: amba: Link fb device to its parent
Quoted 5 lines · Lo??c Minier
Some pieces of userspace like debian-installer expect to find the fb0 driver name by readlink-ing
/sys/class/graphics/fb0/device/driverbut this was broken with amba-clcd as it sets upfb_infomanually and missed the .device parent pointer.
Quoted 7 lines
Signed-off-by Lo??c Minier <[email protected]>Cc Russell King <[email protected]>Cc Paul Mundt <[email protected]>--- drivers/video/amba-clcd.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
While this is titled as an ARM patch it's certainly fbdev-specific. I'll apply it barring any objections from Russell.
PATCH 1/1 ARM: amba: Link fb device to its parent
Quoted 13 lines · Paul Mundt
Quoted 5 lines · Lo??c Minier
Some pieces of userspace like debian-installer expect to find the fb0 driver name by readlink-ing
/sys/class/graphics/fb0/device/driverbut this was broken with amba-clcd as it sets upfb_infomanually and missed the .device parent pointer.Quoted 7 lines
Signed-off-by Lo??c Minier <[email protected]>Cc Russell King <[email protected]>Cc Paul Mundt <[email protected]>--- drivers/video/amba-clcd.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
Quoted 2 lines
While this is titled as an ARM patch it's certainly fbdev-specific. I'll apply it barring any objections from Russell.
PATCH 1/1 ARM: amba: Link fb device to its parent
In reply to Paul MundtQuoted 13 lines · Paul Mundt
Quoted 5 lines · Lo??c Minier
Some pieces of userspace like debian-installer expect to find the fb0 driver name by readlink-ing
/sys/class/graphics/fb0/device/driverbut this was broken with amba-clcd as it sets upfb_infomanually and missed the .device parent pointer.Quoted 7 lines
Signed-off-by Lo??c Minier <[email protected]>Cc Russell King <[email protected]>Cc Paul Mundt <[email protected]>--- drivers/video/amba-clcd.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
Quoted 2 lines
While this is titled as an ARM patch it's certainly fbdev-specific. I'll apply it barring any objections from Russell.
BTW this should be "Lo?c Minier" not "Lo??c Minier" The original email was fine with proper UTF-8 in that regard. Maybe you should have a look at your MUA config so the resulting patch log going into git is not dammaged.
Nicolas
PATCH 1/1 ARM: amba: Link fb device to its parent
Quoted 15 lines · Nicolas Pitre
Quoted 13 lines · Paul Mundt
Quoted 12 lines · Lo??c Minier
Some pieces of userspace like debian-installer expect to find the fb0 driver name by readlink-ing
/sys/class/graphics/fb0/device/driverbut this was broken with amba-clcd as it sets upfb_infomanually and missed the .device parent pointer.Signed-off-by Lo??c Minier <[email protected]>Cc Russell King <[email protected]>Cc Paul Mundt <[email protected]>--- drivers/video/amba-clcd.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
Quoted 8 lines
Quoted 2 lines
While this is titled as an ARM patch it's certainly fbdev-specific. I'll apply it barring any objections from Russell.
BTW this should be "Lo?c Minier" not "Lo??c Minier" The original email was fine with proper UTF-8 in that regard. Maybe you should have a look at your MUA config so the resulting patch log going into git is not dammaged.
My MUA ignores UTF-8 intentionally, but this has no bearing on the status in my git tree.