Skip to contentSkip to conversation

linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch.

PATCH New Mike Williams 4 participants 6 messages Jun 24, 2011 – Jun 27, 2011

lore
Share & tools
lore

Mike Williams

author
#0 lore raw

PATCH 1/1 linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch.

Signed-off-by Mike Williams <[email protected]>
---
 linux/linux.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
linux/linux.mk +1 -1
index 43ca87b..fbd0fad 100644
@@ -98,7 +98,7 @@ $(LINUX26_DIR)/.stamp_patched: $(LINUX26_DIR)/.stamp_extracted
 		if echo $$p | grep -q -E "^ftp://|^http://" ; then \
 			toolchain/patch-kernel.sh $(@D) $(DL_DIR) `basename $$p` ; \
 		elif test -d $$p ; then \
-			toolchain/patch-kernel.sh $(@D) $$p linux-\*.patch ; \
+			toolchain/patch-kernel.sh $(@D) $$p \*.patch ; \
 		else \
 			toolchain/patch-kernel.sh $(@D) `dirname $$p` `basename $$p` ; \
 		fi \
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 1/1 linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch.

2011/6/24 Mike Williams <[email protected]>:

linux/linux.mk $(LINUX26_DIR)/.stamp_patched: $(LINUX26_DIR)/.stamp_extracted · line 101

Quoted 8 lines
linux/linux.mk +1 -1
@@ -98,7 +98,7 @@ $(LINUX26_DIR)/.stamp_patched: $(LINUX26_DIR)/.stamp_extracted
 ? ? ? ? ? ? ? ?if echo $$p | grep -q -E "^ftp://|^http://" ; then \
 ? ? ? ? ? ? ? ? ? ? ? ?toolchain/patch-kernel.sh $(@D) $(DL_DIR) `basename $$p` ; \
 ? ? ? ? ? ? ? ?elif test -d $$p ; then \
- ? ? ? ? ? ? ? ? ? ? ? toolchain/patch-kernel.sh $(@D) $$p linux-\*.patch ; \
+ ? ? ? ? ? ? ? ? ? ? ? toolchain/patch-kernel.sh $(@D) $$p \*.patch ; \

I have to disagree on this. There might be patches for other packages in that same dir.

And by the way;
http://spheredev.org/wiki/Git_for_the_lazy#Writing_good_commit_messages

#2 lore raw

PATCH 1/1 linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch.

Hello,

Le Mon, 27 Jun 2011 09:10:02 +0200,
Daniel Nystr?m <[email protected]> a ?crit :

Quoted 2 lines

I have to disagree on this. There might be patches for other packages in that same dir.

I was initially tempted to ACK Mike's patch, because I have the same use case than Mike's (using git format-patch and then copying patches to the Buildroot board specific directory), but as Daniel says, there may be patches for other components in the same directory.

Maybe we should simply document this in the option help text?

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#3 lore raw

PATCH 1/1 linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Thomas> I was initially tempted to ACK Mike's patch, because I have the same Thomas> use case than Mike's (using git format-patch and then copying patches Thomas> to the Buildroot board specific directory), but as Daniel says, there Thomas> may be patches for other components in the same directory.

Thomas> Maybe we should simply document this in the option help text?

I think so. It's easy to put the linux patches in a seperate subdir.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch.

Le Mon, 27 Jun 2011 15:05:59 +0200,
Peter Korsgaard <[email protected]> a ?crit :

Quoted 3 lines

Thomas> Maybe we should simply document this in the option help text?

I think so. It's easy to put the linux patches in a seperate subdir.

So your suggestion is to apply Mike's patch ?

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#5 lore raw

PATCH 1/1 linux: Change patch matching string to allow all names. This allows the use of patches output by git format-patch.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Thomas> Maybe we should simply document this in the option help text?

Quoted 2 lines
Quoted 2 lines

I think so. It's easy to put the linux patches in a seperate subdir.

Thomas> So your suggestion is to apply Mike's patch ?

Yes.

Signature · 1 line
Bye, Peter Korsgaard