Skip to contentSkip to conversation

ASoC: Improve error reporting in Speyside WM8962 driver

PATCH In review Mark Brown 3 participants 5 messages Jun 30, 2011

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ASoC: Improve error reporting in Speyside WM8962 driver

---
 sound/soc/samsung/speyside_wm8962.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)
sound/soc/samsung/speyside_wm8962.c +8 -4
index c0ba0bf..55233e8 100644
@@ -30,14 +30,16 @@ static int speyside_wm8962_set_bias_level(struct snd_soc_card *card,
 						  WM8962_FLL_MCLK, 32768,
 						  44100 * 256);
 			if (ret < 0)
-				pr_err("Failed to start FLL\n");
+				pr_err("Failed to start FLL: %d\n");
 
 			ret = snd_soc_dai_set_sysclk(codec_dai,
 						     WM8962_SYSCLK_FLL,
 						     44100 * 256,
 						     SND_SOC_CLOCK_IN);
-			if (ret < 0)
+			if (ret < 0) {
+				pr_err("Failed to set SYSCLK: %d\n");
 				return ret;
+			}
 		}
 		break;
 
@@ -59,13 +61,15 @@ static int speyside_wm8962_set_bias_level_post(struct snd_soc_card *card,
 	case SND_SOC_BIAS_STANDBY:
 		ret = snd_soc_dai_set_sysclk(codec_dai, WM8962_SYSCLK_MCLK,
 					     32768, SND_SOC_CLOCK_IN);
-		if (ret < 0)
+		if (ret < 0) {
+			pr_err("Failed to switch away from FLL: %d\n", ret);
 			return ret;
+		}
 
 		ret = snd_soc_dai_set_pll(codec_dai, WM8962_FLL,
 					  0, 0, 0);
 		if (ret < 0) {
-			pr_err("Failed to stop FLL\n");
+			pr_err("Failed to stop FLL: %d\n", ret);
 			return ret;
 		}
 		break;
Signature · 1 line
1.7.5.4
#1 lore raw

sound/soc/samsung/speyside_wm8962.c static int speyside_wm8962_set_bias_level(struct snd_soc_card *card, · line 33

Quoted 3 lines · Mark Brown
sound/soc/samsung/speyside_wm8962.c +1 -1
 			if (ret < 0)
-				pr_err("Failed to start FLL\n");
+				pr_err("Failed to start FLL: %d\n");

missed 'ret' here? :)

Signature · 1 line
guanqun
author
#2 lore raw
Quoted 6 lines · Lu Guanqun

sound/soc/samsung/speyside_wm8962.c static int speyside_wm8962_set_bias_level(struct snd_soc_card *card, · line 33

Quoted 3 lines · Mark Brown
sound/soc/samsung/speyside_wm8962.c +1 -1
 			if (ret < 0)
-				pr_err("Failed to start FLL\n");
+				pr_err("Failed to start FLL: %d\n");

missed 'ret' here? :)

Fixed locally, Liam I'll not bother reposting if you're otherwise OK?

#3 lore raw
Quoted 9 lines · Mark Brown
Quoted 6 lines · Lu Guanqun

sound/soc/samsung/speyside_wm8962.c static int speyside_wm8962_set_bias_level(struct snd_soc_card *card, · line 33

Quoted 3 lines · Mark Brown
sound/soc/samsung/speyside_wm8962.c +1 -1
 			if (ret < 0)
-				pr_err("Failed to start FLL\n");
+				pr_err("Failed to start FLL: %d\n");

missed 'ret' here? :)

Fixed locally, Liam I'll not bother reposting if you're otherwise OK?

I just randomly read the patches and spotted it... Sorry for the noise. :)

Signature · 1 line
guanqun
#4 lore raw
In reply to Mark Brown
Quoted 9 lines · Mark Brown
Quoted 6 lines · Lu Guanqun

sound/soc/samsung/speyside_wm8962.c static int speyside_wm8962_set_bias_level(struct snd_soc_card *card, · line 33

Quoted 3 lines · Mark Brown
sound/soc/samsung/speyside_wm8962.c +1 -1
 			if (ret < 0)
-				pr_err("Failed to start FLL\n");
+				pr_err("Failed to start FLL: %d\n");

missed 'ret' here? :)

Fixed locally, Liam I'll not bother reposting if you're otherwise OK?

I'm OK.

Liam