miiphy: use strcpy() not sprintf()
PATCH 1/1 miiphy: use strcpy() not sprintf()
In miiphy_register() the new device's name was initialised by passing a string parameter as the format string to sprintf(). As this would cause problems if it ever contained a '%' symbol, switch to using strcpy() instead.
--- common/miiphyutil.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
common/miiphyutil.c +1 -1
@@ -141,7 +141,7 @@ void miiphy_register(const char *name,/* initalize mii_dev struct fields */ new_dev->read = legacy_miiphy_read; new_dev->write = legacy_miiphy_write; -sprintf (new_dev->name, name); +strcpy (new_dev->name, name); ldev->read = read; ldev->write = write; new_dev->priv = ldev;
Signature · 1 line
1.7.2.5
PATCH 1/1 miiphy: use strcpy() not sprintf()
Hi Laurence,
Le 14/07/2011 14:31, Laurence Withers a ?crit :
Quoted 4 lines
In
miiphy_register()the new device's name was initialised by passing a string parameter as the format string tosprintf(). As this would cause problems if it ever contained a '%' symbol, switch to usingstrcpy()instead.
Please use strncpy() which will also guard against overflows.
Amicalement,
Signature · 1 line
Albert.
PATCH 1/1 miiphy: use strcpy() not sprintf()
Quoted 7 lines · On Thursday, July 14, 2011 09:49:23 Albert ARIBAUD wrote:
Le 14/07/2011 14:31, Laurence Withers a ?crit :
Quoted 4 lines
In
miiphy_register()the new device's name was initialised by passing a string parameter as the format string tosprintf(). As this would cause problems if it ever contained a '%' symbol, switch to usingstrcpy()instead.Please use
strncpy()which will also guard against overflows.
or BUG_ON(strlen(name) >= MDIO_NAME_LEN)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110714/60a4ff1d/attachment.pgp
PATCH 1/1 miiphy: use strcpy() not sprintf()
Quoted 5 lines · Mike Frysinger
Quoted 1 line · On Thursday, July 14, 2011 09:49:23 Albert ARIBAUD wrote:
Please use
strncpy()which will also guard against overflows.or
BUG_ON(strlen(name) >= MDIO_NAME_LEN)
-mike
Patch v3 has both. The original code did have a check for the name overflowing but BUG_ON() is IMO clearer so I switched to using it instead. I kept strncpy() in v3, rather than just strcpy(), because it makes the code robust against future edits. Thanks for the feedback.
Bye for now,
Signature · 3 lines
Laurence Withers, <[email protected]> http://www.guralp.com/ Direct tel:+447753988197 or tel:+443333408643 Software Engineer General support queries: <[email protected]> CMG-DCM CMG-EAM CMG-NAM