Skip to contentSkip to conversation

drivers:net:Kconfig

PATCH In review wangyanqing 3 participants 4 messages Jul 19, 2011 – Jul 21, 2011 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers:net:Kconfig

Broadcom Tigon3 driver tg3.ko can't work without the Broadcom PHY, so maybe we should add a dependence on it.Or at least we should add notice in the help txt.

---
 drivers/net/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/Kconfig +1 -1
index 93359fa..c2607cd 100644
@@ -2353,7 +2353,7 @@ config VIA_VELOCITY
 
 config TIGON3
 	tristate "Broadcom Tigon3 support"
-	depends on PCI
+	depends on PCI && BROADCOM_PHY
 	select PHYLIB
 	help
 	  This driver supports Broadcom Tigon3 based gigabit Ethernet cards.
Signature · 1 line
1.7.3.4
#1 lore raw
Quoted 4 lines · wangyanqing

Broadcom Tigon3 driver tg3.ko can't work without the Broadcom PHY,
so maybe we should add a dependence on it.Or at least we should add notice in the help txt.

Thats strange.

Here I have a (running) tg3 adapter, but

$ zgrep BROADCOM /proc/config.gz
# CONFIG_BROADCOM_PHY is not set

Could you elaborate ?

#2 lore raw
In reply to wangyanqing
Quoted 7 lines · wangyanqing

Broadcom Tigon3 driver tg3.ko can't work without the Broadcom PHY, so maybe we should add a dependence on it.Or at least we should add notice in the help txt.

---
 drivers/net/Kconfig |    2 +-

Ok, but why in the world would you send this patch to me?

confused,

greg k-h

#3 lore raw
Quoted 9 lines · Greg KH
Quoted 7 lines · wangyanqing

Broadcom Tigon3 driver tg3.ko can't work without the Broadcom PHY, so maybe we should add a dependence on it.Or at least we should add notice in the help txt.

---
 drivers/net/Kconfig |    2 +-
Quoted 5 lines

Ok, but why in the world would you send this patch to me?

confused,

greg k-h

HOHO,I just haven't learn how to use the scripts/get_maintainer.pl, but now I know how to use it. Sorry, man, but you can treat it as a joke!