Skip to contentSkip to conversation

x86, quirks: use pci_dev->revision

PATCH Applied Sergei Shtylyov 2 participants 3 messages Jul 11, 2011 – Jul 22, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86, quirks: use pci_dev->revision

This code uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it wasn't converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65 (PCI: Change all drivers to use pci_device->revision) before being moved to arch/x86/...

---
The patch is against the recent Linus' tree.

 arch/x86/kernel/quirks.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/x86/kernel/quirks.c +2 -3
Index: linux-2.6/arch/x86/kernel/quirks.c
===================================================================
@@ -10,7 +10,7 @@
 
 static void __devinit quirk_intel_irqbalance(struct pci_dev *dev)
 {
-	u8 config, rev;
+	u8 config;
 	u16 word;
 
 	/* BIOS may enable hardware IRQ balancing for
@@ -18,8 +18,7 @@ static void __devinit quirk_intel_irqbal
 	 * based platforms.
 	 * Disable SW irqbalance/affinity on those platforms.
 	 */
-	pci_read_config_byte(dev, PCI_CLASS_REVISION, &rev);
-	if (rev > 0x9)
+	if (dev->revision > 0x9)
 		return;
 
 	/* enable access to config space*/
#1 lore raw

[tip:x86/quirks] x86, quirks: Use pci_dev->revision

Commit-ID:  38175051f8e79c5e9f65daab7200fd8d1fa4a912
Gitweb:     http://git.kernel.org/tip/38175051f8e79c5e9f65daab7200fd8d1fa4a912
Author:     Sergei Shtylyov <[email protected]>
AuthorDate: Mon, 11 Jul 2011 19:01:38 +0400
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 21 Jul 2011 10:26:00 +0200

x86, quirks: Use pci_dev->revision

This code uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it wasn't converted by commit 44c10138fd4bbc ("PCI: Change all drivers to use pci_device->revision") before being moved to arch/x86/...

---
 arch/x86/kernel/quirks.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
arch/x86/kernel/quirks.c +2 -3
index 8bbe8c5..b78643d 100644
@@ -10,7 +10,7 @@
 
 static void __devinit quirk_intel_irqbalance(struct pci_dev *dev)
 {
-	u8 config, rev;
+	u8 config;
 	u16 word;
 
 	/* BIOS may enable hardware IRQ balancing for
@@ -18,8 +18,7 @@ static void __devinit quirk_intel_irqbalance(struct pci_dev *dev)
 	 * based platforms.
 	 * Disable SW irqbalance/affinity on those platforms.
 	 */
-	pci_read_config_byte(dev, PCI_CLASS_REVISION, &rev);
-	if (rev > 0x9)
+	if (dev->revision > 0x9)
 		return;
 
 	/* enable access to config space*/
Applied
#2 lore raw

Re: [tip:x86/quirks] x86, quirks: Use pci_dev->revision

Quoted 7 lines · On Thu, 21 Jul 2011 10:11:42 GMT tip-bot for Sergei Shtylyov…
Commit-ID:  38175051f8e79c5e9f65daab7200fd8d1fa4a912
Gitweb:     http://git.kernel.org/tip/38175051f8e79c5e9f65daab7200fd8d1fa4a912
Author:     Sergei Shtylyov <[email protected]>
AuthorDate: Mon, 11 Jul 2011 19:01:38 +0400
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 21 Jul 2011 10:26:00 +0200
Quoted 5 lines

x86, quirks: Use pci_dev->revision

This code uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it wasn't converted by commit 44c10138fd4bbc ("PCI: Change all drivers to use pci_device->revision") before being moved to arch/x86/...

applied, thanks.

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center