hostap_cs: add ID for LG cards

PATCH Ondrej Zary 2 participants 5 messages Jul 26, 2011 – Jul 28, 2011

Subsystems (2)

Networking drivers (wireless) Pcmcia

lore

Share & tools

lore

Ondrej Zary

author

2011-07-26 21:14 UTC #0 lore raw

Add IDs for LG PCMCIA cards.
This allows LG LW1100P PCI card (with integrated CardBus bridge) to work (tested with rev 3.0) and probably also LW1100N (PCMCIA).

Signed-off-by Ondrej Zary <[email protected]>

drivers/net/wireless/hostap/hostap_cs.c +2 -0

@@ -648,6 +648,8 @@ static struct pcmcia_device_id hostap_cs
 					 0x74c5e40d),
 	PCMCIA_DEVICE_MANF_CARD_PROD_ID1(0x0156, 0x0002, "Intersil",
 					 0x4b801a17),
+	PCMCIA_DEVICE_MANF_CARD_PROD_ID1(0x0156, 0x0002, "LG",
+					 0xb474d43a),
 	PCMCIA_MFC_DEVICE_PROD_ID12(0, "SanDisk", "ConnectPlus",
 				    0x7a954bd9, 0x74be00c6),
 	PCMCIA_DEVICE_PROD_ID123(

Signature · 1 line

Ondrej Zary

Pavel Roskin

Acked-by

2011-07-26 21:54 UTC #1 lore raw

Quoted 5 lines · Ondrej Zary

Add IDs for LG PCMCIA cards.
This allows LG LW1100P PCI card (with integrated CardBus bridge) to work (tested with rev 3.0) and probably also LW1100N (PCMCIA).
Signed-off-by Ondrej Zary<[email protected]>

Acked-by Pavel Roskin <[email protected]>

I googled for the card name and found indications that the card uses Intersil firmware and thus supportable by Hostap.

The problem was reported in year 2003, first in June:
http://osdir.com/ml/linux.drivers.hostap/2003-06/msg00159.html

And then in November:
http://osdir.com/ml/linux.linux-wlan.user/2003-11/msg00039.html

It's quite disappointing that we are fixing this more than 8 years after the first report, when the cards in question have become rare and obsolete. But it's still better than nothing.

drivers/net/wireless/hostap/hostap_cs.c static struct pcmcia_device_id hostap_cs · line 652

Quoted 8 lines

drivers/net/wireless/hostap/hostap_cs.c +2 -0

@@ -648,6 +648,8 @@ static struct pcmcia_device_id hostap_cs
  					 0x74c5e40d),
  	PCMCIA_DEVICE_MANF_CARD_PROD_ID1(0x0156, 0x0002, "Intersil",
  					 0x4b801a17),
+	PCMCIA_DEVICE_MANF_CARD_PROD_ID1(0x0156, 0x0002, "LG",
+					 0xb474d43a),

What is the "pccardctl ident" output on your card?

I think we may want to introduce PCMCIA_DEVICE_MANF_CARD_PROD_ID3 and match

PCMCIA_DEVICE_MANF_CARD_PROD_ID3(0x0156, 0x0002, "Version 1.02", xxx)

Maybe some other card would be supported too? I doubt there are any Agere or Symbol cards with "Version 1.02" in the third text ID.

Signature · 2 lines

Regards,
Pavel Roskin

Ondrej Zary

author

2011-07-27 20:19 UTC #2 lore raw

Quoted 9 lines · On Tuesday 26 July 2011 23:54:37 Pavel Roskin wrote:

Quoted 5 lines · Ondrej Zary
Add IDs for LG PCMCIA cards.
This allows LG LW1100P PCI card (with integrated CardBus bridge) to work (tested with rev 3.0) and probably also LW1100N (PCMCIA).
Signed-off-by Ondrej Zary<[email protected]>
Acked-by Pavel Roskin <[email protected]>

Quoted 8 lines

I googled for the card name and found indications that the card uses Intersil firmware and thus supportable by Hostap.
The problem was reported in year 2003, first in June:
http://osdir.com/ml/linux.drivers.hostap/2003-06/msg00159.html
And then in November:
http://osdir.com/ml/linux.linux-wlan.user/2003-11/msg00039.html

I have the card since 2003 and I was using it back then with HostAP (in managed mode - after much pain with linux-wlan-ng, I was surprised how well HostAP worked). I even flashed the card's firmware using hostap tools multiple times (currently v1.8.4).
But I don't remember if I had to add card's device ID to the driver...probably because PCMCIA configuration was totally different back then.

Quoted 15 lines

It's quite disappointing that we are fixing this more than 8 years after the first report, when the cards in question have become rare and obsolete. But it's still better than nothing.
drivers/net/wireless/hostap/hostap_cs.c static struct pcmcia_device_id hostap_cs · line 652
Quoted 8 lines
drivers/net/wireless/hostap/hostap_cs.c +2 -0
@@ -648,6 +648,8 @@ static struct pcmcia_device_id hostap_cs
  					 0x74c5e40d),
  	PCMCIA_DEVICE_MANF_CARD_PROD_ID1(0x0156, 0x0002, "Intersil",
  					 0x4b801a17),
+	PCMCIA_DEVICE_MANF_CARD_PROD_ID1(0x0156, 0x0002, "LG",
+					 0xb474d43a),
What is the "pccardctl ident" output on your card?

Quoted 6 lines

I think we may want to introduce PCMCIA_DEVICE_MANF_CARD_PROD_ID3 and match
PCMCIA_DEVICE_MANF_CARD_PROD_ID3(0x0156, 0x0002, "Version 1.02", xxx)
Maybe some other card would be supported too? I doubt there are any Agere or Symbol cards with "Version 1.02" in the third text ID.

Yes, that looks good, it would match my card too:
product info: "LG", "11Mbps Wireless LAN PCI Card", "Version 01.02", ""
manfid: 0x0156, 0x0002
function: 6 (network)

---------------------------

Add generic "Version 01.02" match (used by many different cards) to hostap_cs.

This allows LG LW1100P PCI card (with integrated CardBus bridge) to work (tested with rev 3.0) and probably also LW1100N (PCMCIA).

Signed-off-by Ondrej Zary <[email protected]>

include/pcmcia/device_id.h +8 -0

@@ -95,6 +95,14 @@
 	.prod_id = { (v1), NULL, NULL, NULL }, \
 	.prod_id_hash = { (vh1), 0, 0, 0 }, }
 
+#define PCMCIA_DEVICE_MANF_CARD_PROD_ID3(manf, card, v3, vh3) { \
+	.match_flags = PCMCIA_DEV_ID_MATCH_MANF_ID| \
+			PCMCIA_DEV_ID_MATCH_CARD_ID| \
+			PCMCIA_DEV_ID_MATCH_PROD_ID3, \
+	.manf_id = (manf), \
+	.card_id = (card), \
+	.prod_id = { NULL, NULL, (v3), NULL }, \
+	.prod_id_hash = { 0, 0, (vh3), 0 }, }
 
 /* multi-function devices */

drivers/net/wireless/hostap/hostap_cs.c +2 -0

@@ -648,6 +648,8 @@ static struct pcmcia_device_id hostap_cs
 					 0x74c5e40d),
 	PCMCIA_DEVICE_MANF_CARD_PROD_ID1(0x0156, 0x0002, "Intersil",
 					 0x4b801a17),
+	PCMCIA_DEVICE_MANF_CARD_PROD_ID3(0x0156, 0x0002, "Version 01.02",
+					 0x4b74baa0),
 	PCMCIA_MFC_DEVICE_PROD_ID12(0, "SanDisk", "ConnectPlus",
 				    0x7a954bd9, 0x74be00c6),
 	PCMCIA_DEVICE_PROD_ID123(

Signature · 1 line

Ondrej Zary

Pavel Roskin

2011-07-27 22:11 UTC #3 lore raw

Quoted 6 lines · Ondrej Zary

Quoted 4 lines · On Tuesday 26 July 2011 23:54:37 Pavel Roskin wrote:
I think we may want to introduce PCMCIA_DEVICE_MANF_CARD_PROD_ID3 and match
PCMCIA_DEVICE_MANF_CARD_PROD_ID3(0x0156, 0x0002, "Version 1.02", xxx)

Quoted 7 lines

Quoted 2 lines
Maybe some other card would be supported too? I doubt there are any Agere or Symbol cards with "Version 1.02" in the third text ID.
Yes, that looks good, it would match my card too:
product info: "LG", "11Mbps Wireless LAN PCI Card", "Version 01.02", ""
manfid: 0x0156, 0x0002
function: 6 (network)

Good to know.

Quoted 8 lines

---------------------------
Add generic "Version 01.02" match (used by many different cards) to hostap_cs.
This allows LG LW1100P PCI card (with integrated CardBus bridge) to work (tested with rev 3.0) and probably also LW1100N (PCMCIA).
Signed-off-by Ondrej Zary<[email protected]>

That's not the right way to submit patches. Anyway, I sent 3 patches to that effect yesterday. One in for PCMCIA, the second is for hostap_cs and the third is for orinoco_cs to recognize "Version 01.01" as Agere firmware and to stop claiming 0x0156:0x0002 unconditionally.

I have no idea how interdependent series of patches that touch more than one subsystem are applied, but I guess there is a standard way.

Signature · 2 lines

Regards,
Pavel Roskin

Ondrej Zary

author

2011-07-28 08:53 UTC #4 lore raw

Quoted 25 lines · Pavel Roskin

Quoted 6 lines · Ondrej Zary
Quoted 5 lines · On Tuesday 26 July 2011 23:54:37 Pavel Roskin wrote:
I think we may want to introduce PCMCIA_DEVICE_MANF_CARD_PROD_ID3 and match
PCMCIA_DEVICE_MANF_CARD_PROD_ID3(0x0156, 0x0002, "Version 1.02", xxx)
Quoted 7 lines
Quoted 2 lines
Maybe some other card would be supported too? I doubt there are any Agere or Symbol cards with "Version 1.02" in the third text ID.
Yes, that looks good, it would match my card too:
product info: "LG", "11Mbps Wireless LAN PCI Card", "Version 01.02",
"" manfid: 0x0156, 0x0002
function: 6 (network)
Good to know.
Quoted 8 lines
---------------------------
Add generic "Version 01.02" match (used by many different cards) to hostap_cs.
This allows LG LW1100P PCI card (with integrated CardBus bridge) to work (tested with rev 3.0) and probably also LW1100N (PCMCIA).

Quoted 6 lines

Quoted 1 line
Signed-off-by Ondrej Zary<[email protected]>
That's not the right way to submit patches. Anyway, I sent 3 patches to that effect yesterday. One in for PCMCIA, the second is for hostap_cs and the third is for orinoco_cs to recognize "Version 01.01" as Agere firmware and to stop claiming 0x0156:0x0002 unconditionally.

Thanks, I've missed your patches.

Quoted 2 lines

I have no idea how interdependent series of patches that touch more than one subsystem are applied, but I guess there is a standard way.

Signature · 1 line

Ondrej Zary