broken checkpatch signature checking
The signature checking patches in commit 2011247550 have broken one use-case for me. I pipe the git-commits mailing list to it and skim the summary once a day[*]
Because git indents its changelogs, every single commit is now warning with this..
WARNING: Do not use whitespace before Signed-off-by:
#5252:
Dave
[*] It's too noisy to do anything useful with right now, which is
why I'd like to filter out all the whitespace crap, but hopefully that'll happen eventually.
Quoted 11 lines · Dave Jones
The signature checking patches in commit 2011247550 have broken one use-case for me. I pipe the git-commits mailing list to it and skim the summary once a day[*] Because git indents its changelogs, every single commit is now warning with this..
WARNING: Do not use whitespace before Signed-off-by:
#5252:Signed-off-by Linus Torvalds <[email protected]>Dave
[*] It's too noisy to do anything useful with right now, which is
why I'd like to filter out all the whitespace crap, but hopefully that'll happen eventually.
Hey Dave.
Maybe you could use --ignore=BAD_SIGN_OFF for this reviewing?
I think that the general use case is OK.
I'm not sure that it's appropriate to use
checkpatch on git log output.
cheers, Joe
Quoted 9 lines · Joe Perches
Quoted 7 lines · Dave Jones
The signature checking patches in commit 2011247550 have broken one use-case for me. I pipe the git-commits mailing list to it and skim the summary once a day[*] Because git indents its changelogs, every single commit is now warning with this..
WARNING: Do not use whitespace before Signed-off-by:
#5252:Signed-off-by Linus Torvalds <[email protected]>
Quoted 3 lines
Hey Dave.
Maybe you could use --ignore=BAD_SIGN_OFF for this reviewing?
Ok, that works for me. I guess I should add all the whitespace ignores while I'm at it.
thanks,
Dave
Quoted 9 lines · Dave Jones
Quoted 7 lines · Joe Perches
Quoted 5 lines · Dave Jones
The signature checking patches in commit 2011247550 have broken one use-case for me. I pipe the git-commits mailing list to it and skim the summary once a day[*] Because git indents its changelogs, every single commit is now warning with this..
WARNING: Do not use whitespace before Signed-off-by:Maybe you could use --ignore=BAD_SIGN_OFF for this reviewing?
Ok, that works for me. I guess I should add all the whitespace ignores while I'm at it.
or maybe add --ignore-all-space to git log