Skip to contentSkip to conversation

oe style-guide change

RFC Andreas Mueller 2 participants 2 messages Jul 30, 2011

lore
Share & tools
lore
#0 lore raw

Hi,

working on xfce I face a problem with our style-guide (and I think there are other packets affected too e.g gnome recipes?):

In the xfce.bbclass there is a SRC_URI created from recipe name. This fits for 95% of the recipes. Following style-guide [1] I would add patches by writing something like

SRC_URI += "foo.patch"
inherit xfce

Problem is that xfce.bbclass sets SRC_URI with

SRC_URI = ...

Since I want to give recipes the chance to overwrite the suggestion coming from xfce.bbclass ( e.g thunar souce starts with capital letter ) I cannot write something like

SRC_URI =+ ..

in xfce.bbclass.

Therfore I suggest to have the style-guide changed so that we have

inherit ...
SRC_URI
S

What do our gurus think about this?

Andreas

[1] http://wiki.openembedded.org/index.php/Styleguide

#1 lore raw

Dear Andreas,

Am Samstag, den 30.07.2011, 15:10 +0200 schrieb Andreas Mueller:

Quoted 22 lines

working on xfce I face a problem with our style-guide (and I think there are other packets affected too e.g gnome recipes?):

In the xfce.bbclass there is a SRC_URI created from recipe name. This fits for 95% of the recipes. Following style-guide [1] I would add patches by writing something like

SRC_URI += "foo.patch"
inherit xfce

Problem is that xfce.bbclass sets SRC_URI with

SRC_URI = ...

Since I want to give recipes the chance to overwrite the suggestion coming from xfce.bbclass ( e.g thunar souce starts with capital letter ) I cannot write something like

SRC_URI =+ ..

in xfce.bbclass.

Quoted 7 lines

Therfore I suggest to have the style-guide changed so that we have

inherit ...
SRC_URI
S

What do our gurus think about this?

It would be nice to know why the ordering is this way the first place. I do not know that and therefore your proposal sounds reasonable.

In a lot of cases SRC_URI is set in an include file which is than included using require xfce.inc in the very first line.

I do not know when classes are preferred over include files.

Thanks,

Paul

Quoted 1 line

[1] http://wiki.openembedded.org/index.php/Styleguide