Skip to contentSkip to conversation

ARM: SAMSUNG: Fix build of dev- infrastructure for module.h changes

PATCH New Mark Brown 2 participants 3 messages Aug 1, 2011

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ARM: SAMSUNG: Fix build of dev- infrastructure for module.h changes

The recent module.h changes cause a bunch of missing includes in the Samsung dev- infrastructure.

Signed-off-by Mark Brown <[email protected]>
---
 arch/arm/plat-samsung/dev-adc.c       |    2 ++
 arch/arm/plat-samsung/dev-backlight.c |    3 +++
 arch/arm/plat-samsung/dev-ide.c       |    2 ++
 arch/arm/plat-samsung/dev-ts.c        |    2 ++
 arch/arm/plat-samsung/dev-wdt.c       |    3 +++
 arch/arm/plat-samsung/platformdata.c  |    1 +
 6 files changed, 13 insertions(+), 0 deletions(-)
arch/arm/plat-samsung/dev-adc.c +2 -0
index 9d903d4..c7e3257 100644
@@ -13,6 +13,8 @@
 #include <linux/string.h>
 #include <linux/platform_device.h>
 
+#include <asm/sizes.h>
+
 #include <mach/irqs.h>
 #include <mach/map.h>
arch/arm/plat-samsung/dev-backlight.c +3 -0
index 3cedd4c..825a884 100644
@@ -14,6 +14,9 @@
 #include <linux/platform_device.h>
 #include <linux/io.h>
 #include <linux/pwm_backlight.h>
+#include <linux/slab.h>
+
+#include <asm/sizes.h>
 
 #include <plat/devs.h>
 #include <plat/gpio-cfg.h>
arch/arm/plat-samsung/dev-ide.c +2 -0
index b497982..5407574 100644
@@ -14,6 +14,8 @@
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
 
+#include <asm/sizes.h>
+
 #include <mach/map.h>
 #include <plat/ata.h>
 #include <plat/devs.h>
arch/arm/plat-samsung/dev-ts.c +2 -0
index 82543f0..3eede40 100644
@@ -17,6 +17,8 @@
 #include <linux/string.h>
 #include <linux/platform_device.h>
 
+#include <asm/sizes.h>
+
 #include <mach/irqs.h>
 #include <mach/map.h>
arch/arm/plat-samsung/dev-wdt.c +3 -0
index 019b5b8..207a213 100644
@@ -12,6 +12,9 @@
 
 #include <linux/kernel.h>
 #include <linux/platform_device.h>
+#include <linux/module.h>
+
+#include <asm/sizes.h>
 
 #include <mach/irqs.h>
 #include <mach/map.h>
arch/arm/plat-samsung/platformdata.c +1 -0
index 7cf2e1e..f857593 100644
@@ -12,6 +12,7 @@
 #include <linux/kernel.h>
 #include <linux/string.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 
 #include <plat/devs.h>
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 ARM: SAMSUNG: Fix build of dev- infrastructure for module.h changes

Quoted 2 lines · [[PATCH] ARM: SAMSUNG: Fix build of dev- infrastructure for module.h changes]…

The recent module.h changes cause a bunch of missing includes in the Samsung dev- infrastructure.

Thanks, but I've already fixed these just last night when I built each and every one of all the arch/arm/config/* files. So it should be OK now.

I double checked what I did against yours, and I was using the more minimal export.h in dev-wdt.c file. Did I miss something where it really requires all of module.h file?

Thanks,
Paul.

Quoted 93 lines
Signed-off-by Mark Brown <[email protected]>
---
 arch/arm/plat-samsung/dev-adc.c       |    2 ++
 arch/arm/plat-samsung/dev-backlight.c |    3 +++
 arch/arm/plat-samsung/dev-ide.c       |    2 ++
 arch/arm/plat-samsung/dev-ts.c        |    2 ++
 arch/arm/plat-samsung/dev-wdt.c       |    3 +++
 arch/arm/plat-samsung/platformdata.c  |    1 +
 6 files changed, 13 insertions(+), 0 deletions(-)
arch/arm/plat-samsung/dev-adc.c +2 -0
index 9d903d4..c7e3257 100644
@@ -13,6 +13,8 @@
 #include <linux/string.h>
 #include <linux/platform_device.h>
 
+#include <asm/sizes.h>
+
 #include <mach/irqs.h>
 #include <mach/map.h>
arch/arm/plat-samsung/dev-backlight.c +3 -0
index 3cedd4c..825a884 100644
@@ -14,6 +14,9 @@
 #include <linux/platform_device.h>
 #include <linux/io.h>
 #include <linux/pwm_backlight.h>
+#include <linux/slab.h>
+
+#include <asm/sizes.h>
 
 #include <plat/devs.h>
 #include <plat/gpio-cfg.h>
arch/arm/plat-samsung/dev-ide.c +2 -0
index b497982..5407574 100644
@@ -14,6 +14,8 @@
 #include <linux/interrupt.h>
 #include <linux/platform_device.h>
 
+#include <asm/sizes.h>
+
 #include <mach/map.h>
 #include <plat/ata.h>
 #include <plat/devs.h>
arch/arm/plat-samsung/dev-ts.c +2 -0
index 82543f0..3eede40 100644
@@ -17,6 +17,8 @@
 #include <linux/string.h>
 #include <linux/platform_device.h>
 
+#include <asm/sizes.h>
+
 #include <mach/irqs.h>
 #include <mach/map.h>
arch/arm/plat-samsung/dev-wdt.c +3 -0
index 019b5b8..207a213 100644
@@ -12,6 +12,9 @@
 
 #include <linux/kernel.h>
 #include <linux/platform_device.h>
+#include <linux/module.h>
+
+#include <asm/sizes.h>
 
 #include <mach/irqs.h>
 #include <mach/map.h>
arch/arm/plat-samsung/platformdata.c +1 -0
index 7cf2e1e..f857593 100644
@@ -12,6 +12,7 @@
 #include <linux/kernel.h>
 #include <linux/string.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 
 #include <plat/devs.h>
Signature · 1 line
1.7.5.4
author
#2 lore raw

PATCH 1/1 ARM: SAMSUNG: Fix build of dev- infrastructure for module.h changes

Quoted 3 lines · Paul Gortmaker

I double checked what I did against yours, and I was using the more minimal export.h in dev-wdt.c file. Did I miss something where it really requires all of module.h file?

I don't know, my only interest at the time was in fixing the build for my primary development platform after it broke suddenly during the merge window. Like I said yesterday the first I knew about any changes in module.h was when Dave Jones mentioned it in response to my fix for cpufreq, I had assumed it was an ARM-specific change.