Skip to contentSkip to conversation

linux-next: build failure after merge of the pci-current tree

PATCH New Stephen Rothwell 3 participants 4 messages Aug 2, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Jesse,

After merging the pci-current tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:

ERROR: ".pcie_bus_configure_settings" [drivers/pci/hotplug/pci_hotplug.ko] undefined!

Caused by commit b03e7495a862 ("PCI: Set PCI-E Max Payload Size on fabric"). Missing EXPORT_SYMBOL?

I have used the pci-current tree from next-20110801 for today.

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#1 lore raw

Hi Jesse,

Quoted 10 lines · On Tue, 2 Aug 2011 10:48:38 +1000 Stephen Rothwell <[email protected]> wrote:

After merging the pci-current tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:

ERROR: ".pcie_bus_configure_settings" [drivers/pci/hotplug/pci_hotplug.ko] undefined!

Caused by commit b03e7495a862 ("PCI: Set PCI-E Max Payload Size on fabric"). Missing EXPORT_SYMBOL?

I have used the pci-current tree from next-20110801 for today.

And the same for the pci tree (which is identical today).

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#2 lore raw

PATCH 1/1 PCI: export pcie_bus_configure_settings symbol

pcie_bus_configure_settings needs to be exported if the PCI hotplug driver is being compiled as a module.

Discovered by Stephen Rothwell

---
 drivers/pci/probe.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/pci/probe.c +1 -0
index 5becf7c..8473727 100644
@@ -1470,6 +1470,7 @@ void pcie_bus_configure_settings(struct pci_bus *bus, u8 mpss)
 	pcie_bus_configure_set(bus->self, &smpss);
 	pci_walk_bus(bus, pcie_bus_configure_set, &smpss);
 }
+EXPORT_SYMBOL_GPL(pcie_bus_configure_settings);
 
 unsigned int __devinit pci_scan_child_bus(struct pci_bus *bus)
 {
Signature · 1 line
1.7.6
#3 lore raw
In reply to Stephen Rothwell
Quoted 7 lines · On Tue, 2 Aug 2011 11:23:36 +1000 Stephen Rothwell <[email protected]> wrote:

Hi Jesse,

Quoted 4 lines · On Tue, 2 Aug 2011 10:48:38 +1000 Stephen Rothwell <[email protected]> wrote:

After merging the pci-current tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:

Quoted 8 lines
Quoted 6 lines

ERROR: ".pcie_bus_configure_settings" [drivers/pci/hotplug/pci_hotplug.ko] undefined!

Caused by commit b03e7495a862 ("PCI: Set PCI-E Max Payload Size on fabric"). Missing EXPORT_SYMBOL?

I have used the pci-current tree from next-20110801 for today.

And the same for the pci tree (which is identical today).

Jon just sent me the fix and I pushed it out. Should be fixed now.

Thanks,

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center