Adding Fluxbox window manager

PATCH New Frederic Bassaler 3 participants 5 messages Aug 2, 2011 – Aug 3, 2011

lore

Share & tools

lore

Frederic Bassaler

author

2011-08-02 17:10 UTC #0 lore raw

PATCH 1/1 Adding Fluxbox window manager

Hope this is ok, sorry I'm a git-newbie

(if it's not good, can somebody tell me the proper git commands? thanks)

---
 package/Config.in          |    1 +
 package/fluxbox/Config.in  |   13 +++++++++++++
 package/fluxbox/fluxbox.mk |   23 +++++++++++++++++++++++
 3 files changed, 37 insertions(+), 0 deletions(-)
 create mode 100644 package/fluxbox/Config.in
 create mode 100644 package/fluxbox/fluxbox.mk

package/Config.in +1 -0

index 7112e05..c4cecfa 100644
@@ -127,6 +127,7 @@ comment "X Window managers"
 source "package/matchbox/Config.in"
 source "package/metacity/Config.in"
 source "package/blackbox/Config.in"
+source "package/fluxbox/Config.in"
 
 comment "X applications"
 source "package/alsamixergui/Config.in"

package/fluxbox/Config.in new file +13 -0

new file mode 100644
index 0000000..63840b2
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_FLUXBOX
+	bool "fluxbox"
+        depends on BR2_PACKAGE_XORG7
+        depends on BR2_INSTALL_LIBSTDCPP
+        select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
+        select BR2_PACKAGE_XLIB_LIBX11
+  	help
+	  The Fluxbox lightweight window manager for X
+
+	  http://fluxbox.org
+
+comment "fluxbox requires a toolchain with C++ support enabled"
+        depends on BR2_PACKAGE_XORG7 && !BR2_INSTALL_LIBSTDCPP

package/fluxbox/fluxbox.mk new file +23 -0

new file mode 100644
index 0000000..726a133
@@ -0,0 +1,23 @@
+#############################################################
+#
+# FLUXBOX
+#
+#############################################################
+
+FLUXBOX_VERSION:=1.3.1
+FLUXBOX_SOURCE:=fluxbox-$(FLUXBOX_VERSION).tar.bz2
+FLUXBOX_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/fluxbox/
+FLUXBOX_AUTORECONF:=NO
+FLUXBOX_INSTALL_STAGING:=NO
+FLUXBOX_INSTALL_TARGET:=YES
+
+FLUXBOX_CONF_OPT:=--x-includes=$(STAGING_DIR)/usr/include/X11 \
+		--x-libraries=$(STAGING_DIR)/usr/lib
+
+FLUXBOX_DEPENDENCIES = xlib_libX11
+
+ifneq ($(BR2_ENABLE_LOCALE),y)
+FLUXBOX_DEPENDENCIES += libiconv
+endif
+
+$(eval $(call AUTOTARGETS,package,fluxbox))

Signature · 1 line

1.7.2.3

Thomas Petazzoni

2011-08-02 18:44 UTC #1 lore raw

PATCH 1/1 Adding Fluxbox window manager

Hello,

Le Tue, 2 Aug 2011 19:10:04 +0200,
Frederic Bassaler <[email protected]> a ?crit :

Quoted 4 lines

Hope this is ok, sorry I'm a git-newbie
(if it's not good, can somebody tell me the proper git commands? thanks)

This should be a proper patch description, as it will end up in the commit log. You must also add a Signed-off-by line.

Quoted 4 lines

package/fluxbox/Config.in new file +3 -0

@@ -0,0 +1,13 @@
+config BR2_PACKAGE_FLUXBOX
+	bool "fluxbox"
+        depends on BR2_PACKAGE_XORG7

package/fluxbox/Config.in line 13

Quoted 10 lines

package/fluxbox/Config.in new file +10 -0

+        depends on BR2_INSTALL_LIBSTDCPP
+        select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
+        select BR2_PACKAGE_XLIB_LIBX11
+  	help
+	  The Fluxbox lightweight window manager for X
+
+	  http://fluxbox.org
+
+comment "fluxbox requires a toolchain with C++ support enabled"
+        depends on BR2_PACKAGE_XORG7 && !BR2_INSTALL_LIBSTDCPP

"bool", "depends on", "select" must be prefixed by a tab, not spaces. The help text must be indented with one tab + 2 spaces.

Quoted 6 lines

package/fluxbox/fluxbox.mk new file +0 -0
new file mode 100644
index 0000000..726a133

package/fluxbox/fluxbox.mk line 9

Quoted 9 lines

package/fluxbox/fluxbox.mk new file +9 -0

@@ -0,0 +1,23 @@
+#############################################################
+#
+# FLUXBOX
+#
+#############################################################
+
+FLUXBOX_VERSION:=1.3.1
+FLUXBOX_SOURCE:=fluxbox-$(FLUXBOX_VERSION).tar.bz2
+FLUXBOX_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/fluxbox/

Please use = instead of :=.

package/fluxbox/fluxbox.mk line 12

Quoted 3 lines

package/fluxbox/fluxbox.mk new file +3 -0

+FLUXBOX_AUTORECONF:=NO
+FLUXBOX_INSTALL_STAGING:=NO
+FLUXBOX_INSTALL_TARGET:=YES

Not needed, those are the default values.

package/fluxbox/fluxbox.mk line 17

Quoted 4 lines

package/fluxbox/fluxbox.mk new file +4 -0

+FLUXBOX_CONF_OPT:=--x-includes=$(STAGING_DIR)/usr/include/X11 \
+		--x-libraries=$(STAGING_DIR)/usr/lib
+
+FLUXBOX_DEPENDENCIES = xlib_libX11

This doesn't really match the dependencies expressed in the Config.in file, but it's true that our dependencies on X.org stuff are a bit broken today (all client applications depend on the server, which is not correct from a build point of view).

For the time being, I guess this will be fine, until we find the time to clean up those dependencies.

package/fluxbox/fluxbox.mk line 23

Quoted 5 lines

package/fluxbox/fluxbox.mk new file +5 -0

+ifneq ($(BR2_ENABLE_LOCALE),y)
+FLUXBOX_DEPENDENCIES += libiconv
+endif
+
+$(eval $(call AUTOTARGETS,package,fluxbox))

Regards,

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Thomas De Schampheleire

2011-08-03 07:46 UTC #2 lore raw

PATCH 1/1 Adding Fluxbox window manager

Hi,

Quoted 40 lines · Thomas Petazzoni

Hello,
Le Tue, 2 Aug 2011 19:10:04 +0200,
Frederic Bassaler <[email protected]> a ?crit :
Quoted 4 lines
Hope this is ok, sorry I'm a git-newbie
(if it's not good, can somebody tell me the proper git commands? thanks)
This should be a proper patch description, as it will end up in the commit log. You must also add a Signed-off-by line.
Quoted 4 lines
(quoted diff) +3 -0
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_FLUXBOX
+ ? ? bool "fluxbox"
+ ? ? ? ?depends on BR2_PACKAGE_XORG7
Review line 13
Quoted 10 lines
(quoted diff) +10 -0
+ ? ? ? ?depends on BR2_INSTALL_LIBSTDCPP
+ ? ? ? ?select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
+ ? ? ? ?select BR2_PACKAGE_XLIB_LIBX11
+ ? ? help
+ ? ? ? The Fluxbox lightweight window manager for X
+
+ ? ? ? http://fluxbox.org
+
+comment "fluxbox requires a toolchain with C++ support enabled"
+ ? ? ? ?depends on BR2_PACKAGE_XORG7 && !BR2_INSTALL_LIBSTDCPP
"bool", "depends on", "select" must be prefixed by a tab, not spaces. The help text must be indented with one tab + 2 spaces.
Quoted 9 lines
package/fluxbox/fluxbox.mk new file +3 -0
new file mode 100644
index 0000000..726a133
@@ -0,0 +1,23 @@
+#############################################################
+#
+# FLUXBOX

Quoted 8 lines

package/fluxbox/fluxbox.mk line 9
Quoted 6 lines
package/fluxbox/fluxbox.mk new file +6 -0
+#
+#############################################################
+
+FLUXBOX_VERSION:=1.3.1
+FLUXBOX_SOURCE:=fluxbox-$(FLUXBOX_VERSION).tar.bz2
+FLUXBOX_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/fluxbox/
Please use = instead of :=.

Just curious: why do you recommend against := ?
For example in the case of FLUXBOX_SOURCE, using := would avoid unnecessary expansions of $(FLUXBOX_VERSION), each time FLUXBOX_SOURCE is used.
For FLUXBOX_SITE it depends on whether BR2_SOURCEFORGE_MIRROR is already defined or not, but I think it has, right?

Quoted 38 lines

package/fluxbox/fluxbox.mk line 12
Quoted 4 lines
package/fluxbox/fluxbox.mk new file +3 -0
+FLUXBOX_AUTORECONF:=NO
+FLUXBOX_INSTALL_STAGING:=NO
+FLUXBOX_INSTALL_TARGET:=YES
Not needed, those are the default values.
package/fluxbox/fluxbox.mk line 17
Quoted 4 lines
package/fluxbox/fluxbox.mk new file +4 -0
+FLUXBOX_CONF_OPT:=--x-includes=$(STAGING_DIR)/usr/include/X11 \
+ ? ? ? ? ? ? --x-libraries=$(STAGING_DIR)/usr/lib
+
+FLUXBOX_DEPENDENCIES = xlib_libX11
This doesn't really match the dependencies expressed in the Config.in file, but it's true that our dependencies on X.org stuff are a bit broken today (all client applications depend on the server, which is not correct from a build point of view).
For the time being, I guess this will be fine, until we find the time to clean up those dependencies.
package/fluxbox/fluxbox.mk line 23
Quoted 5 lines
package/fluxbox/fluxbox.mk new file +5 -0
+ifneq ($(BR2_ENABLE_LOCALE),y)
+FLUXBOX_DEPENDENCIES += libiconv
+endif
+
+$(eval $(call AUTOTARGETS,package,fluxbox))
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Thomas Petazzoni

2011-08-03 07:56 UTC #3 lore raw

PATCH 1/1 Adding Fluxbox window manager

Le Wed, 3 Aug 2011 09:46:16 +0200,
Thomas De Schampheleire <[email protected]> a ?crit :

Quoted 6 lines

Quoted 5 lines
package/fluxbox/fluxbox.mk line 9
Quoted 3 lines
package/fluxbox/fluxbox.mk new file +3 -0
+FLUXBOX_VERSION:=1.3.1
+FLUXBOX_SOURCE:=fluxbox-$(FLUXBOX_VERSION).tar.bz2
+FLUXBOX_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/fluxbox/
Please use = instead of :=.

Quoted 6 lines

Just curious: why do you recommend against := ?
For example in the case of FLUXBOX_SOURCE, using := would avoid unnecessary expansions of $(FLUXBOX_VERSION), each time FLUXBOX_SOURCE is used.
For FLUXBOX_SITE it depends on whether BR2_SOURCEFORGE_MIRROR is already defined or not, but I think it has, right?

Peter Korsgaard said:

""""
:= is only a performance advantage if variables are expensive to expand (use) and are used more than once - E.G. stuff involving $(shell) and similar, like the UPPERCASE macro we had calling tr.

= has a number of advantages though. As it only gets expanded at the last possible moment you don't have to take care about variable ordering, E.G. when you use a variable like LIBGLIB2_HOST_BINARY on another package, whereas with := you do. This can also be interesting when the variable contains $(shell) or other functions, as you might only want to execute them if/when they are needed, and not right away when the Makefiles are parsed.

I would prefer to use = by default, and only use := where it matters for correctness or performance.
""""

See:

Subject: Re: [Buildroot] [PATCH 07/28] barebox: use = instead of := and re-indent
Date: Tue, 05 Jul 2011 23:04:58 +0200
Message-ID: <[email protected]>

Regards,

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Thomas De Schampheleire

2011-08-03 08:03 UTC #4 lore raw

PATCH 1/1 Adding Fluxbox window manager

Quoted 35 lines · Thomas Petazzoni

Le Wed, 3 Aug 2011 09:46:16 +0200,
Thomas De Schampheleire <[email protected]> a ?crit :
Quoted 6 lines
Quoted 5 lines
package/fluxbox/fluxbox.mk line 9
Quoted 3 lines
package/fluxbox/fluxbox.mk new file +3 -0
+FLUXBOX_VERSION:=1.3.1
+FLUXBOX_SOURCE:=fluxbox-$(FLUXBOX_VERSION).tar.bz2
+FLUXBOX_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/fluxbox/
Please use = instead of :=.
Quoted 6 lines
Just curious: why do you recommend against := ?
For example in the case of FLUXBOX_SOURCE, using := would avoid unnecessary expansions of $(FLUXBOX_VERSION), each time FLUXBOX_SOURCE is used.
For FLUXBOX_SITE it depends on whether BR2_SOURCEFORGE_MIRROR is already defined or not, but I think it has, right?
Peter Korsgaard said:
""""
:= is only a performance advantage if variables are expensive to expand (use) and are used more than once - E.G. stuff involving $(shell) and similar, like the UPPERCASE macro we had calling tr.
= has a number of advantages though. As it only gets expanded at the last possible moment you don't have to take care about variable ordering, E.G. when you use a variable like LIBGLIB2_HOST_BINARY on another package, whereas with := you do. This can also be interesting when the variable contains $(shell) or other functions, as you might only want to execute them if/when they are needed, and not right away when the Makefiles are parsed.
I would prefer to use = by default, and only use := where it matters for correctness or performance.
""""

Quoted 5 lines

See:
Subject: Re: [Buildroot] [PATCH 07/28] barebox: use = instead of := and re-indent
Date: Tue, 05 Jul 2011 23:04:58 +0200
Message-ID: <[email protected]>

Ok, thanks.
Thomas

Quoted 10 lines

Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com