Skip to contentSkip to conversation

BUG: pty.c in linux 2.6.31-rc5+

PATCH MRU.Ilya 2 participants 2 messages Aug 4, 2011

lore
Share & tools
lore

MRU.Ilya

author
#0 lore raw

Synchronic's line disciplines(ppp_synctty, hdlc) can't work with pseudo terminals.

If frames send very fast from one side(master/slave) to other one,
frames merge in one (merge point "flip buffer") and the other side can read only one big frame. But sync line discipline need one frame in one read.

For push one frame to ldisc I propose small patch, but this regression for commit e043e42bdb66885b3ac10d27a01ccb9972e2b0a3.

I don't find any mutexes and other things forbidden in not user context, in function flush_to_ldisc() , and I think this patch
is true and this function can called from any context. But I not sure.

Relative commit 86d23a057e718f73adc15e463c643d6e014a19cd.

pty.c +1 -0
@@ -204,6 +204,7 @@
 	clear_bit(TTY_OTHER_CLOSED, &tty->link->flags);
 	set_bit(TTY_THROTTLED, &tty->flags);
 	retval = 0;
+	tty->low_latency = 1;
 out:
 	return retval;
 }
#1 lore raw
Quoted 22 lines · MRU.Ilya

Synchronic's line disciplines(ppp_synctty, hdlc) can't work with pseudo terminals.

If frames send very fast from one side(master/slave) to other one, frames merge in one (merge point "flip buffer") and the other side can read only one big frame.
But sync line discipline need one frame in one read.

For push one frame to ldisc I propose small patch, but this regression for commit e043e42bdb66885b3ac10d27a01ccb9972e2b0a3.

I don't find any mutexes and other things forbidden in not user context, in function flush_to_ldisc() , and I think this patch
is true and this function can called from any context. But I not sure.

Relative commit 86d23a057e718f73adc15e463c643d6e014a19cd.

pty.c line 207

Quoted 4 lines
pty.c +1 -0
@@ -204,6 +204,7 @@
 	clear_bit(TTY_OTHER_CLOSED, &tty->link->flags);
 	set_bit(TTY_THROTTLED, &tty->flags);
 	retval = 0;
+	tty->low_latency = 1;

I really don't think this is correct.

Also, you forgot to read Documentation/SubmittingPatches for how to properly format and send a patch and who to send it to...

thanks,

greg k-h