libertas: remove some dead code in
Subsystems (2)
PATCH 1/1 libertas: remove some dead code in
We always hit the goto and skip the printk(). The original code does the right thing even though it looks messy.
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/wireless/libertas/if_spi.c +0 -4
@@ -531,10 +531,6 @@ static int if_spi_prog_helper_firmware(struct if_spi_card *card, goto out; err =spu_write_u16 (card,IF_SPI_CARD_INT_CAUSE_REG ,IF_SPI_CIC_CMD_DOWNLOAD_OVER ); - goto out; - -lbs_deb_spi ("waiting for helper to boot...\n" ); - out:if (err)pr_err ("failed to load helper firmware (err=%d)\n" , err);
Quoted 4 lines · Dan Carpenter
We always hit the goto and skip the
printk(). The original code does the right thing even though it looks messy.Signed-off-by Dan Carpenter <[email protected]>
Acked-by Dan Williams <[email protected]>
Quoted 16 lines
drivers/net/wireless/libertas/if_spi.c +0
-4@@ -531,10 +531,6 @@ static int if_spi_prog_helper_firmware(struct if_spi_card *card, goto out; err =spu_write_u16 (card,IF_SPI_CARD_INT_CAUSE_REG ,IF_SPI_CIC_CMD_DOWNLOAD_OVER ); - goto out; - -lbs_deb_spi ("waiting for helper to boot...\n" ); - out:if (err)pr_err ("failed to load helper firmware (err=%d)\n" , err);