Skip to contentSkip to conversation

libertas: remove some dead code in

PATCH In review Dan Carpenter 2 participants 2 messages Aug 6, 2011 – Aug 15, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libertas: remove some dead code in

We always hit the goto and skip the printk(). The original code does the right thing even though it looks messy.

drivers/net/wireless/libertas/if_spi.c +0 -4
index e0286cf..622ae6d 100644
@@ -531,10 +531,6 @@ static int if_spi_prog_helper_firmware(struct if_spi_card *card,
 		goto out;
 	err = spu_write_u16(card, IF_SPI_CARD_INT_CAUSE_REG,
 				IF_SPI_CIC_CMD_DOWNLOAD_OVER);
-		goto out;
-
-	lbs_deb_spi("waiting for helper to boot...\n");
-
 out:
 	if (err)
 		pr_err("failed to load helper firmware (err=%d)\n", err);
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Dan Carpenter

We always hit the goto and skip the printk(). The original code does the right thing even though it looks messy.

Quoted 16 lines
drivers/net/wireless/libertas/if_spi.c +0 -4
index e0286cf..622ae6d 100644
@@ -531,10 +531,6 @@ static int if_spi_prog_helper_firmware(struct if_spi_card *card,
 		goto out;
 	err = spu_write_u16(card, IF_SPI_CARD_INT_CAUSE_REG,
 				IF_SPI_CIC_CMD_DOWNLOAD_OVER);
-		goto out;
-
-	lbs_deb_spi("waiting for helper to boot...\n");
-
 out:
 	if (err)
 		pr_err("failed to load helper firmware (err=%d)\n", err);