Skip to contentSkip to conversation

proc: Introduce the Children: line in /proc/<pid>/status

PATCH In review Cyrill Gorcunov 3 participants 3 messages Aug 7, 2011 – Aug 8, 2011 Proc filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 3/4 proc: Introduce the Children: line in /proc/<pid>/status

From: Pavel Emelyanov <[email protected]>

Although we can get the pids of some task's issue, this is just more convenient to have them this way.

---
 fs/proc/array.c |   14 ++++++++++++++
 1 file changed, 14 insertions(+)
fs/proc/array.c +14 -0
Index: linux-2.6.git/fs/proc/array.c
===================================================================
@@ -158,6 +158,18 @@ static inline const char *get_task_state
 	return *p;
 }
 
+static void task_children(struct seq_file *m, struct task_struct *p, struct pid_namespace *ns)
+{
+	struct task_struct *c;
+
+	seq_printf(m, "Children:");
+	read_lock(&tasklist_lock);
+	list_for_each_entry(c, &p->children, sibling)
+		seq_printf(m, " %d", pid_nr_ns(task_pid(c), ns));
+	read_unlock(&tasklist_lock);
+	seq_putc(m, '\n');
+}
+
 static inline void task_state(struct seq_file *m, struct pid_namespace *ns,
 				struct pid *pid, struct task_struct *p)
 {
@@ -192,6 +204,8 @@ static inline void task_state(struct seq
 		cred->uid, cred->euid, cred->suid, cred->fsuid,
 		cred->gid, cred->egid, cred->sgid, cred->fsgid);
 
+	task_children(m, p, ns);
+
 	task_lock(p);
 	if (p->files)
 		fdt = files_fdtable(p->files);
#2 lore raw
Quoted 6 lines · Tejun Heo
Quoted 5 lines · Cyrill Gorcunov

From: Pavel Emelyanov <[email protected]>

Although we can get the pids of some task's issue, this is just more convenient to have them this way.

Quoted 6 lines
Quoted 3 lines

I'm not necessarily against this one but don't really see much point either. Can we delay this for now?

Sure we can. As I stated previously this one just makes our live easier, but we can live without one.

Quoted 2 lines

Thanks.