PCnet: Fix section mismatch
Subsystems (3)
PATCH 1/1 PCnet: Fix section mismatch
Building MIPS mtx1_defconfig results in:
MODPOST 735 modules
WARNING: drivers/net/pcnet32.o(.devinit.text+0x11ec): Section mismatch in reference from the function pcnet32_probe_vlbus.constprop.22() to the variable .init.data:pcnet32_portlist The function __devinit pcnet32_probe_vlbus.constprop.22() references
a variable __initdata pcnet32_portlist.
If pcnet32_portlist is only used by pcnet32_probe_vlbus.constprop.22 then
annotate pcnet32_portlist with a matching annotation.
---
As recently discussed in the discussion of submission of a fix for a similar bug in another driver remove __initdata rather than replace it with __devinitdata.
drivers/net/pcnet32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/pcnet32.c +1 -1
@@ -82,7 +82,7 @@ static int cards_found;/* * VLB I/O addresses */ -static unsigned int pcnet32_portlist[]__initdata = +static unsigned int pcnet32_portlist[] = {0x300 ,0x320 ,0x340 ,0x360 ,0 };static int pcnet32_debug;
From: Ralf Baechle <[email protected]>
Date: Wed, 10 Aug 2011 16:23:46 +0100
Quoted 10 lines
Building MIPS
mtx1_defconfigresults in:MODPOST 735 modules
WARNING: drivers/net/pcnet32.o(.devinit.text+0x11ec): Section mismatch in reference from the function pcnet32_probe_vlbus.constprop.22() to the variable .init.data:pcnet32_portlist The function__devinitpcnet32_probe_vlbus.constprop.22() references
a variable__initdatapcnet32_portlist.
Ifpcnet32_portlistis only used by pcnet32_probe_vlbus.constprop.22 then
annotatepcnet32_portlistwith a matching annotation.Signed-off-by Ralf Baechle <[email protected]>
Applied, thanks Ralf.