EDAC: Correct Kconfig dependencies

DISCUSSION Dave Jones 2 participants 2 messages Aug 10, 2011 1 message not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

author

2011-08-10 22:38 UTC #1 lore raw

Quoted 10 lines · Linux Kernel

Gitweb:     http://git.kernel.org/linus/af9d220bac41dc3201893e1601cc7c44f7da4498
Commit:     af9d220bac41dc3201893e1601cc7c44f7da4498
Parent:     f2c0d0266cc5eb36a4aa44944b4096ec121490aa
Author:     Borislav Petkov <[email protected]>
AuthorDate: Wed Aug 10 14:43:30 2011 +0200
Committer:  Linus Torvalds <[email protected]>
CommitDate: Wed Aug 10 10:57:42 2011 -0700

EDAC: Correct Kconfig dependencies

Quoted 8 lines

Both AMD and Intel i7 EDAC drivers use MCE features and are thus dependent of this functionality present in the kernel. Express this in Kconfig so that randconfig builds don't break.
Reported-by Randy Dunlap <[email protected]>
Signed-off-by Borislav Petkov <[email protected]>
Acked-by Randy Dunlap <[email protected]>
Signed-off-by Linus Torvalds <[email protected]>

This commit broke the build for me..

drivers/edac/i7core_edac.c:259:18: error: field ‘edac_mce’ has incomplete type
drivers/edac/i7core_edac.c:262:23: error: ‘MCE_LOG_LEN’ undeclared here (not in a function) drivers/edac/i7core_edac.c: In function ‘i7core_mce_output_error’:
drivers/edac/i7core_edac.c:1671:25: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1672:20: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1673:23: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1674:15: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1675:18: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1676:18: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1680:7: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1742:22: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1742:31: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1743:39: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1744:15: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1751:7: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c: In function ‘i7core_check_error’:
drivers/edac/i7core_edac.c:1787:50: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1791:3: error: invalid use of undefined type ‘struct mce’ drivers/edac/i7core_edac.c:1793:49: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c: In function ‘i7core_mce_check_error’:
drivers/edac/i7core_edac.c:1838:11: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1842:9: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1847:293: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1859:52: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1864:9: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c: In function ‘i7core_unregister_mci’:
drivers/edac/i7core_edac.c:1910:2: error: implicit declaration of function ‘edac_mce_unregister’ [-Werror=implicit-function-declaration] drivers/edac/i7core_edac.c: In function ‘i7core_register_mci’:
drivers/edac/i7core_edac.c:2008:2: error: implicit declaration of function ‘edac_mce_register’ [-Werror=implicit-function-declaration]

it needs at least to include asm/mce.h for all the missing types, but the bigger problem is that CONFIG_EDAC_MCE not being select'd means that we never build edac_mce.o (it's an unselectable bool in drivers/edac/Kconfig)

Dave

Randy Dunlap

2011-08-10 23:35 UTC #2 lore raw

Quoted 52 lines · On Wed, 10 Aug 2011 18:38:16 -0400 Dave Jones wrote:

Quoted 10 lines · Linux Kernel
Gitweb:     http://git.kernel.org/linus/af9d220bac41dc3201893e1601cc7c44f7da4498
Commit:     af9d220bac41dc3201893e1601cc7c44f7da4498
Parent:     f2c0d0266cc5eb36a4aa44944b4096ec121490aa
Author:     Borislav Petkov <[email protected]>
AuthorDate: Wed Aug 10 14:43:30 2011 +0200
Committer:  Linus Torvalds <[email protected]>
CommitDate: Wed Aug 10 10:57:42 2011 -0700
EDAC: Correct Kconfig dependencies
Quoted 8 lines
Both AMD and Intel i7 EDAC drivers use MCE features and are thus dependent of this functionality present in the kernel. Express this in Kconfig so that randconfig builds don't break.
Reported-by Randy Dunlap <[email protected]>
Signed-off-by Borislav Petkov <[email protected]>
Acked-by Randy Dunlap <[email protected]>
Signed-off-by Linus Torvalds <[email protected]>
This commit broke the build for me..
drivers/edac/i7core_edac.c:259:18: error: field ‘edac_mce’ has incomplete type
drivers/edac/i7core_edac.c:262:23: error: ‘MCE_LOG_LEN’ undeclared here (not in a function) drivers/edac/i7core_edac.c: In function ‘i7core_mce_output_error’:
drivers/edac/i7core_edac.c:1671:25: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1672:20: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1673:23: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1674:15: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1675:18: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1676:18: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1680:7: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1742:22: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1742:31: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1743:39: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1744:15: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1751:7: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c: In function ‘i7core_check_error’:
drivers/edac/i7core_edac.c:1787:50: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1791:3: error: invalid use of undefined type ‘struct mce’ drivers/edac/i7core_edac.c:1793:49: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c: In function ‘i7core_mce_check_error’:
drivers/edac/i7core_edac.c:1838:11: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1842:9: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1847:293: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1859:52: error: dereferencing pointer to incomplete type drivers/edac/i7core_edac.c:1864:9: error: dereferencing pointer to incomplete type
drivers/edac/i7core_edac.c: In function ‘i7core_unregister_mci’:
drivers/edac/i7core_edac.c:1910:2: error: implicit declaration of function ‘edac_mce_unregister’ [-Werror=implicit-function-declaration] drivers/edac/i7core_edac.c: In function ‘i7core_register_mci’:
drivers/edac/i7core_edac.c:2008:2: error: implicit declaration of function ‘edac_mce_register’ [-Werror=implicit-function-declaration]

Quoted 3 lines

it needs at least to include asm/mce.h for all the missing types, but the bigger problem is that CONFIG_EDAC_MCE not being select'd means that we never build edac_mce.o (it's an unselectable bool in drivers/edac/Kconfig)

I mistakenly reported this as a linux 3.1-rc1 build error when in fact it was a linux-next build error, as Borislav pointed out.

Borislav, did you mean for this patch to be applied to mainline or are there also patches in linux-next that are needed for mainline with this one?

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***