misc/pti.c: Fix build error when PCI is not selected

PATCH In review Tracey Dent 4 participants 8 messages Aug 11, 2011 – Aug 19, 2011 Char and misc drivers

lore

Share & tools

lore

Tracey Dent

author

2011-08-11 16:23 UTC #0 lore raw

PATCH 1/1 misc/pti.c: Fix build error when PCI is not selected

When you try to build INTEL_MID_PTI without having PCI enabled. It fails like this-

CC [M] drivers/misc/pti.o
drivers/misc/pti.c: In function ‘pti_pci_remove’:
drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’ drivers/misc/pti.c: In function ‘pti_pci_probe’:
drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’

So make INTEL_MID_PTI depend on PCI to fix build error.

Signed-off-by Tracey Dent <[email protected]>

---
 drivers/misc/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

drivers/misc/Kconfig +1 -0

index 0a4d86c..2d6423c 100644
@@ -146,6 +146,7 @@ config PHANTOM
 
 config INTEL_MID_PTI
 	tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
+	depends on PCI
 	default n
 	help
 	  The PTI (Parallel Trace Interface) driver directs

Signature · 1 line

1.7.6.433.g1421f

Randy Dunlap

2011-08-11 17:45 UTC #1 lore raw

Quoted 10 lines · On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:

When you try to build INTEL_MID_PTI without having PCI enabled. It fails like this-
CC [M] drivers/misc/pti.o
drivers/misc/pti.c: In function ‘pti_pci_remove’:
drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’ drivers/misc/pti.c: In function ‘pti_pci_probe’:
drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
So make INTEL_MID_PTI depend on PCI to fix build error.

I think (hope) that Greg already has a patch like this queued. Greg- are you planning to push some patches soon?

Quoted 11 lines

Signed-off-by Tracey Dent <[email protected]>
---
 drivers/misc/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/misc/Kconfig +0 -0
index 0a4d86c..2d6423c 100644

drivers/misc/Kconfig config PHANTOM · line 152

Quoted 7 lines

drivers/misc/Kconfig +1 -0

@@ -146,6 +146,7 @@ config PHANTOM
 
 config INTEL_MID_PTI
 	tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
+	depends on PCI
 	default n
 	help
 	  The PTI (Parallel Trace Interface) driver directs

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Tracey Dent

author

2011-08-11 16:59 UTC #2 lore raw

Quoted 11 lines · Randy Dunlap

Quoted 9 lines · On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
When you try to build INTEL_MID_PTI without having PCI enabled. It fails like this-
CC [M] drivers/misc/pti.o
drivers/misc/pti.c: In function ‘pti_pci_remove’:
drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’ drivers/misc/pti.c: In function ‘pti_pci_probe’:
drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’

Quoted 6 lines

Quoted 1 line
So make INTEL_MID_PTI depend on PCI to fix build error.
I think (hope) that Greg already has a patch like this queued. Greg- are you planning to push some patches soon?

Okay, sorry for the noise then.

Quoted 11 lines

Quoted 11 lines
Signed-off-by Tracey Dent <[email protected]>
---
 drivers/misc/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/misc/Kconfig +0 -0
index 0a4d86c..2d6423c 100644
@@ -146,6 +146,7 @@ config PHANTOM
 

Quoted 11 lines

drivers/misc/Kconfig config PHANTOM · line 152
Quoted 7 lines
drivers/misc/Kconfig +1 -0
 config INTEL_MID_PTI
 	tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
+	depends on PCI
 	default n
 	help
 	  The PTI (Parallel Trace Interface) driver directs
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

regards,

Tracey Dent

Ingo Molnar

2011-08-18 16:25 UTC #3 lore raw

Quoted 12 lines · Tracey Dent

Quoted 11 lines · Randy Dunlap
Quoted 9 lines · On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
When you try to build INTEL_MID_PTI without having PCI enabled. It fails like this-
CC [M] drivers/misc/pti.o
drivers/misc/pti.c: In function ‘pti_pci_remove’:
drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’ drivers/misc/pti.c: In function ‘pti_pci_probe’:
drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’

Quoted 8 lines

Quoted 6 lines
Quoted 1 line
So make INTEL_MID_PTI depend on PCI to fix build error.
I think (hope) that Greg already has a patch like this queued. Greg- are you planning to push some patches soon?
Okay, sorry for the noise then.

FYI, The fix is still not upstream, as of today's -git (72ed62bdc46d):

drivers/misc/pti.c:410:3: error: implicit declaration of function ‘pci_release_region’ [-Werror=implicit-function-declaration] drivers/misc/pti.c:859:2: error: implicit declaration of function ‘pci_request_region’ [-Werror=implicit-function-declaration]

Thanks,

Ingo

Greg KH

2011-08-18 18:40 UTC #4 lore raw

Quoted 22 lines · Ingo Molnar

Quoted 19 lines · Tracey Dent
Quoted 17 lines · Randy Dunlap
Quoted 10 lines · On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
When you try to build INTEL_MID_PTI without having PCI enabled. It fails like this-
CC [M] drivers/misc/pti.o
drivers/misc/pti.c: In function ‘pti_pci_remove’:
drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’ drivers/misc/pti.c: In function ‘pti_pci_probe’:
drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
So make INTEL_MID_PTI depend on PCI to fix build error.
I think (hope) that Greg already has a patch like this queued. Greg- are you planning to push some patches soon?

Quoted 7 lines

Quoted 1 line
Okay, sorry for the noise then.
FYI, The fix is still not upstream, as of today's -git (72ed62bdc46d):
drivers/misc/pti.c:410:3: error: implicit declaration of function ‘pci_release_region’ [-Werror=implicit-function-declaration] drivers/misc/pti.c:859:2: error: implicit declaration of function ‘pci_request_region’ [-Werror=implicit-function-declaration]

Yes, sorry, stuck at LinuxCon this week, will get it to Linus next week. He's busy as well, so it's not like he could pull while underwater anyway :)

greg k-h

Ingo Molnar

2011-08-18 20:31 UTC #5 lore raw

Quoted 28 lines · Greg KH

Quoted 27 lines · Ingo Molnar
Quoted 12 lines · Tracey Dent
Quoted 11 lines · Randy Dunlap
Quoted 9 lines · On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
When you try to build INTEL_MID_PTI without having PCI enabled. It fails like this-
CC [M] drivers/misc/pti.o
drivers/misc/pti.c: In function ‘pti_pci_remove’:
drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’ drivers/misc/pti.c: In function ‘pti_pci_probe’:
drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
So make INTEL_MID_PTI depend on PCI to fix build error.
I think (hope) that Greg already has a patch like this queued. Greg- are you planning to push some patches soon?
Okay, sorry for the noise then.
FYI, The fix is still not upstream, as of today's -git (72ed62bdc46d):

Quoted 6 lines

Quoted 2 lines
drivers/misc/pti.c:410:3: error: implicit declaration of function ‘pci_release_region’ [-Werror=implicit-function-declaration] drivers/misc/pti.c:859:2: error: implicit declaration of function ‘pci_request_region’ [-Werror=implicit-function-declaration]
Yes, sorry, stuck at LinuxCon this week, will get it to Linus next week. He's busy as well, so it's not like he could pull while underwater anyway :)

No rush: the failures trigger pretty rately - just wanted to make sure it's not lost.

Thanks,

Ingo

Randy Dunlap

2011-08-19 18:52 UTC #6 lore raw

In reply to Greg KH

Quoted 28 lines · On Thu, 18 Aug 2011 11:39:39 -0700 Greg KH wrote:

Quoted 27 lines · Ingo Molnar
Quoted 12 lines · Tracey Dent
Quoted 11 lines · Randy Dunlap
Quoted 9 lines · On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
When you try to build INTEL_MID_PTI without having PCI enabled. It fails like this-
CC [M] drivers/misc/pti.o
drivers/misc/pti.c: In function ‘pti_pci_remove’:
drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’ drivers/misc/pti.c: In function ‘pti_pci_probe’:
drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
So make INTEL_MID_PTI depend on PCI to fix build error.
I think (hope) that Greg already has a patch like this queued. Greg- are you planning to push some patches soon?
Okay, sorry for the noise then.
FYI, The fix is still not upstream, as of today's -git (72ed62bdc46d):

Quoted 6 lines

Quoted 2 lines
drivers/misc/pti.c:410:3: error: implicit declaration of function ‘pci_release_region’ [-Werror=implicit-function-declaration] drivers/misc/pti.c:859:2: error: implicit declaration of function ‘pci_request_region’ [-Werror=implicit-function-declaration]
Yes, sorry, stuck at LinuxCon this week, will get it to Linus next week. He's busy as well, so it's not like he could pull while underwater anyway :)

I guess he did merge patches somehow yesterday....

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Greg KH

2011-08-11 17:09 UTC #7 lore raw

In reply to Randy Dunlap

Quoted 11 lines · Randy Dunlap

Quoted 9 lines · On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
When you try to build INTEL_MID_PTI without having PCI enabled. It fails like this-
CC [M] drivers/misc/pti.o
drivers/misc/pti.c: In function ‘pti_pci_remove’:
drivers/misc/pti.c:410: error: implicit declaration of function ‘pci_release_region’ drivers/misc/pti.c: In function ‘pti_pci_probe’:
drivers/misc/pti.c:859: error: implicit declaration of function ‘pci_request_region’

Quoted 4 lines

Quoted 1 line
So make INTEL_MID_PTI depend on PCI to fix build error.
I think (hope) that Greg already has a patch like this queued. Greg- are you planning to push some patches soon?

Yes, sorry, "real work" has been keeping me really busy at the moment, I'll get to pushing these to Linus soon.

greg k-h