staging: rtl8712: remove r8712_cmd_thread()->daemonize()

PATCH In review Oleg Nesterov 4 participants 4 messages Aug 16, 2011 Staging

lore

Share & tools

lore

Oleg Nesterov

author

2011-08-16 18:54 UTC #0 lore raw

PATCH 1/1 staging: rtl8712: remove r8712_cmd_thread()->daemonize()

daemonize() is only needed when a user-space task does kernel_thread().

r8712_cmd_thread() is kthread_create()'ed and thus it doesn't need the soon-to-be-deprecated daemonize(). It is the only caller of thread_enter() which actually does the call.

Note:
- we are going to remove the sigdelset(blocked) code from allow_signal(), this means that without this patch thread_enter() can't work after that. Not to mention daemonize() should be deprecated.

- as a side effect, this patch changes ->comm. Hopefully this is fine, and padapter->pnetdev->name probably makes more sense anyway.

Signed-off-by Oleg Nesterov <[email protected]>

---

 drivers/staging/rtl8712/osdep_service.h |    1 -
 1 file changed, 1 deletion(-)

drivers/staging/rtl8712/osdep_service.h renamed from drivers/staging/rtl8712/osdep_service.h~2_daemonize_rtl8712 +0 -1

@@ -203,7 +203,6 @@ static inline unsigned char _cancel_time
 
 static inline void thread_enter(void *context)
 {
-	daemonize("%s", "RTKTHREAD");
 	allow_signal(SIGTERM);
 }

Tejun Heo

Acked-by on v1 1/1

2011-08-16 19:35 UTC #1 lore raw

Quoted 12 lines · Oleg Nesterov

daemonize() is only needed when a user-space task does kernel_thread().
r8712_cmd_thread() is kthread_create()'ed and thus it doesn't need the soon-to-be-deprecated daemonize(). It is the only caller of thread_enter() which actually does the call.
Note:
- we are going to remove the sigdelset(blocked) code from allow_signal(), this means that without this patch thread_enter() can't work after that. Not to mention daemonize() should be deprecated.

Quoted 5 lines

- as a side effect, this patch changes ->comm. Hopefully this is fine, and padapter->pnetdev->name probably makes more sense anyway.
Signed-off-by Oleg Nesterov <[email protected]>

Acked-by Tejun Heo <[email protected]>

Signature · 1 line

tejun

Larry Finger

2011-08-16 20:27 UTC #2 lore raw

Quoted 13 lines · Tejun Heo

Quoted 12 lines · Oleg Nesterov
daemonize() is only needed when a user-space task does kernel_thread().
r8712_cmd_thread() is kthread_create()'ed and thus it doesn't need the soon-to-be-deprecated daemonize(). It is the only caller of thread_enter() which actually does the call.
Note:
- we are going to remove the sigdelset(blocked) code from allow_signal(), this means that without this patch thread_enter() can't work after that. Not to mention daemonize() should be deprecated.

Quoted 7 lines

Quoted 5 lines
- as a side effect, this patch changes ->comm. Hopefully this is fine, and padapter->pnetdev->name probably makes more sense anyway.
Signed-off-by Oleg Nesterov<[email protected]>
Acked-by Tejun Heo<[email protected]>

Acked-and-tested-by Larry Finger <[email protected]>

Matt Fleming

Acked-by on v1 1/1

2011-08-16 21:30 UTC #3 lore raw

In reply to Oleg Nesterov

Quoted 12 lines · Oleg Nesterov

daemonize() is only needed when a user-space task does kernel_thread().
r8712_cmd_thread() is kthread_create()'ed and thus it doesn't need the soon-to-be-deprecated daemonize(). It is the only caller of thread_enter() which actually does the call.
Note:
- we are going to remove the sigdelset(blocked) code from allow_signal(), this means that without this patch thread_enter() can't work after that. Not to mention daemonize() should be deprecated.

Quoted 5 lines

- as a side effect, this patch changes ->comm. Hopefully this is fine, and padapter->pnetdev->name probably makes more sense anyway.
Signed-off-by Oleg Nesterov <[email protected]>

Acked-by Matt Fleming <[email protected]>