ARM: S3C64XX: Remove un-used code

PATCH New Banajit Goswami 4 participants 8 messages Aug 16, 2011 – Aug 19, 2011

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

lore

Share & tools

lore

Banajit Goswami

author

2011-08-16 12:41 UTC #0 lore raw

PATCH 1/1 ARM: S3C64XX: Remove un-used code

Remove un-used backlight code for SMDK6410 board

Signed-off-by Banajit Goswami <[email protected]>

---
 arch/arm/mach-s3c64xx/mach-smdk6410.c |   39 ---------------------------------
 1 files changed, 0 insertions(+), 39 deletions(-)

arch/arm/mach-s3c64xx/mach-smdk6410.c +0 ~~-39~~

index ecbea92..a9f3183 100644
@@ -262,45 +262,6 @@ static struct samsung_keypad_platdata smdk6410_keypad_data __initdata = {
 	.cols		= 8,
 };
 
-static int smdk6410_backlight_init(struct device *dev)
-{
-	int ret;
-
-	ret = gpio_request(S3C64XX_GPF(15), "Backlight");
-	if (ret) {
-		printk(KERN_ERR "failed to request GPF for PWM-OUT1\n");
-		return ret;
-	}
-
-	/* Configure GPIO pin with S3C64XX_GPF15_PWM_TOUT1 */
-	s3c_gpio_cfgpin(S3C64XX_GPF(15), S3C_GPIO_SFN(2));
-
-	return 0;
-}
-
-static void smdk6410_backlight_exit(struct device *dev)
-{
-	s3c_gpio_cfgpin(S3C64XX_GPF(15), S3C_GPIO_OUTPUT);
-	gpio_free(S3C64XX_GPF(15));
-}
-
-static struct platform_pwm_backlight_data smdk6410_backlight_data = {
-	.pwm_id		= 1,
-	.max_brightness	= 255,
-	.dft_brightness	= 255,
-	.pwm_period_ns	= 78770,
-	.init		= smdk6410_backlight_init,
-	.exit		= smdk6410_backlight_exit,
-};
-
-static struct platform_device smdk6410_backlight_device = {
-	.name		= "pwm-backlight",
-	.dev		= {
-		.parent		= &s3c_device_timer[1].dev,
-		.platform_data	= &smdk6410_backlight_data,
-	},
-};
-
 static struct map_desc smdk6410_iodesc[] = {};
 
 static struct platform_device *smdk6410_devices[] __initdata = {

Signature · 1 line

1.7.2.3

Mark Brown

2011-08-19 01:59 UTC #1 lore raw

PATCH 1/1 ARM: S3C64XX: Remove un-used code

Quoted 1 line · Banajit Goswami

Remove un-used backlight code for SMDK6410 board

Is the data actually wrong? If not it'd seem better to finish hooking it up properly than to remove it.

Banajit Goswami

2011-08-19 04:10 UTC #2 lore raw

PATCH 1/1 ARM: S3C64XX: Remove un-used code

Hi Mark,

Quoted 5 lines · Mark Brown

Quoted 1 line · Banajit Goswami
Remove un-used backlight code for SMDK6410 board
Is the data actually wrong? ?If not it'd seem better to finish hooking it up properly than to remove it.

No, this code is no longer needed, as we are having a common backlight infrastructure , which serves the same purpose.

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html

Thanks and Regards,
Banajit Goswami

Mark Brown

2011-08-19 04:53 UTC #3 lore raw

PATCH 1/1 ARM: S3C64XX: Remove un-used code

Quoted 10 lines · Banajit Goswami

Quoted 5 lines · Mark Brown
Quoted 1 line · Banajit Goswami
Remove un-used backlight code for SMDK6410 board
Is the data actually wrong? ?If not it'd seem better to finish hooking it up properly than to remove it.
No, this code is no longer needed, as we are having a common backlight infrastructure , which serves the same purpose.

Ideally your commit log should make this clear - it looks like you're just deleting unreferenced code.

Kukjin Kim

2011-08-19 05:29 UTC #4 lore raw

PATCH 1/1 ARM: S3C64XX: Remove un-used code

Quoted 7 lines · Mark Brown

Quoted 4 lines · Banajit Goswami
Quoted 2 lines · Mark Brown
Quoted 1 line · Banajit Goswami
Remove un-used backlight code for SMDK6410 board

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
Is the data actually wrong? ?If not it'd seem better to finish hooking it up properly than to remove it.
No, this code is no longer needed, as we are having a common backlight infrastructure , which serves the same purpose.
Ideally your commit log should make this clear - it looks like you're just deleting unreferenced code.

Yes, I agree with your opinion...It was difficult to know why it is un-used code when I applied that.

OK, I will amend its commit log in my tree to clear.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Banajit Goswami

2011-08-19 05:39 UTC #5 lore raw

PATCH 1/1 ARM: S3C64XX: Remove un-used code

Hi Mr. Kim,

Quoted 11 lines · Kukjin Kim

Quoted 10 lines · Mark Brown
Quoted 7 lines · Banajit Goswami
Quoted 5 lines · Mark Brown
Quoted 1 line · Banajit Goswami
Remove un-used backlight code for SMDK6410 board
Is the data actually wrong? ?If not it'd seem better to finish hooking it up properly than to remove it.

Quoted 9 lines

Quoted 5 lines
Quoted 2 lines
No, this code is no longer needed, as we are having a common backlight infrastructure , which serves the same purpose.
Ideally your commit log should make this clear - it looks like you're just deleting unreferenced code.
Yes, I agree with your opinion...It was difficult to know why it is un-used code when I applied that.

Yes, I will explain more in comments in future!

Quoted 1 line

OK, I will amend its commit log in my tree to clear.

Thank you!

Thanks and Regards,
Banajit Goswami

Banajit Goswami

2011-08-19 06:59 UTC #6 lore raw

PATCH 1/1 ARM: S3C64XX: Remove un-used code

In reply to Mark Brown

Hi Mark,

Quoted 6 lines · Mark Brown

Quoted 4 lines · Banajit Goswami
Quoted 2 lines · Mark Brown
Quoted 1 line · Banajit Goswami
Remove un-used backlight code for SMDK6410 board

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
Is the data actually wrong? ?If not it'd seem better to finish hooking it up properly than to remove it.
No, this code is no longer needed, as we are having a common backlight infrastructure , which serves the same purpose.
Ideally your commit log should make this clear - it looks like you're just deleting unreferenced code.

Thanks.
Will add more description now on.

Thanks and Regards,
Banajit Goswami

Kukjin Kim

2011-08-19 05:24 UTC #7 lore raw

PATCH 1/1 ARM: S3C64XX: Remove un-used code

In reply to Banajit Goswami

Quoted 6 lines · Banajit Goswami

Remove un-used backlight code for SMDK6410 board
Signed-off-by Banajit Goswami <[email protected]>
---
 arch/arm/mach-s3c64xx/mach-smdk6410.c |   39

---------------------------------

Quoted 53 lines

 1 files changed, 0 insertions(+), 39 deletions(-)

arch/arm/mach- renamed from arch/arm/mach-s3c64xx/mach-smdk6410.c +0 -0

s3c64xx/mach-smdk6410.c
index ecbea92..a9f3183 100644

arch/arm/mach-s3c64xx/mach-smdk6410.c +0 ~~-39~~

@@ -262,45 +262,6 @@ static struct samsung_keypad_platdata
 smdk6410_keypad_data __initdata = {
 	.cols		= 8,
 };
 
-static int smdk6410_backlight_init(struct device *dev)
-{
-	int ret;
-
-	ret = gpio_request(S3C64XX_GPF(15), "Backlight");
-	if (ret) {
-		printk(KERN_ERR "failed to request GPF for PWM-OUT1\n");
-		return ret;
-	}
-
-	/* Configure GPIO pin with S3C64XX_GPF15_PWM_TOUT1 */
-	s3c_gpio_cfgpin(S3C64XX_GPF(15), S3C_GPIO_SFN(2));
-
-	return 0;
-}
-
-static void smdk6410_backlight_exit(struct device *dev)
-{
-	s3c_gpio_cfgpin(S3C64XX_GPF(15), S3C_GPIO_OUTPUT);
-	gpio_free(S3C64XX_GPF(15));
-}
-
-static struct platform_pwm_backlight_data smdk6410_backlight_data = {
-	.pwm_id		= 1,
-	.max_brightness	= 255,
-	.dft_brightness	= 255,
-	.pwm_period_ns	= 78770,
-	.init		= smdk6410_backlight_init,
-	.exit		= smdk6410_backlight_exit,
-};
-
-static struct platform_device smdk6410_backlight_device = {
-	.name		= "pwm-backlight",
-	.dev		= {
-		.parent		= &s3c_device_timer[1].dev,
-		.platform_data	= &smdk6410_backlight_data,
-	},
-};
-
 static struct map_desc smdk6410_iodesc[] = {};

Quoted 3 lines

static struct platform_device *smdk6410_devices[] __initdata = {
--
1.7.2.3

OK, applied.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.