Skip to contentSkip to conversation

arm: mach-bcmring: fix build error in core.c

PATCH In review Maxin B. John 3 participants 4 messages Aug 23, 2011

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Maxin B. John

author
#0 lore raw

PATCH 1/2 arm: mach-bcmring: fix build error in core.c

CC arch/arm/mach-bcmring/core.o
arch/arm/mach-bcmring/core.c: In function 'bcmring_init_timer':
arch/arm/mach-bcmring/core.c:238: error: implicit declaration of function 'sp804_clockevents_register'
make[1]: *** [arch/arm/mach-bcmring/core.o] Error 1
make: *** [arch/arm/mach-bcmring] Error 2

Please let me know your comments on this fix:

Signed-off-by Maxin B. John <[email protected]>

---

arch/arm/mach-bcmring/core.c +1 -1
index 43eadbc..430da12 100644
@@ -235,7 +235,7 @@ void __init bcmring_init_timer(void)
 	 */
 	bcmring_clocksource_init();
 
-	sp804_clockevents_register(TIMER0_VA_BASE, IRQ_TIMER0, "timer0");
+	sp804_clockevents_init(TIMER0_VA_BASE, IRQ_TIMER0, "timer0");
 }
 
 struct sys_timer bcmring_timer = {
#1 lore raw
Quoted 17 lines · Maxin B. John

CC arch/arm/mach-bcmring/core.o
arch/arm/mach-bcmring/core.c: In function 'bcmring_init_timer':
arch/arm/mach-bcmring/core.c:238: error: implicit declaration of function 'sp804_clockevents_register'
make[1]: *** [arch/arm/mach-bcmring/core.o] Error 1
make: *** [arch/arm/mach-bcmring] Error 2

Please let me know your comments on this fix:

Signed-off-by Maxin B. John<[email protected]>

---

arch/arm/mach-bcmring/core.c +0 -0
index 43eadbc..430da12 100644

arch/arm/mach-bcmring/core.c void __init bcmring_init_timer(void) · line 241

Quoted 8 lines
arch/arm/mach-bcmring/core.c +1 -1
@@ -235,7 +235,7 @@ void __init bcmring_init_timer(void)
  	 */
  	bcmring_clocksource_init();
 
-	sp804_clockevents_register(TIMER0_VA_BASE, IRQ_TIMER0, "timer0");
+	sp804_clockevents_init(TIMER0_VA_BASE, IRQ_TIMER0, "timer0");
  }
 
  struct sys_timer bcmring_timer = {
Signed-off-by Jiandong Zheng <[email protected]>

The same changes was in my comments on May 17 to Russell's serial patches to convert to sp804 clk dev, but seems it got lost.

#2 lore raw
Quoted 20 lines · Jiandong Zheng
Quoted 19 lines · Maxin B. John

CC arch/arm/mach-bcmring/core.o
arch/arm/mach-bcmring/core.c: In function 'bcmring_init_timer':
arch/arm/mach-bcmring/core.c:238: error: implicit declaration of function 'sp804_clockevents_register'
make[1]: *** [arch/arm/mach-bcmring/core.o] Error 1
make: *** [arch/arm/mach-bcmring] Error 2

Please let me know your comments on this fix:

Signed-off-by Maxin B. John<[email protected]>

---

arch/arm/mach-bcmring/core.c +0 -0
index 43eadbc..430da12 100644
@@ -235,7 +235,7 @@ void __init bcmring_init_timer(void)
  	 */
  	bcmring_clocksource_init();
Quoted 7 lines

arch/arm/mach-bcmring/core.c void __init bcmring_init_timer(void) · line 241

Quoted 6 lines
arch/arm/mach-bcmring/core.c +1 -1
-	sp804_clockevents_register(TIMER0_VA_BASE, IRQ_TIMER0, "timer0");
+	sp804_clockevents_init(TIMER0_VA_BASE, IRQ_TIMER0, "timer0");
  }
 
  struct sys_timer bcmring_timer = {
Signed-off-by Jiandong Zheng <[email protected]>

Don't you mean acked-by or reviewed-by?

Quoted 2 lines

The same changes was in my comments on May 17 to Russell's serial patches to convert to sp804 clk dev, but seems it got lost.

Unfortunately... sorry about that.

#3 lore raw
Quoted 25 lines · Russell King - ARM Linux
Quoted 24 lines · Jiandong Zheng
Quoted 23 lines · Maxin B. John

CC arch/arm/mach-bcmring/core.o
arch/arm/mach-bcmring/core.c: In function 'bcmring_init_timer':
arch/arm/mach-bcmring/core.c:238: error: implicit declaration of function 'sp804_clockevents_register'
make[1]: *** [arch/arm/mach-bcmring/core.o] Error 1
make: *** [arch/arm/mach-bcmring] Error 2

Please let me know your comments on this fix:

Signed-off-by Maxin B. John<[email protected]>

---

arch/arm/mach-bcmring/core.c +1 -1
index 43eadbc..430da12 100644
@@ -235,7 +235,7 @@ void __init bcmring_init_timer(void)
   	 */
   	bcmring_clocksource_init();
 
-	sp804_clockevents_register(TIMER0_VA_BASE, IRQ_TIMER0, "timer0");
+	sp804_clockevents_init(TIMER0_VA_BASE, IRQ_TIMER0, "timer0");
   }
Quoted 5 lines
Quoted 3 lines

arch/arm/mach-bcmring/core.c void __init bcmring_init_timer(void) · line 241

Quoted 2 lines
arch/arm/mach-bcmring/core.c +0 -0
   struct sys_timer bcmring_timer = {
Signed-off-by Jiandong Zheng<[email protected]>

Don't you mean acked-by or reviewed-by?

I meant I created the same patch and have tested it. But if acked-by or reviewed-by is less confusing, I am OK with it.

Quoted 6 lines
Quoted 3 lines

The same changes was in my comments on May 17 to Russell's serial patches to convert to sp804 clk dev, but seems it got lost.

Unfortunately... sorry about that.

To avoid this, should I submit every patch to patch system after reviewed through maillist?