Skip to contentSkip to conversation

arm: mach-bcmring: fix build error in dma.c

PATCH In review Maxin B John 2 participants 4 messages Aug 23, 2011 – Aug 24, 2011

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Maxin B John

author
#0 lore raw

PATCH 2/2 arm: mach-bcmring: fix build error in dma.c

CC arch/arm/mach-bcmring/dma.o
arch/arm/mach-bcmring/dma.c: In function 'dma_request_channel_dbg':
arch/arm/mach-bcmring/dma.c:1022: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function) arch/arm/mach-bcmring/dma.c:1022: error: (Each undeclared identifier is reported only once
arch/arm/mach-bcmring/dma.c:1022: error: for each function it appears in.)
arch/arm/mach-bcmring/dma.c:1024: error: implicit declaration of function 'schedule'
arch/arm/mach-bcmring/dma.c:1027: error: implicit declaration of function 'signal_pending'
arch/arm/mach-bcmring/dma.c: In function 'dma_free_channel':
arch/arm/mach-bcmring/dma.c:1092: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function) arch/arm/mach-bcmring/dma.c: In function 'dma_map_add_region':
arch/arm/mach-bcmring/dma.c:1946: error: dereferencing pointer to incomplete type
arch/arm/mach-bcmring/dma.c:1948: error: dereferencing pointer to incomplete type
arch/arm/mach-bcmring/dma.c:1955: error: dereferencing pointer to incomplete type
make[1]: *** [arch/arm/mach-bcmring/dma.o] Error 1
make: *** [arch/arm/mach-bcmring] Error 2

Signed-off-by Maxin B. John <[email protected]>

---

arch/arm/mach-bcmring/dma.c +1 -0
index 0ca0005..12d1504 100644
@@ -35,6 +35,7 @@
 #include <linux/mm.h>
 #include <linux/pfn.h>
 #include <linux/atomic.h>
+#include <linux/sched.h>
 #include <mach/dma.h>
 
 /* I don't quite understand why dc4 fails when this is set to 1 and DMA is enabled */
#1 lore raw
Quoted 33 lines · Maxin B John

CC arch/arm/mach-bcmring/dma.o
arch/arm/mach-bcmring/dma.c: In function 'dma_request_channel_dbg':
arch/arm/mach-bcmring/dma.c:1022: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function) arch/arm/mach-bcmring/dma.c:1022: error: (Each undeclared identifier is reported only once
arch/arm/mach-bcmring/dma.c:1022: error: for each function it appears in.)
arch/arm/mach-bcmring/dma.c:1024: error: implicit declaration of function 'schedule'
arch/arm/mach-bcmring/dma.c:1027: error: implicit declaration of function 'signal_pending'
arch/arm/mach-bcmring/dma.c: In function 'dma_free_channel':
arch/arm/mach-bcmring/dma.c:1092: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function) arch/arm/mach-bcmring/dma.c: In function 'dma_map_add_region':
arch/arm/mach-bcmring/dma.c:1946: error: dereferencing pointer to incomplete type
arch/arm/mach-bcmring/dma.c:1948: error: dereferencing pointer to incomplete type
arch/arm/mach-bcmring/dma.c:1955: error: dereferencing pointer to incomplete type
make[1]: *** [arch/arm/mach-bcmring/dma.o] Error 1
make: *** [arch/arm/mach-bcmring] Error 2

Signed-off-by Maxin B. John<[email protected]>

---

arch/arm/mach-bcmring/dma.c +0 -0
index 0ca0005..12d1504 100644

arch/arm/mach-bcmring/dma.c line 41

Quoted 7 lines
arch/arm/mach-bcmring/dma.c +1 -0
@@ -35,6 +35,7 @@
  #include<linux/mm.h>
  #include<linux/pfn.h>
  #include<linux/atomic.h>
+#include<linux/sched.h>
  #include<mach/dma.h>
 
  /* I don't quite understand why dc4 fails when this is set to 1 and DMA is enabled */
Signed-off-by Jiandong Zheng <[email protected]>

I have same fix submitted on May 12, which was supposed to be applied soon but seems it wasn't.

author
#2 lore raw
Quoted 8 lines · Jiandong Zheng
Quoted 3 lines · Maxin B John

?CC ? ? ?arch/arm/mach-bcmring/dma.o

Signed-off-by Jiandong Zheng <[email protected]>

I have same fix submitted on May 12, which was supposed to be applied soon but seems it wasn't.

Oh.. I wasn't aware of that. Please feel free to ignore this one and go ahead with your patch.

Regards,
Maxin

#3 lore raw
Quoted 7 lines · Maxin B John
Quoted 6 lines · Jiandong Zheng
Quoted 3 lines · Maxin B John

CC arch/arm/mach-bcmring/dma.o

Signed-off-by Jiandong Zheng<[email protected]>
Quoted 9 lines
Quoted 2 lines

I have same fix submitted on May 12, which was supposed to be applied soon but seems it wasn't.

Oh.. I wasn't aware of that. Please feel free to ignore this one and go ahead with your patch.

Regards,
Maxin

Seems the previous patch was lost. Let us just go ahead with this one in order to get it fixed sooner.