Skip to contentSkip to conversation

fs, proc: Report EISDIR when reading sysctl dirs in proc

PATCH In review Cyrill Gorcunov 3 participants 5 messages Aug 5, 2011 – Aug 24, 2011

Subsystems (3)
VFS Proc filesystem Proc sysctl
lore
Share & tools
lore

Cyrill Gorcunov

author
#0 lore raw

PATCH 1/1 fs, proc: Report EISDIR when reading sysctl dirs in proc

From: Pavel Emelyanov <[email protected]>

On reading sysctl dirs we should return -EISDIR instead of -EINVAL.

Signed-off-by Pavel Emelyanov <[email protected]>
Signed-off-by Cyrill Gorcunov <[email protected]>
---
 fs/proc/proc_sysctl.c |    1 +
 1 file changed, 1 insertion(+)
fs/proc/proc_sysctl.c +1 -0
Index: linux-2.6.git/fs/proc/proc_sysctl.c
===================================================================
@@ -370,6 +370,7 @@ static const struct file_operations proc
 };
 
 static const struct file_operations proc_sys_dir_file_operations = {
+	.read		= generic_read_dir,
 	.readdir	= proc_sys_readdir,
 	.llseek		= generic_file_llseek,
 };
#3 lore raw

On Wed, Aug 24, 2011 at 10:26:36AM +0400, Pavel Emelyanov wrote:
...

Quoted 6 lines
Quoted 2 lines

Ping? Any objections on this patch?

Gentlemen, I'm sorry to bother you again, but can you please share your plans about this fix?

Andrew has picked it up yesterday. Didn't you get CC?

Cyrill

#4 lore raw
Quoted 10 lines · Cyrill Gorcunov

On Wed, Aug 24, 2011 at 10:26:36AM +0400, Pavel Emelyanov wrote:
...

Quoted 6 lines
Quoted 2 lines

Ping? Any objections on this patch?

Gentlemen, I'm sorry to bother you again, but can you please share your plans about this fix?

Andrew has picked it up yesterday. Didn't you get CC?

Not yet :( We've had power outage at Parallels this night, maybe this is the reason of the delay...

Quoted 2 lines

Cyrill