Skip to contentSkip to conversation

b43: drop Kconfig option of forcing PIO mode

RFC PATCH Superseded Rafał Miłecki 3 participants 4 messages Aug 16, 2011 – Aug 24, 2011 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

RFC PATCH v2 1/1 b43: drop Kconfig option of forcing PIO mode

We have module param called use_pio which is much easier to use.

---
V2: include b43.h change

Larry introduced use_pio with:
b43: Allow PIO mode to be selected at module load
I believe we can leave this simple module param and drop CONFIG_B43_FORCE_PIO instead.

---
 drivers/net/wireless/b43/Kconfig |   10 ----------
 drivers/net/wireless/b43/b43.h   |    6 ------
 drivers/net/wireless/b43/main.c  |    2 +-
 3 files changed, 1 insertions(+), 17 deletions(-)
drivers/net/wireless/b43/Kconfig +0 -10
index 3c5e571..bfc1cb4 100644
@@ -169,13 +169,3 @@ config B43_DEBUG
 	  Say N, if you are a distributor or user building a release kernel
 	  for production use.
 	  Only say Y, if you are debugging a problem in the b43 driver sourcecode.
-
-config B43_FORCE_PIO
-	bool "Force usage of PIO instead of DMA"
-	depends on B43 && B43_DEBUG
-	---help---
-	  This will disable DMA and always enable PIO instead.
-
-	  Say N!
-	  This is only for debugging the PIO engine code. You do
-	  _NOT_ want to enable this.
drivers/net/wireless/b43/b43.h +0 -6
index 9e5974b..2597062 100644
@@ -975,12 +975,6 @@ static inline bool b43_using_pio_transfers(struct b43_wldev *dev)
 	return dev->__using_pio_transfers;
 }
 
-#ifdef CONFIG_B43_FORCE_PIO
-# define B43_PIO_DEFAULT 1
-#else
-# define B43_PIO_DEFAULT 0
-#endif
-
 /* Message printing */
 void b43info(struct b43_wl *wl, const char *fmt, ...)
     __attribute__ ((format(printf, 2, 3)));
drivers/net/wireless/b43/main.c +1 -1
index e0b1156..7c4cab0 100644
@@ -108,7 +108,7 @@ int b43_modparam_verbose = B43_VERBOSITY_DEFAULT;
 module_param_named(verbose, b43_modparam_verbose, int, 0644);
 MODULE_PARM_DESC(verbose, "Log message verbosity: 0=error, 1=warn, 2=info(default), 3=debug");
 
-static int b43_modparam_pio = B43_PIO_DEFAULT;
+static int b43_modparam_pio = 0;
 module_param_named(pio, b43_modparam_pio, int, 0644);
 MODULE_PARM_DESC(pio, "Use PIO accesses by default: 0=DMA, 1=PIO");
 
Signature · 1 line
1.7.3.4
#1 lore raw

RFC PATCH v2 1/1 b43: drop Kconfig option of forcing PIO mode

Quoted 11 lines · Rafa? Mi?ecki

We have module param called use_pio which is much easier to use.

---
V2: include b43.h change

Larry introduced use_pio with:
b43: Allow PIO mode to be selected at module load
I believe we can leave this simple module param and drop CONFIG_B43_FORCE_PIO instead.

Seems reasonable to me...any objections?

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.
#2 lore raw

RFC PATCH v2 1/1 b43: drop Kconfig option of forcing PIO mode

Quoted 7 lines · On Wed, 24 Aug 2011 14:31:28 -0400 "John W. Linville" <[email protected]>…
Quoted 4 lines

Larry introduced use_pio with:
b43: Allow PIO mode to be selected at module load
I believe we can leave this simple module param and drop CONFIG_B43_FORCE_PIO instead.

Seems reasonable to me...any objections?

acked by me.

Signature · 1 line
Greetings, Michael.
#3 lore raw

RFC PATCH v2 1/1 b43: drop Kconfig option of forcing PIO mode

In reply to John W. Linville

W dniu 24 sierpnia 2011 20:31 u?ytkownik John W. Linville <[email protected]> napisa?:

Quoted 8 lines · Rafa? Mi?ecki
Quoted 7 lines

We have module param called use_pio which is much easier to use.

---
V2: include b43.h change

Quoted 6 lines
Quoted 4 lines

Larry introduced use_pio with:
? ? b43: Allow PIO mode to be selected at module load I believe we can leave this simple module param and drop CONFIG_B43_FORCE_PIO instead.

Seems reasonable to me...any objections?

Thank you for taking care of this John. I hope to get patches straight in the future (now, when I understand the way you treat RFC/RFT).

Signature · 1 line
Rafa?