Armada100: Enable Ethernet support for GplugD

PATCH Superseded Ajay Bhargav 2 participants 2 messages Aug 25, 2011 1 message not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Ajay Bhargav

author

2011-08-25 12:09 UTC #1 lore raw

PATCH v2 2/3 Armada100: Enable Ethernet support for GplugD

Quoted 27 lines · ----- "Marek Vasut

Quoted 7 lines · Ajay Bhargav
----- "Marek Vasut" <[email protected]> wrote:
[...]
Quoted 4 lines
Review
Quoted 2 lines
(quoted diff) +2 -0
+/* Disable DCACHE */
+#define CONFIG_SYS_DCACHE_OFF
ARMADA100 is still ARMv5? Then maybe you can try Hong Xu's patches
for
Quoted 2 lines
Quoted 2 lines
dcache on
armv5. You'll have to modify the ethernet driver to be aware of
the
Quoted 6 lines
Quoted 4 lines
dcache then
though.
As dcache support is on the way, it might be worth it.
Yes ARMADA100 is ARMv5. I had problems with dcache enabled, driver
get
Quoted 1 line
stuck. Can you please link me to Hong Xu's patches? Is there a
problem if
Quoted 1 line
i keep it disabled?
http://lists.denx.de/pipermail/u-boot/2011-August/098405.html Look around this.
You'd better search for V2 of the patches or V3 in U-Boot ML archive.

Quoted 5 lines

There's no problem if you keep it disabled, but eventually, you'll have to
enable it ;-)
Cheers

Hi Marek,

I searched mail list after I emailed you.. There has been a lot of discussion going on Hong Xu's patches. I think it would be better if I work on enabling dcache once the patch is mainlined.

Thanks,
Ajay Bhargav

Marek Vasut

2011-08-25 13:01 UTC #2 lore raw

PATCH v2 2/3 Armada100: Enable Ethernet support for GplugD

Quoted 40 lines · Ajay Bhargav

Quoted 39 lines · ----- "Marek Vasut
Quoted 7 lines · Ajay Bhargav
----- "Marek Vasut" <[email protected]> wrote:
[...]
Quoted 4 lines
Review
Quoted 2 lines
(quoted diff) +2 -0
+/* Disable DCACHE */
+#define CONFIG_SYS_DCACHE_OFF
ARMADA100 is still ARMv5? Then maybe you can try Hong Xu's patches
for
Quoted 2 lines
Quoted 2 lines
dcache on
armv5. You'll have to modify the ethernet driver to be aware of
the
Quoted 6 lines
Quoted 4 lines
dcache then
though.
As dcache support is on the way, it might be worth it.
Yes ARMADA100 is ARMv5. I had problems with dcache enabled, driver
get
Quoted 1 line
stuck. Can you please link me to Hong Xu's patches? Is there a
problem if
Quoted 1 line
i keep it disabled?
http://lists.denx.de/pipermail/u-boot/2011-August/098405.html Look around this.
You'd better search for V2 of the patches or V3 in U-Boot ML archive.
There's no problem if you keep it disabled, but eventually, you'll have to
enable it ;-)

Quoted 7 lines

Quoted 1 line
Cheers
Hi Marek,
I searched mail list after I emailed you.. There has been a lot of discussion going on Hong Xu's patches. I think it would be better if I work on enabling dcache once the patch is mainlined.

You can always give it a whirl to test the patch. You can also find pieces of your driver that will need redesign because of the cache-line alignment and avoid such trouble in advance. But this is just an offer, it's not a firm requirement for the patch to be mainlined!

Cheers

Quoted 3 lines

Thanks,
Ajay Bhargav