Skip to contentSkip to conversation

linux-next: build failure after merge of the ptrace tree

PATCH New Stephen Rothwell 2 participants 3 messages Aug 25, 2011 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the ptrace tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:

ERROR: ".set_current_blocked" [fs/autofs4/autofs4.ko] undefined!

Presumably set_current_blocked() needs to be EXPORTed.

I have used the ptrace tree from next-20110824 for today.

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#1 lore raw

Hi Stephen,

Quoted 7 lines · Stephen Rothwell

Hi all,

After merging the ptrace tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:

ERROR: ".set_current_blocked" [fs/autofs4/autofs4.ko] undefined!

In case you didn't notice, we are doing our best to complicate your life :/

Sorry.

Quoted 1 line

Presumably set_current_blocked() needs to be EXPORTed.

Yes. I've reset the last 4 commits which touch the code in fs/. Will add them back after the patch which exports set_current_blocked.

Thanks a lot!

Oleg.

#2 lore raw

PATCH 1/1 add EXPORT_SYMBOL(set_current_blocked)

In reply to Stephen Rothwell

Export set_current_blocked() for modules. We have the code which wrongly plays with ->blocked, and sigprocmask() should be avoided.

---

 kernel/signal.c |    1 +
 1 file changed, 1 insertion(+)
kernel/signal.c renamed from kernel/signal.c~export_set_current_blocked +1 -0
@@ -2463,6 +2463,7 @@ void set_current_blocked(const sigset_t 
 	__set_task_blocked(tsk, newset);
 	spin_unlock_irq(&tsk->sighand->siglock);
 }
+EXPORT_SYMBOL(set_current_blocked);
 
 /*
  * This is also useful for kernel threads that want to temporarily