ASoC: omap-mcpdm: Replace legacy driver
PATCH v4 1/1 ASoC: omap-mcpdm: Replace legacy driver
From: Misael Lopez Cruz <[email protected]>
Reasons for the replacement:
The current driver for McPDM was developed to support the legacy mode only. In preparation for the ABE support the current driver stack need the be replaced.
The new driver is much simpler, easier to extend, and it also fixes some of the issues with the old stack.
Main changes:
- single file for omap-mcpdm (mcpdm.c/h removed)
- Define names for registers, bits cleaned up, prefixed
- Full-duplex audio operation (arecord | aplay) has been fixed
- Less code
McPDM need to be turned off after all streams has been stopped. This might cause pop noise on the output, if the codec's DAC is still powered at this time.
---
Hi Mark, Liam,
Changes since v3:
- The delayed shutdown part has been taken out from the new driver for now.
The McPDM interface is turned off at stream stop time, when all streams has been already stopped.
This can create pop on the output until I can delay the power off after the codec's DAC power down, but before the full power down of the codec.
Regards,
Peter
sound/soc/omap/Makefile | 2 +- sound/soc/omap/mcpdm.c | 474 -------------------------- sound/soc/omap/mcpdm.h | 152 --------- sound/soc/omap/omap-mcpdm.c | 789 ++++++++++++++++++++++++++++--------------- sound/soc/omap/omap-mcpdm.h | 95 ++++++ sound/soc/omap/sdp4430.c | 2 +- 6 files changed, 607 insertions(+), 907 deletions(-) delete mode 100644 sound/soc/omap/mcpdm.c delete mode 100644 sound/soc/omap/mcpdm.h rewrite sound/soc/omap/omap-mcpdm.c (44%) create mode 100644 sound/soc/omap/omap-mcpdm.h
sound/soc/omap/Makefile +1 -1
@@ -1,7 +1,7 @@ # OMAP Platform Support snd-soc-omap-objs := omap-pcm.o snd-soc-omap-mcbsp-objs := omap-mcbsp.o -snd-soc-omap-mcpdm-objs := omap-mcpdm.o mcpdm.o +snd-soc-omap-mcpdm-objs := omap-mcpdm.o snd-soc-omap-hdmi-objs := omap-hdmi.o obj-$(CONFIG_SND_OMAP_SOC) += snd-soc-omap.o
sound/soc/omap/mcpdm.c deleted +0 -474
474 lines not on this page · raw message
sound/soc/omap/mcpdm.h deleted +0 -152
152 lines not on this page · raw message
sound/soc/omap/omap-mcpdm.c +510 -279
789 lines not on this page · raw message
sound/soc/omap/omap-mcpdm.h new file +95 -0
95 lines not on this page · raw message
sound/soc/omap/sdp4430.c +1 -1
@@ -32,7 +32,7 @@#include <plat/hardware.h> #include <plat/mux.h> -#include "mcpdm.h" +#include "omap-mcpdm.h" #include "omap-pcm.h" #include "../codecs/twl6040.h"
Signature · 1 line
1.7.6.1
Quoted 8 lines · Peter Ujfalusi
From: Misael Lopez Cruz <[email protected]>
Reasons for the replacement:
The current driver for McPDM was developed to support the legacy mode only. In preparation for the ABE support the current driver stack need the be replaced.
The new driver is much simpler, easier to extend, and it also fixes some of the issues with the old stack.