Skip to contentSkip to conversation

USB GADGET: u_serial.c: fixed a brace and whitespace coding style issue

PATCH In review Shaun Kluzek 3 participants 3 messages Aug 31, 2011 – Sep 18, 2011 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB GADGET: u_serial.c: fixed a brace and whitespace coding style issue

---
 drivers/usb/gadget/u_serial.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
drivers/usb/gadget/u_serial.c +1 -4
index a8aa469..b86022f 100644
@@ -552,11 +552,8 @@ recycle:
 	/* Push from tty to ldisc; without low_latency set this is handled by
 	 * a workqueue, so we won't get callbacks and can hold port_lock
 	 */
-	if (tty && do_push) {
+	if (tty && do_push)
 		tty_flip_buffer_push(tty);
-	}
-
-
 	/* We want our data queue to become empty ASAP, keeping data
 	 * in the tty and ldisc (not here).  If we couldn't push any
 	 * this time around, there may be trouble unless there's an
Signature · 1 line
1.7.3.4
#1 lore raw

Hello.

Quoted 10 lines · Shaun Kluzek
---
  drivers/usb/gadget/u_serial.c |    5 +----
  1 files changed, 1 insertions(+), 4 deletions(-)
drivers/usb/gadget/u_serial.c +0 -0
index a8aa469..b86022f 100644

drivers/usb/gadget/u_serial.c recycle: · line 558

Quoted 8 lines
drivers/usb/gadget/u_serial.c +1 -3
@@ -552,11 +552,8 @@ recycle:
  	/* Push from tty to ldisc; without low_latency set this is handled by
  	 * a workqueue, so we won't get callbacks and can hold port_lock
  	 */
-	if (tty && do_push) {
+	if (tty && do_push)
  		tty_flip_buffer_push(tty);
-	}
-

What's wrong with the first empty line here?

drivers/usb/gadget/u_serial.c recycle: · line 559

Quoted 4 lines
drivers/usb/gadget/u_serial.c +0 -1
-
  	/* We want our data queue to become empty ASAP, keeping data
  	 * in the tty and ldisc (not here).  If we couldn't push any
  	 * this time around, there may be trouble unless there's an

WBR, Sergei

#2 lore raw
Quoted 9 lines · Sergei Shtylyov

Hello.

Quoted 4 lines · Shaun Kluzek
---
 drivers/usb/gadget/u_serial.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
Quoted 17 lines

drivers/usb/gadget/u_serial.c recycle: · line 558

Quoted 13 lines
drivers/usb/gadget/u_serial.c +1 -3
index a8aa469..b86022f 100644
@@ -552,11 +552,8 @@ recycle:
 	/* Push from tty to ldisc; without low_latency set this is handled by
 	 * a workqueue, so we won't get callbacks and can hold port_lock
 	 */
-	if (tty && do_push) {
+	if (tty && do_push)
 		tty_flip_buffer_push(tty);
-	}
-

What's wrong with the first empty line here?

Quoted 1 line
drivers/usb/gadget/u_serial.c +0 -1
-

I agree, don't delete all of the spacing here.

greg k-h