Skip to contentSkip to conversation

ath6kl: Do not enable Probe Request reporting by default

PATCH In review Jouni Malinen 2 participants 2 messages Sep 1, 2011 Atheros ATH6KL wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath6kl: Do not enable Probe Request reporting by default

Probe Request reporting will be needed for P2P and WPS, but some firmware builds do not seem to like this when P2P is not enabled. Since we do not yet enable P2P, the safest option here is to just remove this call for now and bring it back as a more dynamic version once ath6kl starts advertising support for P2P.

---
 drivers/net/wireless/ath/ath6kl/init.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
drivers/net/wireless/ath/ath6kl/init.c +0 -7
index f348357..96953be 100644
@@ -473,13 +473,6 @@ static int ath6kl_target_config_wlan_params(struct ath6kl *ar)
 			   ret);
 	}
 
-	/* Enable Probe Request reporting for P2P */
-	ret = ath6kl_wmi_probe_report_req_cmd(ar->wmi, true);
-	if (ret) {
-		ath6kl_dbg(ATH6KL_DBG_TRC, "failed to enable Probe Request "
-			   "reporting (%d)\n", ret);
-	}
-
 	return status;
 }
 
Signature · 5 lines
1.7.4.1


-- 
Jouni Malinen                                            PGP id EFC895FA
#1 lore raw
Quoted 5 lines · Jouni Malinen

Probe Request reporting will be needed for P2P and WPS, but some firmware builds do not seem to like this when P2P is not enabled. Since we do not yet enable P2P, the safest option here is to just remove this call for now and bring it back as a more dynamic version once ath6kl starts advertising support for P2P.

Thanks, applied to my local ath6kl.git.

Kalle